gEDA-cvs: branch: master updated (1.1.1.20070708-67-ge04284b)

[git@xxxxxxxxxx]

The branch, master has been updated
       via  e04284b595dffa4b9931872ae33b76daede58dd7 (commit)
       via  802a2fea15d9bd918bd2398ac06bf6ca9b2e75c4 (commit)
       via  fa2045b8e9cac268fe0c0b7af2028ea768c8e465 (commit)
      from  663e133ff0c0e153a8081b36404c0808222c6dcb (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


=========
 Summary
=========

 gschem/src/x_compselect.c |   23 +++++++++++++++--------
 1 files changed, 15 insertions(+), 8 deletions(-)


=================
 Commit Messages
=================

commit e04284b595dffa4b9931872ae33b76daede58dd7
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Date:   Sun Aug 12 01:57:17 2007 +0100

    Fix component selector filtering after using the "Refresh" button.

:100644 100644 b1f49d7... 72b9ff0... M	gschem/src/x_compselect.c

commit 802a2fea15d9bd918bd2398ac06bf6ca9b2e75c4
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Date:   Sun Aug 12 01:57:00 2007 +0100

    Make updates faster when typing in the component selector filter.
    
    The filtering process doesn't happen until after the user pauses typing.
    Reducing the update delay from 300ms to 200ms makes this feel better.

:100644 100644 282a78b... b1f49d7... M	gschem/src/x_compselect.c

commit fa2045b8e9cac268fe0c0b7af2028ea768c8e465
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Date:   Sun Aug 12 01:56:58 2007 +0100

    Fix crash closing component selector window quickly after filtering.
    
    Typing in the filter box adds new update timeouts (300ms) with each
    keystroke. If typing fast there could be more than one timer active at
    once, however only the last added is cancelled when closing the dialog.
    Timers which ran after the dialog closed could cause a segfault.
    
    We now cancel any pending timeout before adding a new one.

:100644 100644 504ceb1... 282a78b... M	gschem/src/x_compselect.c

=========
 Changes
=========

commit e04284b595dffa4b9931872ae33b76daede58dd7
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Date:   Sun Aug 12 01:57:17 2007 +0100

    Fix component selector filtering after using the "Refresh" button.

diff --git a/gschem/src/x_compselect.c b/gschem/src/x_compselect.c
index b1f49d7..72b9ff0 100644
--- a/gschem/src/x_compselect.c
+++ b/gschem/src/x_compselect.c
@@ -670,6 +670,11 @@ compselect_callback_refresh_library (Compselect *compselect,
                   "virtual-root", NULL,
                   NULL);
 
+  gtk_tree_model_filter_set_visible_func ((GtkTreeModelFilter*)model,
+                                          lib_model_filter_visible_func,
+                                          compselect,
+                                          NULL);
+
   gtk_tree_view_set_model (compselect->libtreeview, model);
 
   /* Refresh the "In Use" view */

commit 802a2fea15d9bd918bd2398ac06bf6ca9b2e75c4
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Date:   Sun Aug 12 01:57:00 2007 +0100

    Make updates faster when typing in the component selector filter.
    
    The filtering process doesn't happen until after the user pauses typing.
    Reducing the update delay from 300ms to 200ms makes this feel better.

diff --git a/gschem/src/x_compselect.c b/gschem/src/x_compselect.c
index 282a78b..b1f49d7 100644
--- a/gschem/src/x_compselect.c
+++ b/gschem/src/x_compselect.c
@@ -61,7 +61,7 @@
  *
  *  Unit is milliseconds.
  */
-#define COMPSELECT_FILTER_INTERVAL 300
+#define COMPSELECT_FILTER_INTERVAL 200
 
 
 /*! \brief Process the response returned by the component selection dialog.

commit fa2045b8e9cac268fe0c0b7af2028ea768c8e465
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Date:   Sun Aug 12 01:56:58 2007 +0100

    Fix crash closing component selector window quickly after filtering.
    
    Typing in the filter box adds new update timeouts (300ms) with each
    keystroke. If typing fast there could be more than one timer active at
    once, however only the last added is cancelled when closing the dialog.
    Timers which ran after the dialog closed could cause a segfault.
    
    We now cancel any pending timeout before adding a new one.

diff --git a/gschem/src/x_compselect.c b/gschem/src/x_compselect.c
index 504ceb1..282a78b 100644
--- a/gschem/src/x_compselect.c
+++ b/gschem/src/x_compselect.c
@@ -509,13 +509,15 @@ compselect_callback_filter_entry_changed (GtkEditable *editable,
     gtk_widget_set_sensitive (button, sensitive);
   }
 
-  /* ask for an update of the component list */
-  /* re-evaluation of filter will occur in _INTERVAL ms unless entry */
-  /* has been modified again */
-  compselect->filter_timeout =
-    g_timeout_add (COMPSELECT_FILTER_INTERVAL,
-                   compselect_filter_timeout,
-                   compselect);
+  /* Cancel any pending update of the component list filter */
+  if (compselect->filter_timeout != 0)
+    g_source_remove (compselect->filter_timeout);
+
+  /* Schedule an update of the component list filter in
+   * COMPSELECT_FILTER_INTERVAL milliseconds */
+  compselect->filter_timeout = g_timeout_add (COMPSELECT_FILTER_INTERVAL,
+                                              compselect_filter_timeout,
+                                              compselect);
  
 }
 




_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs