gEDA-cvs: gaf.git: branch: master updated (1.5.0-20080706-65-g1e247ae)

[git@xxxxxxxxxx]

The branch, master has been updated
       via  1e247aeb7a4f568578bd8612f886d7f64f24c858 (commit)
      from  f154fcb921e75e7940e0b4dbd9ad5bab6a61e704 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


=========
 Summary
=========

 gschem/src/i_callbacks.c |    4 ----
 gschem/src/o_attrib.c    |    4 ++++
 2 files changed, 4 insertions(+), 4 deletions(-)


=================
 Commit Messages
=================

commit 1e247aeb7a4f568578bd8612f886d7f64f24c858
Author: Patrick Bernaud <b-patrick@xxxxxxxxxx>
Date:   Fri Aug 1 14:37:48 2008 +0200

    Keep raising the page changed flag local to mutation for o_attrib_toggle_*().
    
    Reverted the settings of the CHANGED flag in o_attrib_toggle_*(): they
    had been moved inadvertently to i_callback_*() functions (see commits
    903e06d9fc9253e87e530bfaec2e8386664d464f and
    fd51b8163c5af2d8124dc7afb1ca1c4bfa944fe6) while they really should
    stay close to where the object is modified.
    
    Problem reported by Bernd Jendrissek on gEDA-dev.

:100644 100644 ed02ded... 7022c7e... M	gschem/src/i_callbacks.c
:100644 100644 48c971a... 6da82a8... M	gschem/src/o_attrib.c

=========
 Changes
=========

commit 1e247aeb7a4f568578bd8612f886d7f64f24c858
Author: Patrick Bernaud <b-patrick@xxxxxxxxxx>
Date:   Fri Aug 1 14:37:48 2008 +0200

    Keep raising the page changed flag local to mutation for o_attrib_toggle_*().
    
    Reverted the settings of the CHANGED flag in o_attrib_toggle_*(): they
    had been moved inadvertently to i_callback_*() functions (see commits
    903e06d9fc9253e87e530bfaec2e8386664d464f and
    fd51b8163c5af2d8124dc7afb1ca1c4bfa944fe6) while they really should
    stay close to where the object is modified.
    
    Problem reported by Bernd Jendrissek on gEDA-dev.

diff --git a/gschem/src/i_callbacks.c b/gschem/src/i_callbacks.c
index ed02ded..7022c7e 100644
--- a/gschem/src/i_callbacks.c
+++ b/gschem/src/i_callbacks.c
@@ -3128,7 +3128,6 @@ DEFINE_I_CALLBACK(attributes_show_name)
       o_attrib_toggle_show_name_value (w_current, object, SHOW_NAME);
     }
 
-    toplevel->page_current->CHANGED=1;
     o_undo_savestate (w_current, UNDO_ALL);
   }
 }
@@ -3165,7 +3164,6 @@ DEFINE_I_CALLBACK(attributes_show_value)
       o_attrib_toggle_show_name_value (w_current, object, SHOW_VALUE);
     }
 
-    toplevel->page_current->CHANGED=1;
     o_undo_savestate (w_current, UNDO_ALL);
   }
 }
@@ -3202,7 +3200,6 @@ DEFINE_I_CALLBACK(attributes_show_both)
       o_attrib_toggle_show_name_value (w_current, object, SHOW_NAME_VALUE);
     }
 
-    toplevel->page_current->CHANGED=1;
     o_undo_savestate (w_current, UNDO_ALL);
   }
 }
@@ -3240,7 +3237,6 @@ DEFINE_I_CALLBACK(attributes_visibility_toggle)
       o_attrib_toggle_visibility (w_current, object);
     }
 
-    toplevel->page_current->CHANGED=1;
     o_undo_savestate (w_current, UNDO_ALL);
   }
 }
diff --git a/gschem/src/o_attrib.c b/gschem/src/o_attrib.c
index 48c971a..6da82a8 100644
--- a/gschem/src/o_attrib.c
+++ b/gschem/src/o_attrib.c
@@ -131,6 +131,8 @@ void o_attrib_toggle_visibility(GSCHEM_TOPLEVEL *w_current, OBJECT *object)
 
     o_text_draw(w_current, object);
   }
+
+  toplevel->page_current->CHANGED = 1;
 }
 
 /*! \brief Set what part of an attribute is shown.
@@ -154,6 +156,8 @@ void o_attrib_toggle_show_name_value(GSCHEM_TOPLEVEL *w_current,
   object->show_name_value = show_name_value;
   o_text_recreate(toplevel, object);
   o_text_draw(w_current, object);
+
+  toplevel->page_current->CHANGED = 1;
 }
 
 




_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs