gEDA-cvs: gaf.git: branch: master updated (1.5.0-20080706-71-gd86ac8c)

[git@xxxxxxxxxx]

The branch, master has been updated
       via  d86ac8ce4b16d41699ec64a3d88fd8d2c760b770 (commit)
      from  713225e719fa1bab8bc4b31dfc3cd50ea6c44f4e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


=========
 Summary
=========

 gschem/src/gschem_dialog.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)


=================
 Commit Messages
=================

commit d86ac8ce4b16d41699ec64a3d88fd8d2c760b770
Author: Cesar Strauss <cestrauss@xxxxxxxxx>
Date:   Sun Sep 16 16:56:18 2007 -0300

    Fix for dialogs drifting downwards on Cygwin/X.
    
    On Cygwin/X, reopening a gschem dialog restores its original position,
    but with a small vertical offset.
    
    The workaround is to show the dialog before restoring its position.
    
    The docs for gtk_window_move() offer a possible justification:
      "Most window managers ignore requests for initial window positions
      (instead using a user-defined placement algorithm) and honor requests
      after the window has already been shown."
    
    The downside is, if you have a slow system, you could see the dialog
    appear briefly at the old position, I suppose.

:100644 100644 7c8410f... 2493c10... M	gschem/src/gschem_dialog.c

=========
 Changes
=========

commit d86ac8ce4b16d41699ec64a3d88fd8d2c760b770
Author: Cesar Strauss <cestrauss@xxxxxxxxx>
Date:   Sun Sep 16 16:56:18 2007 -0300

    Fix for dialogs drifting downwards on Cygwin/X.
    
    On Cygwin/X, reopening a gschem dialog restores its original position,
    but with a small vertical offset.
    
    The workaround is to show the dialog before restoring its position.
    
    The docs for gtk_window_move() offer a possible justification:
      "Most window managers ignore requests for initial window positions
      (instead using a user-defined placement algorithm) and honor requests
      after the window has already been shown."
    
    The downside is, if you have a slow system, you could see the dialog
    appear briefly at the old position, I suppose.

diff --git a/gschem/src/gschem_dialog.c b/gschem/src/gschem_dialog.c
index 7c8410f..2493c10 100644
--- a/gschem/src/gschem_dialog.c
+++ b/gschem/src/gschem_dialog.c
@@ -221,6 +221,9 @@ static void show_handler (GtkWidget *widget)
   gchar *group_name;
   GschemDialog *dialog = GSCHEM_DIALOG( widget );
 
+  /* Let GTK show the window */
+  GTK_WIDGET_CLASS (gschem_dialog_parent_class)->show (widget);
+
   group_name = dialog->settings_name;
   if (group_name != NULL) {
 
@@ -231,9 +234,6 @@ static void show_handler (GtkWidget *widget)
                      dialog_geometry, group_name);
     }
   }
-
-  /* Let GTK show the window */
-  GTK_WIDGET_CLASS (gschem_dialog_parent_class)->show (widget);
 }
 
 




_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs