gEDA-cvs: gaf.git: branch: master updated (1.5.0-20080706-127-g1fa51c0)

[git@xxxxxxxxxx]

The branch, master has been updated
       via  1fa51c0ccf1cf09ba184493e9b9aa7670f0752a3 (commit)
      from  ae825d00b79676fd7a406a1b8c5e7ca3c9f8c6a9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


=========
 Summary
=========

 libgeda/src/o_complex_basic.c |   12 ------------
 1 files changed, 0 insertions(+), 12 deletions(-)


=================
 Commit Messages
=================

commit 1fa51c0ccf1cf09ba184493e9b9aa7670f0752a3
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Date:   Sat Aug 16 19:59:57 2008 +0100

    o_complex_add: Remove un-needed save/restore of PAGE->object_tail (CODE!)
    
    (* FOR GOODNESS SAKE PETER, TRY TO COMMIT THE CODE WITH THE COMMIT!)
    
    toplevel->page_current->object_tail was saved and restored around
    symbol data loading and subsequent attribute promotion.
    
    The PAGE->object_tail is not altered during this block of code.
    This was experimentally verified during significant "real work"
    usage conducted with a g_assert() prior to the restore step.

:100644 100644 966a228... bf4bdab... M	libgeda/src/o_complex_basic.c

=========
 Changes
=========

commit 1fa51c0ccf1cf09ba184493e9b9aa7670f0752a3
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Date:   Sat Aug 16 19:59:57 2008 +0100

    o_complex_add: Remove un-needed save/restore of PAGE->object_tail (CODE!)
    
    (* FOR GOODNESS SAKE PETER, TRY TO COMMIT THE CODE WITH THE COMMIT!)
    
    toplevel->page_current->object_tail was saved and restored around
    symbol data loading and subsequent attribute promotion.
    
    The PAGE->object_tail is not altered during this block of code.
    This was experimentally verified during significant "real work"
    usage conducted with a g_assert() prior to the restore step.

diff --git a/libgeda/src/o_complex_basic.c b/libgeda/src/o_complex_basic.c
index 966a228..bf4bdab 100644
--- a/libgeda/src/o_complex_basic.c
+++ b/libgeda/src/o_complex_basic.c
@@ -319,7 +319,6 @@ OBJECT *o_complex_add(TOPLEVEL *toplevel, OBJECT *object_list,
 {
   OBJECT *new_node=NULL;
   OBJECT *prim_objs=NULL;
-  OBJECT *temp_tail=NULL;
   OBJECT *temp_parent=NULL;
   int save_adding_sel = 0;
   int loaded_normally = FALSE;
@@ -369,15 +368,6 @@ OBJECT *o_complex_add(TOPLEVEL *toplevel, OBJECT *object_list,
   /* set the parent field now */
   prim_objs->complex_parent = new_node;
 
-  /* is the bit with the temp and object_tail needed? */
-  /* I don't like this at all hack */
-  /* careful whenever you select, you get a read from disk */
-  /* for the objects, UGG! there foreattribs are being copied */
-  /* you need to override them if there are attached ones */
-  /* on the main list */
-  temp_tail = toplevel->page_current->object_tail;
-  /* reason this works is because it has a head, see add_head above */
-
   /* get the symbol data */
   if (clib != NULL) {
     buffer = s_clib_symbol_get_data (clib);
@@ -551,8 +541,6 @@ OBJECT *o_complex_add(TOPLEVEL *toplevel, OBJECT *object_list,
     }
   }
 
-  toplevel->page_current->object_tail = temp_tail;
-
   if (use_object_list) {
     object_list = (OBJECT *) s_basic_link_object(new_node, object_list);
     object_list->complex->prim_objs = prim_objs;




_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs