[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

gEDA-cvs: gaf.git: branch: master updated (1.5.0-20080706-369-g77541e1)



The branch, master has been updated
       via  77541e1ec2efdc989b0a17864c1c0802080ff835 (commit)
      from  d2877ab739c26ed6330fdeac2711326442395640 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


=========
 Summary
=========

 libgeda/src/o_bus_basic.c  |    5 -----
 libgeda/src/o_line_basic.c |   10 +++-------
 libgeda/src/o_net_basic.c  |    5 -----
 libgeda/src/o_pin_basic.c  |    7 -------
 4 files changed, 3 insertions(+), 24 deletions(-)


=================
 Commit Messages
=================

commit 77541e1ec2efdc989b0a17864c1c0802080ff835
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Date:   Fri Dec 12 14:03:27 2008 +0000

    Remove un-necessary copying of line end-points in o_..._copy()
    
    The end-points are already set when o_..._copy() calls o_..._new().

:100644 100644 63626e7... c5247c7... M	libgeda/src/o_bus_basic.c
:100644 100644 17cae09... afcf684... M	libgeda/src/o_line_basic.c
:100644 100644 313b914... 80b16df... M	libgeda/src/o_net_basic.c
:100644 100644 4bb5d3d... 20d3561... M	libgeda/src/o_pin_basic.c

=========
 Changes
=========

commit 77541e1ec2efdc989b0a17864c1c0802080ff835
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Date:   Fri Dec 12 14:03:27 2008 +0000

    Remove un-necessary copying of line end-points in o_..._copy()
    
    The end-points are already set when o_..._copy() calls o_..._new().

diff --git a/libgeda/src/o_bus_basic.c b/libgeda/src/o_bus_basic.c
index 63626e7..c5247c7 100644
--- a/libgeda/src/o_bus_basic.c
+++ b/libgeda/src/o_bus_basic.c
@@ -270,11 +270,6 @@ OBJECT *o_bus_copy(TOPLEVEL *toplevel, OBJECT *o_current)
                        o_current->line->x[1], o_current->line->y[1],
                        o_current->bus_ripper_direction);
 
-  new_obj->line->x[0] = o_current->line->x[0];
-  new_obj->line->y[0] = o_current->line->y[0];
-  new_obj->line->x[1] = o_current->line->x[1];
-  new_obj->line->y[1] = o_current->line->y[1];
-
   return new_obj;
 }
 
diff --git a/libgeda/src/o_line_basic.c b/libgeda/src/o_line_basic.c
index 17cae09..afcf684 100644
--- a/libgeda/src/o_line_basic.c
+++ b/libgeda/src/o_line_basic.c
@@ -119,7 +119,9 @@ OBJECT *o_line_copy(TOPLEVEL *toplevel, OBJECT *o_current)
 
   /* A new line object is created with #o_line_new().
    * Values for its fields are default and need to be modified. */
-  new_obj = o_line_new (toplevel, OBJ_LINE, color, 0, 0, 0, 0);
+  new_obj = o_line_new (toplevel, OBJ_LINE, color,
+                        o_current->line->x[0], o_current->line->y[0],
+                        o_current->line->x[1], o_current->line->y[1]);
 
   /*
    * The coordinates of the ends of the new line are set with the ones
@@ -130,12 +132,6 @@ OBJECT *o_line_copy(TOPLEVEL *toplevel, OBJECT *o_current)
    * #o_line_recalc().
    */
 
-  /* modify the line ends of the new line */
-  new_obj->line->x[0] = o_current->line->x[0];
-  new_obj->line->y[0] = o_current->line->y[0];
-  new_obj->line->x[1] = o_current->line->x[1];
-  new_obj->line->y[1] = o_current->line->y[1];
-  
   /* copy the line type and filling options */
   o_set_line_options(toplevel, new_obj, o_current->line_end,
 		     o_current->line_type, o_current->line_width,
diff --git a/libgeda/src/o_net_basic.c b/libgeda/src/o_net_basic.c
index 313b914..80b16df 100644
--- a/libgeda/src/o_net_basic.c
+++ b/libgeda/src/o_net_basic.c
@@ -256,11 +256,6 @@ OBJECT *o_net_copy(TOPLEVEL *toplevel,  OBJECT *o_current)
                        o_current->line->x[0], o_current->line->y[0],
                        o_current->line->x[1], o_current->line->y[1]);
 
-  new_obj->line->x[0] = o_current->line->x[0];
-  new_obj->line->y[0] = o_current->line->y[0];
-  new_obj->line->x[1] = o_current->line->x[1];
-  new_obj->line->y[1] = o_current->line->y[1];
-
   return new_obj;
 }
 
diff --git a/libgeda/src/o_pin_basic.c b/libgeda/src/o_pin_basic.c
index 4bb5d3d..20d3561 100644
--- a/libgeda/src/o_pin_basic.c
+++ b/libgeda/src/o_pin_basic.c
@@ -272,13 +272,6 @@ OBJECT *o_pin_copy(TOPLEVEL *toplevel, OBJECT *o_current)
                        o_current->line->x[1], o_current->line->y[1],
                        o_current->pin_type, o_current->whichend);
 
-  new_obj->line->x[0] = o_current->line->x[0];
-  new_obj->line->y[0] = o_current->line->y[0];
-  new_obj->line->x[1] = o_current->line->x[1];
-  new_obj->line->y[1] = o_current->line->y[1];
-
-  /*	new_obj->attribute = 0;*/
-
   return new_obj;
 }
 




_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs