gEDA-cvs: gaf.git: branch: master updated (1.5.0-20080706-431-ge51ce94)

[git@xxxxxxxxxx]

The branch, master has been updated
       via  e51ce946141363fa796a8744d5600bbe3436b925 (commit)
      from  581f8cec3d5e717fa78417772759b4525a52f458 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


=========
 Summary
=========

 gschem/src/o_arc.c     |    4 +---
 gschem/src/o_box.c     |    4 +---
 gschem/src/o_circle.c  |    4 +---
 gschem/src/o_path.c    |    4 +---
 gschem/src/o_picture.c |    4 ----
 5 files changed, 4 insertions(+), 16 deletions(-)


=================
 Commit Messages
=================

commit e51ce946141363fa796a8744d5600bbe3436b925
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Date:   Sat Dec 20 19:10:18 2008 +0000

    gschem: Remove visible() checks from drawing functions
    
    The expose handler, via o_redraw_rects() only calls drawing functions for
    objects which need repainting. No need for them to re-check visibility.

:100644 100644 e8828d4... cd4acde... M	gschem/src/o_arc.c
:100644 100644 11a2db7... 070491a... M	gschem/src/o_box.c
:100644 100644 72add72... db9fd96... M	gschem/src/o_circle.c
:100644 100644 d43e7fb... 0b6951e... M	gschem/src/o_path.c
:100644 100644 92e8e9c... b1b1f5a... M	gschem/src/o_picture.c

=========
 Changes
=========

commit e51ce946141363fa796a8744d5600bbe3436b925
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Date:   Sat Dec 20 19:10:18 2008 +0000

    gschem: Remove visible() checks from drawing functions
    
    The expose handler, via o_redraw_rects() only calls drawing functions for
    objects which need repainting. No need for them to re-check visibility.

diff --git a/gschem/src/o_arc.c b/gschem/src/o_arc.c
index e8828d4..cd4acde 100644
--- a/gschem/src/o_arc.c
+++ b/gschem/src/o_arc.c
@@ -64,10 +64,8 @@ void o_arc_draw(GSCHEM_TOPLEVEL *w_current, OBJECT *o_current)
   world_get_single_object_bounds(toplevel, o_current,
                                  &wleft, &wtop, &wright, &wbottom);
 
-  if ( (toplevel->DONT_REDRAW == 1) ||
-       (!visible(toplevel, wleft, wtop, wright, wbottom)) ) {
+  if (toplevel->DONT_REDRAW == 1)
     return;
-  }
 
   /*
    * As an arc is definetely not a closed shape there is no need to
diff --git a/gschem/src/o_box.c b/gschem/src/o_box.c
index 11a2db7..070491a 100644
--- a/gschem/src/o_box.c
+++ b/gschem/src/o_box.c
@@ -80,10 +80,8 @@ void o_box_draw(GSCHEM_TOPLEVEL *w_current, OBJECT *o_current)
   world_get_single_object_bounds(toplevel, o_current,
                                  &wleft, &wtop, &wright, &wbottom);
 	
-  if ( (toplevel->DONT_REDRAW == 1) ||
-       (!visible(toplevel, wleft, wtop, wright, wbottom)) ) {
+  if (toplevel->DONT_REDRAW == 1)
     return;
-  }
 	
 #if DEBUG
   printf("drawing box\n\n");
diff --git a/gschem/src/o_circle.c b/gschem/src/o_circle.c
index 72add72..db9fd96 100644
--- a/gschem/src/o_circle.c
+++ b/gschem/src/o_circle.c
@@ -75,10 +75,8 @@ void o_circle_draw(GSCHEM_TOPLEVEL *w_current, OBJECT *o_current)
   world_get_single_object_bounds(toplevel, o_current,
                                  &wleft, &wtop, &wright, &wbottom);
 	
-  if ( (toplevel->DONT_REDRAW == 1) ||
-       (!visible(toplevel, wleft, wtop, wright, wbottom)) ) {
+  if (toplevel->DONT_REDRAW == 1)
     return;
-  }
 	
 #if DEBUG
   printf("drawing circle\n\n");
diff --git a/gschem/src/o_path.c b/gschem/src/o_path.c
index d43e7fb..0b6951e 100644
--- a/gschem/src/o_path.c
+++ b/gschem/src/o_path.c
@@ -462,10 +462,8 @@ void o_path_draw(GSCHEM_TOPLEVEL *w_current, OBJECT *o_current)
   world_get_single_object_bounds(toplevel, o_current,
                                  &wleft, &wtop, &wright, &wbottom);
 
-  if ( (toplevel->DONT_REDRAW == 1) ||
-       (!visible(toplevel, wleft, wtop, wright, wbottom)) ) {
+  if (toplevel->DONT_REDRAW == 1)
     return;
-  }
 
   if (toplevel->override_color != -1 )
     color = x_get_color(toplevel->override_color);
diff --git a/gschem/src/o_picture.c b/gschem/src/o_picture.c
index 92e8e9c..b1b1f5a 100644
--- a/gschem/src/o_picture.c
+++ b/gschem/src/o_picture.c
@@ -332,10 +332,6 @@ void o_picture_draw(GSCHEM_TOPLEVEL *w_current, OBJECT *o_current)
   world_get_single_object_bounds(toplevel, o_current,
                                  &wleft, &wtop, &wright, &wbottom);
 	
-  if (!visible(toplevel, wleft, wtop, wright, wbottom)) {
-    return;
-  }
-
   WORLDtoSCREEN( toplevel, o_current->picture->upper_x, o_current->picture->upper_y,
                  &s_upper_x, &s_upper_y );
   WORLDtoSCREEN( toplevel, o_current->picture->lower_x, o_current->picture->lower_y,




_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs