[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

gEDA-cvs: gaf.git: branch: master updated (1.7.1-20110619-237-g18f8872)



The branch, master has been updated
       via  18f88729bec5c5ef120d123ce7dcee7537bc6c04 (commit)
       via  574c85ad6decf49fc64bad0214f045a69fe1d1c3 (commit)
       via  0b7b7616785d75eeda689ac9a33c9e99b4796d02 (commit)
      from  ebfe6ae6a76b6a44a0bbe2d184bf99bfee7d97bf (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


=========
 Summary
=========

 gnetlist/scheme/gnet-gsch2pcb.scm.in |    2 ++
 libgeda/include/libgeda/prototype.h  |    2 +-
 libgeda/src/s_clib.c                 |    2 +-
 utils/src/gsch2pcb.c                 |    9 ++++++---
 4 files changed, 10 insertions(+), 5 deletions(-)


=================
 Commit Messages
=================

commit 18f88729bec5c5ef120d123ce7dcee7537bc6c04
Author: Peter TB Brett <peter@xxxxxxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>

    gsch2pcb: Show subprocess output in verbose mode.
    
    Commit fdd787ab8698 prevented gsch2pcb from ever outputting subprocess
    standard output, even in verbose mode.  However, sometimes it's useful
    to see the output of subprocesses, e.g. backend configuration info
    from the gsch2pcb gnetlist backend.  This patch makes gsch2pcb output
    subprocess standard output when in verbose mode, but suppress it
    normally.
    
    Closes-bug: lp-713968

:100644 100644 7c0e8fc... 7c89882... M	utils/src/gsch2pcb.c

commit 574c85ad6decf49fc64bad0214f045a69fe1d1c3
Author: Peter TB Brett <peter@xxxxxxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>

    gsch2pcb: Fix broken gnetlist backend.
    
    Fix breakage to gsch2pcb backend introduced in commit 579fbb4828a7.

:100644 100644 cbde743... c38be99... M	gnetlist/scheme/gnet-gsch2pcb.scm.in

commit 0b7b7616785d75eeda689ac9a33c9e99b4796d02
Author: Peter TB Brett <peter@xxxxxxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>

    libgeda: Correct prototype for s_clib_symbol_invalidate_data().
    
    Hurrah, rookie errors.

:100644 100644 08fefce... 756d583... M	libgeda/include/libgeda/prototype.h
:100644 100644 5edcbb7... 8d76dc5... M	libgeda/src/s_clib.c

=========
 Changes
=========

commit 18f88729bec5c5ef120d123ce7dcee7537bc6c04
Author: Peter TB Brett <peter@xxxxxxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>

    gsch2pcb: Show subprocess output in verbose mode.
    
    Commit fdd787ab8698 prevented gsch2pcb from ever outputting subprocess
    standard output, even in verbose mode.  However, sometimes it's useful
    to see the output of subprocesses, e.g. backend configuration info
    from the gsch2pcb gnetlist backend.  This patch makes gsch2pcb output
    subprocess standard output when in verbose mode, but suppress it
    normally.
    
    Closes-bug: lp-713968

diff --git a/utils/src/gsch2pcb.c b/utils/src/gsch2pcb.c
index 7c0e8fc..7c89882 100644
--- a/utils/src/gsch2pcb.c
+++ b/utils/src/gsch2pcb.c
@@ -138,6 +138,7 @@ build_and_run_command (const gchar *format, ...)
   gint status;
   gboolean result = FALSE;
   gboolean spawn_result;
+  gchar *standard_output = NULL;
   gchar *standard_error = NULL;
   GError * error = NULL;
 
@@ -180,14 +181,15 @@ build_and_run_command (const gchar *format, ...)
     if (g_spawn_sync (".",                  /* Working directory */
                       args,                 /* argv */
                       NULL,                 /* envp */
-                      G_SPAWN_SEARCH_PATH | /* flags */
-                      G_SPAWN_STDOUT_TO_DEV_NULL,
+                      G_SPAWN_SEARCH_PATH,  /* flags */
                       NULL,                 /* child_setup */
                       NULL,                 /* user data */
-                      NULL,                 /* standard output */
+                      &standard_output,     /* standard output */
                       &standard_error,      /* standard error */
                       &status,              /* exit status return */
                       &error)) {            /* GError return */
+      if (verbose)
+        fputs(standard_output, stdout);
       if (status == 0)
         result = TRUE;
       else {
@@ -204,6 +206,7 @@ build_and_run_command (const gchar *format, ...)
       printf ("\n%s", SEP_STRING);
 
     g_free(standard_error);
+    g_free (standard_output);
     
     g_free (args);
     /* free the list, but leave data untouched */

commit 574c85ad6decf49fc64bad0214f045a69fe1d1c3
Author: Peter TB Brett <peter@xxxxxxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>

    gsch2pcb: Fix broken gnetlist backend.
    
    Fix breakage to gsch2pcb backend introduced in commit 579fbb4828a7.

diff --git a/gnetlist/scheme/gnet-gsch2pcb.scm.in b/gnetlist/scheme/gnet-gsch2pcb.scm.in
index cbde743..c38be99 100644
--- a/gnetlist/scheme/gnet-gsch2pcb.scm.in
+++ b/gnetlist/scheme/gnet-gsch2pcb.scm.in
@@ -163,6 +163,8 @@
 		      )
       )
 
+(define-undefined gsch2pcb:pcb-m4-command-line gsch2pcb:m4-command-line)
+
 (define (gsch2pcb output-filename)
   (let ((port (open-output-file output-filename)))
     (gsch2pcb:write-top-header port)

commit 0b7b7616785d75eeda689ac9a33c9e99b4796d02
Author: Peter TB Brett <peter@xxxxxxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>

    libgeda: Correct prototype for s_clib_symbol_invalidate_data().
    
    Hurrah, rookie errors.

diff --git a/libgeda/include/libgeda/prototype.h b/libgeda/include/libgeda/prototype.h
index 08fefce..756d583 100644
--- a/libgeda/include/libgeda/prototype.h
+++ b/libgeda/include/libgeda/prototype.h
@@ -299,7 +299,7 @@ gchar *s_clib_symbol_get_data (const CLibSymbol *symbol);
 GList *s_clib_search (const gchar *pattern, const CLibSearchMode mode);
 void s_clib_flush_search_cache ();
 void s_clib_flush_symbol_cache ();
-void s_clib_symbol_invalidate_data (CLibSymbol *symbol);
+void s_clib_symbol_invalidate_data (const CLibSymbol *symbol);
 const CLibSymbol *s_clib_get_symbol_by_name (const gchar *name);
 gchar *s_clib_symbol_get_data_by_name (const gchar *name);
 GList *s_toplevel_get_symbols (const TOPLEVEL *toplevel);
diff --git a/libgeda/src/s_clib.c b/libgeda/src/s_clib.c
index 5edcbb7..8d76dc5 100644
--- a/libgeda/src/s_clib.c
+++ b/libgeda/src/s_clib.c
@@ -1360,7 +1360,7 @@ void s_clib_flush_symbol_cache ()
  * \param symbol Symbol to flush cached data for.
  */
 void
-s_clib_symbol_invalidate_data (CLibSymbol *symbol)
+s_clib_symbol_invalidate_data (const CLibSymbol *symbol)
 {
   g_hash_table_remove (clib_symbol_cache, (gpointer) symbol);
 }




_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs