gEDA-cvs: gaf.git: branch: master updated (1.7.1-20110619-255-g361ed60)

[git@xxxxxxxxxx]

The branch, master has been updated
       via  361ed60e515c4bb4796b576004906955ef242a33 (commit)
       via  42182f0ae6b16171329f00f32ff1857d38c1c33e (commit)
      from  523f5bd65a7cea56bdfca7cab5650832273e24bc (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


=========
 Summary
=========

 gschem/src/x_multiattrib.c |    3 +++
 m4/geda-guile.m4           |    4 +++-
 2 files changed, 6 insertions(+), 1 deletions(-)


=================
 Commit Messages
=================

commit 361ed60e515c4bb4796b576004906955ef242a33
Author: Peter TB Brett <peter@xxxxxxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>

    build-sys: Correctly detect guile-1.8.pc.
    
    Commit 4342002fa639 exposed a pre-existing bug in the AX_CHECK_GUILE
    macro that caused configure to fail to detect the pkg-config file for
    Guile 1.8.x.

:100644 100644 48b1128... 61f62f7... M	m4/geda-guile.m4

commit 42182f0ae6b16171329f00f32ff1857d38c1c33e
Author: Peter TB Brett <peter@xxxxxxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>

    gschem: Workaround for zero-height text view bug.
    
    This is a temporary workaround for a bug on systems using overlay
    scrollbars for GTK+ widgets, where the value editing GtkTextView in
    the multi-attribute editing dialog was appearing with zero height.
    
    Obviously, setting the height request to a constant size isn't ideal.
    It would be better to set the height request based on the font size,
    so that a certain number of lines are displayed.
    
    This should be revisited at a later date.
    
    Affects-bug: lp-876299

:100644 100644 ee2a5f9... 7466acc... M	gschem/src/x_multiattrib.c

=========
 Changes
=========

commit 361ed60e515c4bb4796b576004906955ef242a33
Author: Peter TB Brett <peter@xxxxxxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>

    build-sys: Correctly detect guile-1.8.pc.
    
    Commit 4342002fa639 exposed a pre-existing bug in the AX_CHECK_GUILE
    macro that caused configure to fail to detect the pkg-config file for
    Guile 1.8.x.

diff --git a/m4/geda-guile.m4 b/m4/geda-guile.m4
index 48b1128..61f62f7 100644
--- a/m4/geda-guile.m4
+++ b/m4/geda-guile.m4
@@ -40,7 +40,9 @@ AC_DEFUN([AX_CHECK_GUILE],
 
   if test "${_found_pkg_config_guile}" = "no" ; then
    PKG_CHECK_MODULES(GUILE, [guile-1.8 >= $GUILE_MIN_VER],
-                     [GUILE_PKG=guile-1.8], [_found_pkg_config_guile=no])
+                            [_found_pkg_config_guile=yes
+                             GUILE_PKG=guile-1.8],
+                            [_found_pkg_config_guile=no])
   fi
 
   if test "${_found_pkg_config_guile}" = "no" ; then

commit 42182f0ae6b16171329f00f32ff1857d38c1c33e
Author: Peter TB Brett <peter@xxxxxxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>

    gschem: Workaround for zero-height text view bug.
    
    This is a temporary workaround for a bug on systems using overlay
    scrollbars for GTK+ widgets, where the value editing GtkTextView in
    the multi-attribute editing dialog was appearing with zero height.
    
    Obviously, setting the height request to a constant size isn't ideal.
    It would be better to set the height request based on the font size,
    so that a certain number of lines are displayed.
    
    This should be revisited at a later date.
    
    Affects-bug: lp-876299

diff --git a/gschem/src/x_multiattrib.c b/gschem/src/x_multiattrib.c
index ee2a5f9..7466acc 100644
--- a/gschem/src/x_multiattrib.c
+++ b/gschem/src/x_multiattrib.c
@@ -2001,7 +2001,10 @@ static void multiattrib_init(Multiattrib *multiattrib)
 					   "shadow-type",
 					   GTK_SHADOW_IN,
 					   NULL));
+  /*! \fixme Forcing the size request is a horrible band-aid and
+   *  should be replaced by a better heuristic. */
   textview = GTK_WIDGET (g_object_new (GTK_TYPE_TEXT_VIEW,
+                                       "height-request", 50,
 				       NULL));
   g_signal_connect (textview,
 		    "key_press_event",




_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs