gEDA-cvs: pcb.git: branch: master updated (3090f8155021b0191d408bfacaeaf62abf19bd98)

[git@xxxxxxxxxx]

The branch, master has been updated
       via  3090f8155021b0191d408bfacaeaf62abf19bd98 (commit)
      from  0f9a4b4d102619bf871f9fb79e3221cf2f220808 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


=========
 Summary
=========

 src/hid/gtk/gui-netlist-window.c |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)


=================
 Commit Messages
=================

commit 3090f8155021b0191d408bfacaeaf62abf19bd98
Author: Peter Clifton <peter@xxxxxxxxxxxxxxxxxxxxxxxxx>
Commit: Peter Clifton <peter@xxxxxxxxxxxxxxxxxxxxxxxxx>

    hid/gtk: Avoid warnings when netlist window is not created.
    
    1. When the NetlistChanged action is fired, we should only update if the
       netlist window is visible. (It will be created up to date when the
       user asks for it).
    
    2. Always show the netlist window when requested, even if it has no
       entries. This is good for consistent UI behaviour anyway, as the user
       should be shown a blank netlist window if they request it.. even if
       the is no content to display.

:100644 100644 249066f... e2c08d5... M	src/hid/gtk/gui-netlist-window.c

=========
 Changes
=========

commit 3090f8155021b0191d408bfacaeaf62abf19bd98
Author: Peter Clifton <peter@xxxxxxxxxxxxxxxxxxxxxxxxx>
Commit: Peter Clifton <peter@xxxxxxxxxxxxxxxxxxxxxxxxx>

    hid/gtk: Avoid warnings when netlist window is not created.
    
    1. When the NetlistChanged action is fired, we should only update if the
       netlist window is visible. (It will be created up to date when the
       user asks for it).
    
    2. Always show the netlist window when requested, even if it has no
       entries. This is good for consistent UI behaviour anyway, as the user
       should be shown a blank netlist window if they request it.. even if
       the is no content to display.

diff --git a/src/hid/gtk/gui-netlist-window.c b/src/hid/gtk/gui-netlist-window.c
index 249066f..e2c08d5 100644
--- a/src/hid/gtk/gui-netlist-window.c
+++ b/src/hid/gtk/gui-netlist-window.c
@@ -699,11 +699,6 @@ ghid_netlist_window_create (GHidPort * out)
   GtkCellRenderer *renderer;
   GtkTreeViewColumn *column;
 
-  /* No point in putting up the window if no netlist is loaded.
-   */
-  if (!PCB->NetlistLib.MenuN)
-    return;
-
   if (netlist_window)
     return;
 
@@ -1014,6 +1009,10 @@ GhidNetlistChanged (int argc, char **argv, Coord x, Coord y)
   if (ghidgui == NULL || !ghidgui->is_up)
     return 0;
 
+  /* There is no need to update if the netlist window isn't open */
+  if (netlist_window == NULL)
+    return 0;
+
   loading_new_netlist = TRUE;
   ghid_netlist_window_update (TRUE);
   gtk_toggle_button_set_active (GTK_TOGGLE_BUTTON (disable_all_button),




_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs