[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

gEDA-cvs: gaf.git: branch: master updated (1.6.1-20100214-86-g54ef993)



The branch, master has been updated
       via  54ef9936ca0f046ea37d4aa3b2d9b5ca524bbbc8 (commit)
      from  7a2311b5e144601594c5b99b2ceb8a8e8567ac5e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


=========
 Summary
=========

 gschem/src/o_slot.c |   10 ++--------
 1 files changed, 2 insertions(+), 8 deletions(-)


=================
 Commit Messages
=================

commit 54ef9936ca0f046ea37d4aa3b2d9b5ca524bbbc8
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    gschem: Don't second-guess whether to call o_invalidate on text objects
    
    The o_invalidate() call is a NOP if the text is invisible (or hidden
    text is not shown), so there is no need to check before calling.

:100644 100644 6c0f712... 91d9dcc... M	gschem/src/o_slot.c

=========
 Changes
=========

commit 54ef9936ca0f046ea37d4aa3b2d9b5ca524bbbc8
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    gschem: Don't second-guess whether to call o_invalidate on text objects
    
    The o_invalidate() call is a NOP if the text is invisible (or hidden
    text is not shown), so there is no need to check before calling.

diff --git a/gschem/src/o_slot.c b/gschem/src/o_slot.c
index 6c0f712..91d9dcc 100644
--- a/gschem/src/o_slot.c
+++ b/gschem/src/o_slot.c
@@ -115,19 +115,13 @@ void o_slot_end(GSCHEM_TOPLEVEL *w_current, OBJECT *object, const char *string)
   if (o_slot != NULL && !o_attrib_is_inherited (o_slot)) {
     o_text_set_string (toplevel, o_slot, string);
 
-    if (o_slot->visibility == VISIBLE ||
-        (o_slot->visibility == INVISIBLE && toplevel->show_hidden_text)) {
-      o_invalidate (w_current, o_slot);
-    }
+    o_invalidate (w_current, o_slot);
 
     o_text_recreate (toplevel, o_slot);
 
     /* this doesn't deal with the selection list
      * item */
-    if (o_slot->visibility == VISIBLE ||
-        (o_slot->visibility == INVISIBLE && toplevel->show_hidden_text)) {
-      o_invalidate (w_current, o_slot);
-    }
+    o_invalidate (w_current, o_slot);
 
   } else {
     /* here you need to do the add the slot




_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs