[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
gEDA-cvs: gaf.git: branch: master updated (1.6.1-20100214-240-gde3e47e)
The branch, master has been updated
via de3e47e27d27cd745afafce54541fc12ef71244e (commit)
via 536a3a5148d0b13cc2a45c21af299e2f16611b92 (commit)
via 5dfbb76b54a70f2f3c0fc90752326ec3855bb9a7 (commit)
via b8d3805b22aab292f0b07ab45c4ab019545c8fbc (commit)
from 8ea29eed4fdc4b756e0437bb086b27d61b1eb7a0 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
=========
Summary
=========
gnetlist/scheme/gnet-drc2.scm | 34 ++++++++++++++
gnetlist/tests/common/outputs/drc2/JD-output.net | 2 +
.../common/outputs/drc2/JD_Include-output.net | 2 +
.../outputs/drc2/JD_Include_nomunge-output.net | 2 +
.../tests/common/outputs/drc2/JD_Sort-output.net | 2 +
.../common/outputs/drc2/JD_Sort_nomunge-output.net | 2 +
.../common/outputs/drc2/JD_nomunge-output.net | 2 +
.../common/outputs/drc2/SlottedOpamps-output.net | 2 +
.../common/outputs/drc2/TwoStageAmp-output.net | 2 +
.../outputs/drc2/TwoStageAmp_Include-output.net | 2 +
.../outputs/drc2/TwoStageAmp_Sort-output.net | 2 +
.../tests/common/outputs/drc2/cascade-output.net | 2 +
.../common/outputs/drc2/multiequal-output.net | 2 +
.../tests/common/outputs/drc2/netattrib-output.net | 2 +
.../common/outputs/drc2/powersupply-output.net | 2 +
.../tests/common/outputs/drc2/singlenet-output.net | 2 +
.../common/outputs/drc2/stack-torture-output.net | 2 +
gnetlist/tests/common/run_tests.sh | 4 +-
gnetlist/tests/drc2/Makefile.am | 2 +
...t-an-integer.drc2 => connected-noconnects.drc2} | 4 +-
gnetlist/tests/drc2/connected-noconnects.sch | 47 ++++++++++++++++++++
gnetlist/tests/drc2/duplicated-refdes.drc2 | 2 +
gnetlist/tests/drc2/duplicated_slot.drc2 | 2 +
gnetlist/tests/drc2/gnd-with-nc-directive.drc2 | 2 +
gnetlist/tests/drc2/gnd-without-nc-directive.drc2 | 2 +
...driven-with-dont-check-if-driven-directive.drc2 | 2 +
.../drc2/net-not-driven-with-nc-directive.drc2 | 5 ++-
.../drc2/net-not-driven-with-nc-directive.sch | 6 ++-
gnetlist/tests/drc2/net-not-driven.drc2 | 2 +
.../tests/drc2/net-with-only-one-connection.drc2 | 2 +
.../tests/drc2/numslots-is-not-an-integer.drc2 | 2 +
gnetlist/tests/drc2/numslots-not-defined.drc2 | 2 +
.../tests/drc2/output-connected-to-output.drc2 | 2 +
.../tests/drc2/pin-without-pintype-attrib.drc2 | 2 +
gnetlist/tests/drc2/refdes-not-numbered.drc2 | 2 +
gnetlist/tests/drc2/slot-is-not-an-integer.drc2 | 2 +
gnetlist/tests/drc2/slot-not-defined.drc2 | 2 +
gnetlist/tests/drc2/slot_out_of_range.drc2 | 2 +
.../drc2/unconnected-pin-with-drc-directive.drc2 | 2 +
gnetlist/tests/drc2/unconnected-pin.drc2 | 2 +
gnetlist/tests/drc2/unused-slot.drc2 | 2 +
41 files changed, 165 insertions(+), 5 deletions(-)
copy gnetlist/tests/drc2/{numslots-is-not-an-integer.drc2 => connected-noconnects.drc2} (71%)
create mode 100644 gnetlist/tests/drc2/connected-noconnects.sch
=================
Commit Messages
=================
commit de3e47e27d27cd745afafce54541fc12ef71244e
Author: Alan Somers <asomers@xxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>
gnetlist: Fix spelling errors in run_tests.sh
Reviewed-by: Peter TB Brett <peter@xxxxxxxxxxxxx>
Closes-bug: lp-700795
:100755 100755 495868b... 35c3a27... M gnetlist/tests/common/run_tests.sh
commit 536a3a5148d0b13cc2a45c21af299e2f16611b92
Author: Alan Somers (none) <somers@tryptophan>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>
gnetlist: Fixed tests for new connected-noconnects DRC2 option.
Reviewed-by: Peter TB Brett <peter@xxxxxxxxxxxxx>
Closes-bug: lp-698743
:100644 100644 110219f... 0f2c1cf... M gnetlist/tests/common/outputs/drc2/JD-output.net
:100644 100644 110219f... 0f2c1cf... M gnetlist/tests/common/outputs/drc2/JD_Include-output.net
:100644 100644 110219f... 0f2c1cf... M gnetlist/tests/common/outputs/drc2/JD_Include_nomunge-output.net
:100644 100644 110219f... 0f2c1cf... M gnetlist/tests/common/outputs/drc2/JD_Sort-output.net
:100644 100644 110219f... 0f2c1cf... M gnetlist/tests/common/outputs/drc2/JD_Sort_nomunge-output.net
:100644 100644 110219f... 0f2c1cf... M gnetlist/tests/common/outputs/drc2/JD_nomunge-output.net
:100644 100644 207d06e... 6d6993f... M gnetlist/tests/common/outputs/drc2/SlottedOpamps-output.net
:100644 100644 842374f... a40cc5e... M gnetlist/tests/common/outputs/drc2/TwoStageAmp-output.net
:100644 100644 842374f... a40cc5e... M gnetlist/tests/common/outputs/drc2/TwoStageAmp_Include-output.net
:100644 100644 842374f... a40cc5e... M gnetlist/tests/common/outputs/drc2/TwoStageAmp_Sort-output.net
:100644 100644 25cbe0f... a009d65... M gnetlist/tests/common/outputs/drc2/cascade-output.net
:100644 100644 110219f... 0f2c1cf... M gnetlist/tests/common/outputs/drc2/multiequal-output.net
:100644 100644 37d0882... 8b2f0f0... M gnetlist/tests/common/outputs/drc2/netattrib-output.net
:100644 100644 19c9a5c... de24f72... M gnetlist/tests/common/outputs/drc2/powersupply-output.net
:100644 100644 ba21abd... 85ff068... M gnetlist/tests/common/outputs/drc2/singlenet-output.net
:100644 100644 d699719... ccdf43f... M gnetlist/tests/common/outputs/drc2/stack-torture-output.net
:100644 100644 ccce2af... a040c11... M gnetlist/tests/drc2/duplicated-refdes.drc2
:100644 100644 9315cfd... b8255ff... M gnetlist/tests/drc2/duplicated_slot.drc2
:100644 100644 110219f... 0f2c1cf... M gnetlist/tests/drc2/gnd-with-nc-directive.drc2
:100644 100644 30a488b... ec21057... M gnetlist/tests/drc2/gnd-without-nc-directive.drc2
:100644 100644 110219f... 0f2c1cf... M gnetlist/tests/drc2/net-not-driven-with-dont-check-if-driven-directive.drc2
:100644 100644 110219f... 7854ffd... M gnetlist/tests/drc2/net-not-driven-with-nc-directive.drc2
:100644 100644 27ab1c2... 42b471e... M gnetlist/tests/drc2/net-not-driven-with-nc-directive.sch
:100644 100644 7342678... 444c816... M gnetlist/tests/drc2/net-not-driven.drc2
:100644 100644 30a488b... ec21057... M gnetlist/tests/drc2/net-with-only-one-connection.drc2
:100644 100644 be3e0b3... 2b1bb01... M gnetlist/tests/drc2/numslots-is-not-an-integer.drc2
:100644 100644 52faf18... 44ca0fe... M gnetlist/tests/drc2/numslots-not-defined.drc2
:100644 100644 ea35b41... 5c4f577... M gnetlist/tests/drc2/output-connected-to-output.drc2
:100644 100644 d25740b... f37b0c9... M gnetlist/tests/drc2/pin-without-pintype-attrib.drc2
:100644 100644 47488bc... 194e971... M gnetlist/tests/drc2/refdes-not-numbered.drc2
:100644 100644 57bdecf... 1ecd819... M gnetlist/tests/drc2/slot-is-not-an-integer.drc2
:100644 100644 0a2f04b... ad2846b... M gnetlist/tests/drc2/slot-not-defined.drc2
:100644 100644 688a424... 89521ec... M gnetlist/tests/drc2/slot_out_of_range.drc2
:100644 100644 110219f... 0f2c1cf... M gnetlist/tests/drc2/unconnected-pin-with-drc-directive.drc2
:100644 100644 f089b83... 564683c... M gnetlist/tests/drc2/unconnected-pin.drc2
:100644 100644 6734ac1... 1c7bed8... M gnetlist/tests/drc2/unused-slot.drc2
commit 5dfbb76b54a70f2f3c0fc90752326ec3855bb9a7
Author: Alan Somers (none) <somers@tryptophan>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>
gnetlist: Added testcase for connected noconnects in drc2
Reviewed-by: Peter TB Brett <peter@xxxxxxxxxxxxx>
Affects-bug: lp-698743
:100644 100644 14ccb5d... a7438ae... M gnetlist/tests/drc2/Makefile.am
:000000 100644 0000000... 790ff18... A gnetlist/tests/drc2/connected-noconnects.drc2
:000000 100644 0000000... c11a3cd... A gnetlist/tests/drc2/connected-noconnects.sch
commit b8d3805b22aab292f0b07ab45c4ab019545c8fbc
Author: Alan Somers <asomers@xxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>
gnetlist: NoConnection nets with more than 1 pin are an error in drc2 backend.
Adding the NoConnection DRC attribute to a net causes the drc2 backend
to ignore it when checking for unconnected nets. However, drc2
currently doesn't enforce that the net is actually unconnected. It's
possible to mark two pins as NoConnection and then accidentally wire
them together. This patch to gnet-drc2.scm checks for that case.
Reviewed-by: Peter TB Brett <peter@xxxxxxxxxxxxx>
Affects-bug: lp-698743
:100644 100644 dba6eab... 380f588... M gnetlist/scheme/gnet-drc2.scm
=========
Changes
=========
commit de3e47e27d27cd745afafce54541fc12ef71244e
Author: Alan Somers <asomers@xxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>
gnetlist: Fix spelling errors in run_tests.sh
Reviewed-by: Peter TB Brett <peter@xxxxxxxxxxxxx>
Closes-bug: lp-700795
diff --git a/gnetlist/tests/common/run_tests.sh b/gnetlist/tests/common/run_tests.sh
index 495868b..35c3a27 100755
--- a/gnetlist/tests/common/run_tests.sh
+++ b/gnetlist/tests/common/run_tests.sh
@@ -24,7 +24,7 @@ Options
Description
$0 reads a file, backends.list, describing backends to run tests on.
-For each backend, run_backend_test.sh is run with that backend name
+For each backend, run_backend_tests.sh is run with that backend name
as a parameter.
Examples
@@ -100,7 +100,7 @@ for backend in $all_tests ; do
fi
if test $rc -ne 0 ; then
- echo "FAILED: run_backend_test.sh returned $rc failures"
+ echo "FAILED: run_backend_tests.sh returned $rc failures"
fail=`expr $fail + 1`
continue
fi
commit 536a3a5148d0b13cc2a45c21af299e2f16611b92
Author: Alan Somers (none) <somers@tryptophan>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>
gnetlist: Fixed tests for new connected-noconnects DRC2 option.
Reviewed-by: Peter TB Brett <peter@xxxxxxxxxxxxx>
Closes-bug: lp-698743
diff --git a/gnetlist/tests/common/outputs/drc2/JD-output.net b/gnetlist/tests/common/outputs/drc2/JD-output.net
index 110219f..0f2c1cf 100644
--- a/gnetlist/tests/common/outputs/drc2/JD-output.net
+++ b/gnetlist/tests/common/outputs/drc2/JD-output.net
@@ -2,6 +2,8 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
Checking pins without the 'pintype' attribute...
diff --git a/gnetlist/tests/common/outputs/drc2/JD_Include-output.net b/gnetlist/tests/common/outputs/drc2/JD_Include-output.net
index 110219f..0f2c1cf 100644
--- a/gnetlist/tests/common/outputs/drc2/JD_Include-output.net
+++ b/gnetlist/tests/common/outputs/drc2/JD_Include-output.net
@@ -2,6 +2,8 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
Checking pins without the 'pintype' attribute...
diff --git a/gnetlist/tests/common/outputs/drc2/JD_Include_nomunge-output.net b/gnetlist/tests/common/outputs/drc2/JD_Include_nomunge-output.net
index 110219f..0f2c1cf 100644
--- a/gnetlist/tests/common/outputs/drc2/JD_Include_nomunge-output.net
+++ b/gnetlist/tests/common/outputs/drc2/JD_Include_nomunge-output.net
@@ -2,6 +2,8 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
Checking pins without the 'pintype' attribute...
diff --git a/gnetlist/tests/common/outputs/drc2/JD_Sort-output.net b/gnetlist/tests/common/outputs/drc2/JD_Sort-output.net
index 110219f..0f2c1cf 100644
--- a/gnetlist/tests/common/outputs/drc2/JD_Sort-output.net
+++ b/gnetlist/tests/common/outputs/drc2/JD_Sort-output.net
@@ -2,6 +2,8 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
Checking pins without the 'pintype' attribute...
diff --git a/gnetlist/tests/common/outputs/drc2/JD_Sort_nomunge-output.net b/gnetlist/tests/common/outputs/drc2/JD_Sort_nomunge-output.net
index 110219f..0f2c1cf 100644
--- a/gnetlist/tests/common/outputs/drc2/JD_Sort_nomunge-output.net
+++ b/gnetlist/tests/common/outputs/drc2/JD_Sort_nomunge-output.net
@@ -2,6 +2,8 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
Checking pins without the 'pintype' attribute...
diff --git a/gnetlist/tests/common/outputs/drc2/JD_nomunge-output.net b/gnetlist/tests/common/outputs/drc2/JD_nomunge-output.net
index 110219f..0f2c1cf 100644
--- a/gnetlist/tests/common/outputs/drc2/JD_nomunge-output.net
+++ b/gnetlist/tests/common/outputs/drc2/JD_nomunge-output.net
@@ -2,6 +2,8 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
Checking pins without the 'pintype' attribute...
diff --git a/gnetlist/tests/common/outputs/drc2/SlottedOpamps-output.net b/gnetlist/tests/common/outputs/drc2/SlottedOpamps-output.net
index 207d06e..6d6993f 100644
--- a/gnetlist/tests/common/outputs/drc2/SlottedOpamps-output.net
+++ b/gnetlist/tests/common/outputs/drc2/SlottedOpamps-output.net
@@ -2,6 +2,8 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
ERROR: Net 'minusin_slot4_pin13_b' is connected to only one pin: U1:13 .
ERROR: Net 'plusin_slot4_pin12_a' is connected to only one pin: U1:12 .
diff --git a/gnetlist/tests/common/outputs/drc2/TwoStageAmp-output.net b/gnetlist/tests/common/outputs/drc2/TwoStageAmp-output.net
index 842374f..a40cc5e 100644
--- a/gnetlist/tests/common/outputs/drc2/TwoStageAmp-output.net
+++ b/gnetlist/tests/common/outputs/drc2/TwoStageAmp-output.net
@@ -2,6 +2,8 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
Checking pins without the 'pintype' attribute...
diff --git a/gnetlist/tests/common/outputs/drc2/TwoStageAmp_Include-output.net b/gnetlist/tests/common/outputs/drc2/TwoStageAmp_Include-output.net
index 842374f..a40cc5e 100644
--- a/gnetlist/tests/common/outputs/drc2/TwoStageAmp_Include-output.net
+++ b/gnetlist/tests/common/outputs/drc2/TwoStageAmp_Include-output.net
@@ -2,6 +2,8 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
Checking pins without the 'pintype' attribute...
diff --git a/gnetlist/tests/common/outputs/drc2/TwoStageAmp_Sort-output.net b/gnetlist/tests/common/outputs/drc2/TwoStageAmp_Sort-output.net
index 842374f..a40cc5e 100644
--- a/gnetlist/tests/common/outputs/drc2/TwoStageAmp_Sort-output.net
+++ b/gnetlist/tests/common/outputs/drc2/TwoStageAmp_Sort-output.net
@@ -2,6 +2,8 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
Checking pins without the 'pintype' attribute...
diff --git a/gnetlist/tests/common/outputs/drc2/cascade-output.net b/gnetlist/tests/common/outputs/drc2/cascade-output.net
index 25cbe0f..a009d65 100644
--- a/gnetlist/tests/common/outputs/drc2/cascade-output.net
+++ b/gnetlist/tests/common/outputs/drc2/cascade-output.net
@@ -2,6 +2,8 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
ERROR: Net 'GND' is connected to only one pin: DEFAULTS:1 .
diff --git a/gnetlist/tests/common/outputs/drc2/multiequal-output.net b/gnetlist/tests/common/outputs/drc2/multiequal-output.net
index 110219f..0f2c1cf 100644
--- a/gnetlist/tests/common/outputs/drc2/multiequal-output.net
+++ b/gnetlist/tests/common/outputs/drc2/multiequal-output.net
@@ -2,6 +2,8 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
Checking pins without the 'pintype' attribute...
diff --git a/gnetlist/tests/common/outputs/drc2/netattrib-output.net b/gnetlist/tests/common/outputs/drc2/netattrib-output.net
index 37d0882..8b2f0f0 100644
--- a/gnetlist/tests/common/outputs/drc2/netattrib-output.net
+++ b/gnetlist/tests/common/outputs/drc2/netattrib-output.net
@@ -2,6 +2,8 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
ERROR: Net 'unnamed_net1' is connected to only one pin: U300:2 .
diff --git a/gnetlist/tests/common/outputs/drc2/powersupply-output.net b/gnetlist/tests/common/outputs/drc2/powersupply-output.net
index 19c9a5c..de24f72 100644
--- a/gnetlist/tests/common/outputs/drc2/powersupply-output.net
+++ b/gnetlist/tests/common/outputs/drc2/powersupply-output.net
@@ -2,6 +2,8 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
ERROR: Net 'GND' is connected to only one pin: CONN1:3 .
diff --git a/gnetlist/tests/common/outputs/drc2/singlenet-output.net b/gnetlist/tests/common/outputs/drc2/singlenet-output.net
index ba21abd..85ff068 100644
--- a/gnetlist/tests/common/outputs/drc2/singlenet-output.net
+++ b/gnetlist/tests/common/outputs/drc2/singlenet-output.net
@@ -2,6 +2,8 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
ERROR: Net 'GND' is connected to only one pin: U100:7 .
ERROR: Net 'Vcc' is connected to only one pin: U100:14 .
diff --git a/gnetlist/tests/common/outputs/drc2/stack-torture-output.net b/gnetlist/tests/common/outputs/drc2/stack-torture-output.net
index d699719..ccdf43f 100644
--- a/gnetlist/tests/common/outputs/drc2/stack-torture-output.net
+++ b/gnetlist/tests/common/outputs/drc2/stack-torture-output.net
@@ -4,6 +4,8 @@ ERROR: Reference not numbered: C?
Checking duplicated references...
ERROR: Duplicated reference C?.
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
ERROR: Net 'unnamed_net1025' is connected to only one pin: C?:2 .
ERROR: Net 'unnamed_net1022' is connected to only one pin: C?:2 .
diff --git a/gnetlist/tests/drc2/duplicated-refdes.drc2 b/gnetlist/tests/drc2/duplicated-refdes.drc2
index ccce2af..a040c11 100644
--- a/gnetlist/tests/drc2/duplicated-refdes.drc2
+++ b/gnetlist/tests/drc2/duplicated-refdes.drc2
@@ -3,6 +3,8 @@ Checking non-numbered parts...
Checking duplicated references...
ERROR: Duplicated reference R1.
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
ERROR: Net 'GND' is connected to only one pin: R1:1 .
ERROR: Net 'unnamed_net1' is connected to only one pin: R1:2 .
diff --git a/gnetlist/tests/drc2/duplicated_slot.drc2 b/gnetlist/tests/drc2/duplicated_slot.drc2
index 9315cfd..b8255ff 100644
--- a/gnetlist/tests/drc2/duplicated_slot.drc2
+++ b/gnetlist/tests/drc2/duplicated_slot.drc2
@@ -3,6 +3,8 @@ Checking non-numbered parts...
Checking duplicated references...
ERROR: Duplicated reference U1.
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
Checking pins without the 'pintype' attribute...
diff --git a/gnetlist/tests/drc2/gnd-with-nc-directive.drc2 b/gnetlist/tests/drc2/gnd-with-nc-directive.drc2
index 110219f..0f2c1cf 100644
--- a/gnetlist/tests/drc2/gnd-with-nc-directive.drc2
+++ b/gnetlist/tests/drc2/gnd-with-nc-directive.drc2
@@ -2,6 +2,8 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
Checking pins without the 'pintype' attribute...
diff --git a/gnetlist/tests/drc2/gnd-without-nc-directive.drc2 b/gnetlist/tests/drc2/gnd-without-nc-directive.drc2
index 30a488b..ec21057 100644
--- a/gnetlist/tests/drc2/gnd-without-nc-directive.drc2
+++ b/gnetlist/tests/drc2/gnd-without-nc-directive.drc2
@@ -2,6 +2,8 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
ERROR: Net 'GND' is connected to only one pin: R2:1 .
diff --git a/gnetlist/tests/drc2/net-not-driven-with-dont-check-if-driven-directive.drc2 b/gnetlist/tests/drc2/net-not-driven-with-dont-check-if-driven-directive.drc2
index 110219f..0f2c1cf 100644
--- a/gnetlist/tests/drc2/net-not-driven-with-dont-check-if-driven-directive.drc2
+++ b/gnetlist/tests/drc2/net-not-driven-with-dont-check-if-driven-directive.drc2
@@ -2,6 +2,8 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
Checking pins without the 'pintype' attribute...
diff --git a/gnetlist/tests/drc2/net-not-driven-with-nc-directive.drc2 b/gnetlist/tests/drc2/net-not-driven-with-nc-directive.drc2
index 110219f..7854ffd 100644
--- a/gnetlist/tests/drc2/net-not-driven-with-nc-directive.drc2
+++ b/gnetlist/tests/drc2/net-not-driven-with-nc-directive.drc2
@@ -2,6 +2,9 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+ERROR: Net 'undriven_net' has connections, but has the NoConnection DRC directive: U1:13 U1:10 .
+
Checking nets with only one connection...
Checking pins without the 'pintype' attribute...
@@ -17,4 +20,4 @@ Checking duplicated slots...
Checking unused slots...
No warnings found.
-No errors found.
+Found 1 errors.
diff --git a/gnetlist/tests/drc2/net-not-driven-with-nc-directive.sch b/gnetlist/tests/drc2/net-not-driven-with-nc-directive.sch
index 27ab1c2..42b471e 100644
--- a/gnetlist/tests/drc2/net-not-driven-with-nc-directive.sch
+++ b/gnetlist/tests/drc2/net-not-driven-with-nc-directive.sch
@@ -1,4 +1,4 @@
-v 20061020 1
+v 20100214 2
C 40000 40000 0 0 0 title-B.sym
C 46200 46600 1 0 0 7400-1.sym
{
@@ -84,3 +84,7 @@ T 48200 46600 5 10 0 0 0 0 1
device=DRC_Directive
}
N 48700 45900 50600 45900 4
+{
+T 49300 45900 5 10 1 1 0 0 1
+netname=undriven_net
+}
diff --git a/gnetlist/tests/drc2/net-not-driven.drc2 b/gnetlist/tests/drc2/net-not-driven.drc2
index 7342678..444c816 100644
--- a/gnetlist/tests/drc2/net-not-driven.drc2
+++ b/gnetlist/tests/drc2/net-not-driven.drc2
@@ -2,6 +2,8 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
Checking pins without the 'pintype' attribute...
diff --git a/gnetlist/tests/drc2/net-with-only-one-connection.drc2 b/gnetlist/tests/drc2/net-with-only-one-connection.drc2
index 30a488b..ec21057 100644
--- a/gnetlist/tests/drc2/net-with-only-one-connection.drc2
+++ b/gnetlist/tests/drc2/net-with-only-one-connection.drc2
@@ -2,6 +2,8 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
ERROR: Net 'GND' is connected to only one pin: R2:1 .
diff --git a/gnetlist/tests/drc2/numslots-is-not-an-integer.drc2 b/gnetlist/tests/drc2/numslots-is-not-an-integer.drc2
index be3e0b3..2b1bb01 100644
--- a/gnetlist/tests/drc2/numslots-is-not-an-integer.drc2
+++ b/gnetlist/tests/drc2/numslots-is-not-an-integer.drc2
@@ -2,6 +2,8 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
Checking pins without the 'pintype' attribute...
diff --git a/gnetlist/tests/drc2/numslots-not-defined.drc2 b/gnetlist/tests/drc2/numslots-not-defined.drc2
index 52faf18..44ca0fe 100644
--- a/gnetlist/tests/drc2/numslots-not-defined.drc2
+++ b/gnetlist/tests/drc2/numslots-not-defined.drc2
@@ -2,6 +2,8 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
Checking pins without the 'pintype' attribute...
diff --git a/gnetlist/tests/drc2/output-connected-to-output.drc2 b/gnetlist/tests/drc2/output-connected-to-output.drc2
index ea35b41..5c4f577 100644
--- a/gnetlist/tests/drc2/output-connected-to-output.drc2
+++ b/gnetlist/tests/drc2/output-connected-to-output.drc2
@@ -2,6 +2,8 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
Checking pins without the 'pintype' attribute...
diff --git a/gnetlist/tests/drc2/pin-without-pintype-attrib.drc2 b/gnetlist/tests/drc2/pin-without-pintype-attrib.drc2
index d25740b..f37b0c9 100644
--- a/gnetlist/tests/drc2/pin-without-pintype-attrib.drc2
+++ b/gnetlist/tests/drc2/pin-without-pintype-attrib.drc2
@@ -2,6 +2,8 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
Checking pins without the 'pintype' attribute...
diff --git a/gnetlist/tests/drc2/refdes-not-numbered.drc2 b/gnetlist/tests/drc2/refdes-not-numbered.drc2
index 47488bc..194e971 100644
--- a/gnetlist/tests/drc2/refdes-not-numbered.drc2
+++ b/gnetlist/tests/drc2/refdes-not-numbered.drc2
@@ -3,6 +3,8 @@ ERROR: Reference not numbered: R?
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
Checking pins without the 'pintype' attribute...
diff --git a/gnetlist/tests/drc2/slot-is-not-an-integer.drc2 b/gnetlist/tests/drc2/slot-is-not-an-integer.drc2
index 57bdecf..1ecd819 100644
--- a/gnetlist/tests/drc2/slot-is-not-an-integer.drc2
+++ b/gnetlist/tests/drc2/slot-is-not-an-integer.drc2
@@ -3,6 +3,8 @@ Checking non-numbered parts...
Checking duplicated references...
ERROR: Duplicated reference R1.
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
Checking pins without the 'pintype' attribute...
diff --git a/gnetlist/tests/drc2/slot-not-defined.drc2 b/gnetlist/tests/drc2/slot-not-defined.drc2
index 0a2f04b..ad2846b 100644
--- a/gnetlist/tests/drc2/slot-not-defined.drc2
+++ b/gnetlist/tests/drc2/slot-not-defined.drc2
@@ -3,6 +3,8 @@ Checking non-numbered parts...
Checking duplicated references...
ERROR: Duplicated reference R1.
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
Checking pins without the 'pintype' attribute...
diff --git a/gnetlist/tests/drc2/slot_out_of_range.drc2 b/gnetlist/tests/drc2/slot_out_of_range.drc2
index 688a424..89521ec 100644
--- a/gnetlist/tests/drc2/slot_out_of_range.drc2
+++ b/gnetlist/tests/drc2/slot_out_of_range.drc2
@@ -2,6 +2,8 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
Checking pins without the 'pintype' attribute...
diff --git a/gnetlist/tests/drc2/unconnected-pin-with-drc-directive.drc2 b/gnetlist/tests/drc2/unconnected-pin-with-drc-directive.drc2
index 110219f..0f2c1cf 100644
--- a/gnetlist/tests/drc2/unconnected-pin-with-drc-directive.drc2
+++ b/gnetlist/tests/drc2/unconnected-pin-with-drc-directive.drc2
@@ -2,6 +2,8 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
Checking pins without the 'pintype' attribute...
diff --git a/gnetlist/tests/drc2/unconnected-pin.drc2 b/gnetlist/tests/drc2/unconnected-pin.drc2
index f089b83..564683c 100644
--- a/gnetlist/tests/drc2/unconnected-pin.drc2
+++ b/gnetlist/tests/drc2/unconnected-pin.drc2
@@ -2,6 +2,8 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
Checking pins without the 'pintype' attribute...
diff --git a/gnetlist/tests/drc2/unused-slot.drc2 b/gnetlist/tests/drc2/unused-slot.drc2
index 6734ac1..1c7bed8 100644
--- a/gnetlist/tests/drc2/unused-slot.drc2
+++ b/gnetlist/tests/drc2/unused-slot.drc2
@@ -2,6 +2,8 @@ Checking non-numbered parts...
Checking duplicated references...
+Checking NoConnection nets for connections...
+
Checking nets with only one connection...
Checking pins without the 'pintype' attribute...
commit 5dfbb76b54a70f2f3c0fc90752326ec3855bb9a7
Author: Alan Somers (none) <somers@tryptophan>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>
gnetlist: Added testcase for connected noconnects in drc2
Reviewed-by: Peter TB Brett <peter@xxxxxxxxxxxxx>
Affects-bug: lp-698743
diff --git a/gnetlist/tests/drc2/Makefile.am b/gnetlist/tests/drc2/Makefile.am
index 14ccb5d..a7438ae 100644
--- a/gnetlist/tests/drc2/Makefile.am
+++ b/gnetlist/tests/drc2/Makefile.am
@@ -28,6 +28,8 @@ EXTRA_DIST = duplicated-refdes.sch duplicated-refdes.drc2 \
slot-not-defined.drc2 \
slot_out_of_range.sch \
slot_out_of_range.drc2 \
+ connected-noconnects.sch \
+ connected-noconnects.drc2 \
unconnected-pin.sch \
unconnected-pin.drc2 \
unconnected-pin-with-drc-directive.sch \
diff --git a/gnetlist/tests/drc2/connected-noconnects.drc2 b/gnetlist/tests/drc2/connected-noconnects.drc2
new file mode 100644
index 0000000..790ff18
--- /dev/null
+++ b/gnetlist/tests/drc2/connected-noconnects.drc2
@@ -0,0 +1,23 @@
+Checking non-numbered parts...
+
+Checking duplicated references...
+
+Checking NoConnection nets for connections...
+ERROR: Net 'bad_net' has connections, but has the NoConnection DRC directive: R2:2 R1:2 .
+
+Checking nets with only one connection...
+
+Checking pins without the 'pintype' attribute...
+
+Checking type of pins connected to a net...
+
+Checking unconnected pins...
+
+Checking slots...
+
+Checking duplicated slots...
+
+Checking unused slots...
+
+No warnings found.
+Found 1 errors.
diff --git a/gnetlist/tests/drc2/connected-noconnects.sch b/gnetlist/tests/drc2/connected-noconnects.sch
new file mode 100644
index 0000000..c11a3cd
--- /dev/null
+++ b/gnetlist/tests/drc2/connected-noconnects.sch
@@ -0,0 +1,47 @@
+v 20100214 2
+C 40000 40000 0 0 0 title-B.sym
+C 48500 45300 1 90 0 resistor-2.sym
+{
+T 48150 45700 5 10 0 0 90 0 1
+device=RESISTOR
+T 48200 45500 5 10 1 1 90 0 1
+refdes=R1
+}
+C 49200 45300 1 90 0 resistor-2.sym
+{
+T 48850 45700 5 10 0 0 90 0 1
+device=RESISTOR
+T 48900 45500 5 10 1 1 90 0 1
+refdes=R2
+}
+C 48300 45000 1 0 0 gnd-1.sym
+C 49000 45000 1 0 0 gnd-1.sym
+N 48400 46200 48400 46400 4
+N 48400 46400 49100 46400 4
+{
+T 48400 46400 5 10 1 1 0 0 1
+netname=bad_net
+}
+N 49100 46400 49100 46200 4
+C 49800 45300 1 90 0 resistor-2.sym
+{
+T 49450 45700 5 10 0 0 90 0 1
+device=RESISTOR
+T 49500 45500 5 10 1 1 90 0 1
+refdes=R3
+}
+C 49600 45000 1 0 0 gnd-1.sym
+C 48200 46400 1 0 0 nc-top-1.sym
+{
+T 48600 46900 5 10 0 0 0 0 1
+value=NoConnection
+T 48600 47100 5 10 0 0 0 0 1
+device=DRC_Directive
+}
+C 49500 46200 1 0 0 nc-top-1.sym
+{
+T 49900 46700 5 10 0 0 0 0 1
+value=NoConnection
+T 49900 46900 5 10 0 0 0 0 1
+device=DRC_Directive
+}
commit b8d3805b22aab292f0b07ab45c4ab019545c8fbc
Author: Alan Somers <asomers@xxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>
gnetlist: NoConnection nets with more than 1 pin are an error in drc2 backend.
Adding the NoConnection DRC attribute to a net causes the drc2 backend
to ignore it when checking for unconnected nets. However, drc2
currently doesn't enforce that the net is actually unconnected. It's
possible to mark two pins as NoConnection and then accidentally wire
them together. This patch to gnet-drc2.scm checks for that case.
Reviewed-by: Peter TB Brett <peter@xxxxxxxxxxxxx>
Affects-bug: lp-698743
diff --git a/gnetlist/scheme/gnet-drc2.scm b/gnetlist/scheme/gnet-drc2.scm
index dba6eab..380f588 100644
--- a/gnetlist/scheme/gnet-drc2.scm
+++ b/gnetlist/scheme/gnet-drc2.scm
@@ -537,6 +537,32 @@
;
;;
+;; Check for NoConnection nets with more than one pin connected.
+;;
+;; Example of all-nets: (net1 net2 net3 net4)
+(define (drc2:check-connected-noconnects port all-nets)
+ (for-each
+ (lambda (netname)
+ (let
+ ((directives (gnetlist:graphical-objs-in-net-with-attrib-get-attrib
+ netname
+ "device=DRC_Directive"
+ "value")))
+ ;Only check nets with a NoConnection directive
+ (and
+ (member "NoConnection" directives)
+ ( > (length (gnetlist:get-all-connections netname)) '1)
+ (begin
+ (display (string-append "ERROR: Net '"
+ netname "' has connections, but "
+ "has the NoConnection DRC directive: ") port)
+ (drc2:display-pins-of-type port "all" (gnetlist:get-all-connections netname))
+ (display "." port)
+ (newline port)
+ (set! errors_number (1+ errors_number))))))
+ all-nets))
+
+;;
;; Check for nets with less than two pins connected.
;;
;; Example of all-nets: (net1 net2 net3 net4)
@@ -916,6 +942,14 @@
(drc2:check-duplicated-references port packages)
(newline port)))
+ ;; Check for NoConnection nets with more than one pin connected.
+ (if (not (defined? 'dont-check-connected-noconnects))
+ (begin
+ (display "Checking NoConnection nets for connections..." port)
+ (newline port)
+ (drc2:check-connected-noconnects port (gnetlist:get-all-unique-nets "dummy"))
+ (newline port)))
+
;; Check nets with only one connection
(if (not (defined? 'dont-check-one-connection-nets))
(begin
_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs