gEDA-cvs: gaf.git: branch: master updated (1.6.1-20100214-281-g0f664b4)

[git@xxxxxxxxxx]

The branch, master has been updated
       via  0f664b4c54ca3c38f31e169c642268091ae392f7 (commit)
      from  502ab80495c45e092eca6052edd6cf8e7ff55429 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


=========
 Summary
=========

 libgeda/src/o_complex_basic.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)


=================
 Commit Messages
=================

commit 0f664b4c54ca3c38f31e169c642268091ae392f7
Author: Peter TB Brett <peter@xxxxxxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>

    libgeda: Fix potential buffer overflow.
    
    Closes-bug: lp-702209

:100644 100644 72c2d2e... 9ef0e2e... M	libgeda/src/o_complex_basic.c

=========
 Changes
=========

commit 0f664b4c54ca3c38f31e169c642268091ae392f7
Author: Peter TB Brett <peter@xxxxxxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>

    libgeda: Fix potential buffer overflow.
    
    Closes-bug: lp-702209

diff --git a/libgeda/src/o_complex_basic.c b/libgeda/src/o_complex_basic.c
index 72c2d2e..9ef0e2e 100644
--- a/libgeda/src/o_complex_basic.c
+++ b/libgeda/src/o_complex_basic.c
@@ -656,8 +656,6 @@ void o_complex_recalc(TOPLEVEL *toplevel, OBJECT *o_current)
  *  \param [in] release_ver  The release number gEDA
  *  \param [in] fileformat_ver a integer value of the file format
  *  \return The object list
- *
- *  \todo Don't use fixed-length string for symbol basename
  */
 OBJECT *o_complex_read (TOPLEVEL *toplevel,
                         char buf[], unsigned int release_ver,
@@ -668,8 +666,8 @@ OBJECT *o_complex_read (TOPLEVEL *toplevel,
   int x1, y1;
   int angle;
 
-  char basename[256]; /* FIXME This is a hack */
-	
+  char *basename = g_malloc (1 + strlen (buf));
+
   int selectable;
   int mirror;
 
@@ -719,6 +717,8 @@ OBJECT *o_complex_read (TOPLEVEL *toplevel,
      o_complex_remove_promotable_attribs (toplevel, new_obj);
   }
 
+  g_free (basename);
+
   return new_obj;
 }
 




_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs