gEDA-cvs: CVS update: o_attrib.c

[cvspsrv@xxxxxxxx]

  User: ahvezda 
  Date: 06/07/15 19:37:01

  Modified:    .        o_attrib.c
  Log:
  Added todo to an invalid if statement (causes invalid read in certain cases)
  
  
  
  
  Revision  Changes    Path
  1.38      +4 -0      eda/geda/gaf/libgeda/src/o_attrib.c
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: o_attrib.c
  ===================================================================
  RCS file: /home/cvspsrv/cvsroot/eda/geda/gaf/libgeda/src/o_attrib.c,v
  retrieving revision 1.37
  retrieving revision 1.38
  diff -u -b -r1.37 -r1.38
  --- o_attrib.c	15 Jul 2006 20:49:52 -0000	1.37
  +++ o_attrib.c	15 Jul 2006 23:37:00 -0000	1.38
  @@ -917,6 +917,10 @@
       return(FALSE);
     }
   
  +
  +  /*! \todo Technically this isn't a correct if statement.  This if will 
  +   * cause an invalid read for strings:  =name and value= 
  +   */
     if ( (*(equal_ptr + 1) == ' ') || (*(equal_ptr - 1) == ' ') ) {
        /* sometimes you have text with an ='s in it, it shouldn't be */
        /* treated like an attribute */
  
  
  


_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs