[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
gEDA-cvs: branch: master updated (1.1.0-20070705-21-g9627ac6)
The branch, master has been updated
via 9627ac695a2d20171fdc44ff0a295b8430399f6f (commit)
via a35dc18f2f3c159c021a4bcb542780f7bfbe7196 (commit)
via d7e8f5abc35644e90bfabf84396023cab09f2968 (commit)
via 6fc2856767979c34ed216aebe4f8efb231d5a4b1 (commit)
via fb89def49fc33f71444cb625b3a26c8d754dd761 (commit)
from 3f3505662fe4bb8c585aea0ea965296bd923956c (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
=========
Summary
=========
Makefile | 4 +-
docs/configure.ac | 4 +-
examples/configure.ac | 4 +-
gattrib/configure.ac | 4 +-
gnetlist/configure.ac | 4 +-
gschem/configure.ac.in | 4 +-
gsymcheck/configure.ac | 4 +-
gsymcheck/src/s_check.c | 77 +++++++++++++++++----------
gsymcheck/tests/Makefile.am | 52 +++++++++++++++++--
gsymcheck/tests/buses.output | 2 +
gsymcheck/tests/connections1.output | 2 +
gsymcheck/tests/connections2.output | 12 ++++
gsymcheck/tests/connections2.sym | 54 ++++++++++----------
gsymcheck/tests/connections3.output | 2 +
gsymcheck/tests/correct.output | 1 +
gsymcheck/tests/duplicate_net.output | 3 +
gsymcheck/tests/duplicate_pinnumber.output | 3 +
gsymcheck/tests/duplicate_pinseq.output | 3 +
gsymcheck/tests/graphical_correct.output | 1 +
gsymcheck/tests/graphical_incorrect.output | 3 +
gsymcheck/tests/incorrect_footprint.output | 3 +
gsymcheck/tests/invalid_slotdef1.output | 3 +
gsymcheck/tests/invalid_slotdef2.output | 3 +
gsymcheck/tests/invalid_slotdef3.output | 2 +
gsymcheck/tests/invalid_slotdef4.output | 2 +
gsymcheck/tests/labelinside.output | 3 +
gsymcheck/tests/lots_of_errors.output | 19 +++++++
gsymcheck/tests/many_slotdefs.output | 5 ++
gsymcheck/tests/missing_device.output | 2 +
gsymcheck/tests/missing_footprint.output | 3 +
gsymcheck/tests/missing_numslots.output | 3 +
gsymcheck/tests/missing_pinlabel.output | 3 +
gsymcheck/tests/missing_pinlabel.sym | 52 +++++++++----------
gsymcheck/tests/missing_pinnumber.output | 2 +
gsymcheck/tests/missing_pinseq.output | 2 +
gsymcheck/tests/missing_slotdef.output | 2 +
gsymcheck/tests/multiple_footprint.output | 2 +
gsymcheck/tests/multiple_pinlabel.output | 2 +
gsymcheck/tests/multiple_pinnumber.output | 2 +
gsymcheck/tests/multiple_pinseq.output | 2 +
gsymcheck/tests/multiple_pintype.output | 2 +
gsymcheck/tests/multiple_refdes.output | 2 +
gsymcheck/tests/nameinside.output | 2 +
gsymcheck/tests/nets.output | 2 +
gsymcheck/tests/noslots.output | 3 +
gsymcheck/tests/old_symbol.output | 21 ++++++++
gsymcheck/tests/oldpins.output | 10 ++++
gsymcheck/tests/oldslot.output | 5 ++
gsymcheck/tests/runtest.sh | 45 ++++++++++++++++
gsymcheck/tests/typeinside.output | 2 +
gsymcheck/tests/urefinside.output | 4 ++
gsymcheck/tests/zero_pinnumber.output | 2 +
gsymcheck/tests/zero_pinseq.output | 2 +
gsymcheck/tests/zero_slotnum.output | 3 +
gsymcheck/tests/zero_slots.output | 3 +
libgeda/configure.ac | 6 +-
symbols/configure.ac | 4 +-
update-changelogs.sh | 4 +-
utils/configure.ac | 4 +-
59 files changed, 376 insertions(+), 110 deletions(-)
create mode 100644 gsymcheck/tests/buses.output
create mode 100644 gsymcheck/tests/connections1.output
create mode 100644 gsymcheck/tests/connections2.output
create mode 100644 gsymcheck/tests/connections3.output
create mode 100644 gsymcheck/tests/correct.output
create mode 100644 gsymcheck/tests/duplicate_net.output
create mode 100644 gsymcheck/tests/duplicate_pinnumber.output
create mode 100644 gsymcheck/tests/duplicate_pinseq.output
create mode 100644 gsymcheck/tests/graphical_correct.output
create mode 100644 gsymcheck/tests/graphical_incorrect.output
create mode 100644 gsymcheck/tests/incorrect_footprint.output
create mode 100644 gsymcheck/tests/invalid_slotdef1.output
create mode 100644 gsymcheck/tests/invalid_slotdef2.output
create mode 100644 gsymcheck/tests/invalid_slotdef3.output
create mode 100644 gsymcheck/tests/invalid_slotdef4.output
create mode 100644 gsymcheck/tests/labelinside.output
create mode 100644 gsymcheck/tests/lots_of_errors.output
create mode 100644 gsymcheck/tests/many_slotdefs.output
create mode 100644 gsymcheck/tests/missing_device.output
create mode 100644 gsymcheck/tests/missing_footprint.output
create mode 100644 gsymcheck/tests/missing_numslots.output
create mode 100644 gsymcheck/tests/missing_pinlabel.output
create mode 100644 gsymcheck/tests/missing_pinnumber.output
create mode 100644 gsymcheck/tests/missing_pinseq.output
create mode 100644 gsymcheck/tests/missing_slotdef.output
create mode 100644 gsymcheck/tests/multiple_footprint.output
create mode 100644 gsymcheck/tests/multiple_pinlabel.output
create mode 100644 gsymcheck/tests/multiple_pinnumber.output
create mode 100644 gsymcheck/tests/multiple_pinseq.output
create mode 100644 gsymcheck/tests/multiple_pintype.output
create mode 100644 gsymcheck/tests/multiple_refdes.output
create mode 100644 gsymcheck/tests/nameinside.output
create mode 100644 gsymcheck/tests/nets.output
create mode 100644 gsymcheck/tests/noslots.output
create mode 100644 gsymcheck/tests/old_symbol.output
create mode 100644 gsymcheck/tests/oldpins.output
create mode 100644 gsymcheck/tests/oldslot.output
create mode 100755 gsymcheck/tests/runtest.sh
create mode 100644 gsymcheck/tests/typeinside.output
create mode 100644 gsymcheck/tests/urefinside.output
create mode 100644 gsymcheck/tests/zero_pinnumber.output
create mode 100644 gsymcheck/tests/zero_pinseq.output
create mode 100644 gsymcheck/tests/zero_slotnum.output
create mode 100644 gsymcheck/tests/zero_slots.output
=================
Commit Messages
=================
commit 9627ac695a2d20171fdc44ff0a295b8430399f6f
Author: Ales Hvezda <ahvezda@xxxxxxxx>
Date: Sun Jul 8 16:41:21 2007 -0400
Added tests in gschem/tests to run durning make check.
This is the other part of thie fix for bug #1748153: gsymcheck crashes
on invalid_slotdef1.sym. Fixed a couple of the the tests to actually
test the right thing. Added a bunch of golden files (*.output) and the
necessary run_test.sh script.
:100644 100644 2e1c969... 3791dc2... M gsymcheck/tests/Makefile.am
:000000 100644 0000000... 50fa1b1... A gsymcheck/tests/buses.output
:000000 100644 0000000... b16a333... A gsymcheck/tests/connections1.output
:000000 100644 0000000... 93ab2e1... A gsymcheck/tests/connections2.output
:100644 100644 238e0ae... 975a06c... M gsymcheck/tests/connections2.sym
:000000 100644 0000000... 50fa1b1... A gsymcheck/tests/connections3.output
:000000 100644 0000000... db9cf1c... A gsymcheck/tests/correct.output
:000000 100644 0000000... 7853e01... A gsymcheck/tests/duplicate_net.output
:000000 100644 0000000... 50423f0... A gsymcheck/tests/duplicate_pinnumber.output
:000000 100644 0000000... c790b29... A gsymcheck/tests/duplicate_pinseq.output
:000000 100644 0000000... db9cf1c... A gsymcheck/tests/graphical_correct.output
:000000 100644 0000000... ffd6b0e... A gsymcheck/tests/graphical_incorrect.output
:000000 100644 0000000... 2f825f5... A gsymcheck/tests/incorrect_footprint.output
:000000 100644 0000000... 5f1ff90... A gsymcheck/tests/invalid_slotdef1.output
:000000 100644 0000000... f596a6a... A gsymcheck/tests/invalid_slotdef2.output
:000000 100644 0000000... 553ed3b... A gsymcheck/tests/invalid_slotdef3.output
:000000 100644 0000000... cb86106... A gsymcheck/tests/invalid_slotdef4.output
:000000 100644 0000000... 4a495b4... A gsymcheck/tests/labelinside.output
:000000 100644 0000000... cc9646b... A gsymcheck/tests/lots_of_errors.output
:000000 100644 0000000... 4d196d1... A gsymcheck/tests/many_slotdefs.output
:000000 100644 0000000... 6b75008... A gsymcheck/tests/missing_device.output
:000000 100644 0000000... e79b8e4... A gsymcheck/tests/missing_footprint.output
:000000 100644 0000000... bf85810... A gsymcheck/tests/missing_numslots.output
:000000 100644 0000000... 5643a13... A gsymcheck/tests/missing_pinlabel.output
:100644 100644 df57615... 90f396d... M gsymcheck/tests/missing_pinlabel.sym
:000000 100644 0000000... 5cae601... A gsymcheck/tests/missing_pinnumber.output
:000000 100644 0000000... f8eb7dc... A gsymcheck/tests/missing_pinseq.output
:000000 100644 0000000... ff372c7... A gsymcheck/tests/missing_slotdef.output
:000000 100644 0000000... f547897... A gsymcheck/tests/multiple_footprint.output
:000000 100644 0000000... ae67aca... A gsymcheck/tests/multiple_pinlabel.output
:000000 100644 0000000... cc3e28f... A gsymcheck/tests/multiple_pinnumber.output
:000000 100644 0000000... 33808d3... A gsymcheck/tests/multiple_pinseq.output
:000000 100644 0000000... e943692... A gsymcheck/tests/multiple_pintype.output
:000000 100644 0000000... fc5b657... A gsymcheck/tests/multiple_refdes.output
:000000 100644 0000000... 320b2db... A gsymcheck/tests/nameinside.output
:000000 100644 0000000... b16a333... A gsymcheck/tests/nets.output
:000000 100644 0000000... bf85810... A gsymcheck/tests/noslots.output
:000000 100644 0000000... d8a7296... A gsymcheck/tests/old_symbol.output
:000000 100644 0000000... fa0982a... A gsymcheck/tests/oldpins.output
:000000 100644 0000000... 4904107... A gsymcheck/tests/oldslot.output
:000000 100755 0000000... 667b56f... A gsymcheck/tests/runtest.sh
:000000 100644 0000000... b912a76... A gsymcheck/tests/typeinside.output
:000000 100644 0000000... a813dc8... A gsymcheck/tests/urefinside.output
:000000 100644 0000000... 48c1b0a... A gsymcheck/tests/zero_pinnumber.output
:000000 100644 0000000... d660c96... A gsymcheck/tests/zero_pinseq.output
:000000 100644 0000000... 9686c2f... A gsymcheck/tests/zero_slotnum.output
:000000 100644 0000000... 6c346a6... A gsymcheck/tests/zero_slots.output
commit a35dc18f2f3c159c021a4bcb542780f7bfbe7196
Author: Ales Hvezda <ahvezda@xxxxxxxx>
Date: Sun Jul 8 16:36:52 2007 -0400
Fixed comment warning message and improved newly added comment
:100644 100644 ac1e404... 05f78de... M gsymcheck/src/s_check.c
commit d7e8f5abc35644e90bfabf84396023cab09f2968
Author: Ales Hvezda <ahvezda@xxxxxxxx>
Date: Sun Jul 8 16:18:57 2007 -0400
Updated configure.ac[.in] and Makefile versions in prep for a release.
The update was done by running ./update-versions.sh 1.1.1 20070708 30:1
at the toplevel. libgeda's shared library version is now 30:1:0
:100644 100644 751d3c7... f0fdc69... M Makefile
:100644 100644 452f50f... 67d32e6... M docs/configure.ac
:100644 100644 0e5220c... ae25e5e... M examples/configure.ac
:100644 100644 1a4f80b... 18637a3... M gattrib/configure.ac
:100644 100644 3290bd5... cbacb3c... M gnetlist/configure.ac
:100644 100644 12e73f9... 4cca3c9... M gschem/configure.ac.in
:100644 100644 b32f342... 121793b... M gsymcheck/configure.ac
:100644 100644 25e8e50... 663d791... M libgeda/configure.ac
:100644 100644 486c6c8... e46360d... M symbols/configure.ac
:100644 100644 d0ca0ce... b5403be... M utils/configure.ac
commit 6fc2856767979c34ed216aebe4f8efb231d5a4b1
Author: Ales Hvezda <ahvezda@xxxxxxxx>
Date: Sun Jul 8 16:14:25 2007 -0400
Fix for [ 1748153 ] gsymcheck crashes on invalid_slotdef1.sym
The fix for this bug was to check the built up pinlist array and make sure
that none of the items were null. Added error message and log entry when
this error condition.
:100644 100644 e8ec31d... ac1e404... M gsymcheck/src/s_check.c
commit fb89def49fc33f71444cb625b3a26c8d754dd761
Author: Ales Hvezda <ahvezda@xxxxxxxx>
Date: Sun Jul 8 14:19:10 2007 -0400
Fixed up comments in the update script to what works and is used when updating
:100755 100755 80b44ef... 1313a6e... M update-changelogs.sh
=========
Changes
=========
commit 9627ac695a2d20171fdc44ff0a295b8430399f6f
Author: Ales Hvezda <ahvezda@xxxxxxxx>
Date: Sun Jul 8 16:41:21 2007 -0400
Added tests in gschem/tests to run durning make check.
This is the other part of thie fix for bug #1748153: gsymcheck crashes
on invalid_slotdef1.sym. Fixed a couple of the the tests to actually
test the right thing. Added a bunch of golden files (*.output) and the
necessary run_test.sh script.
diff --git a/gsymcheck/tests/Makefile.am b/gsymcheck/tests/Makefile.am
index 2e1c969..3791dc2 100644
--- a/gsymcheck/tests/Makefile.am
+++ b/gsymcheck/tests/Makefile.am
@@ -12,9 +12,53 @@ EXTRA_DIST = buses.sym connections1.sym connections2.sym connections3.sym \
nameinside.sym nets.sym noslots.sym old_symbol.sym oldpins.sym \
oldslot.sym typeinside.sym urefinside.sym zero_pinnumber.sym \
zero_pinseq.sym zero_slotnum.sym zero_slots.sym \
- incorrect_footprint.sym duplicate_net.sym
+ incorrect_footprint.sym duplicate_net.sym \
+ runtest.sh \
+ buses.output connections1.output connections2.output \
+ connections3.output correct.output duplicate_net.output \
+ duplicate_pinnumber.output duplicate_pinseq.output \
+ graphical_correct.output graphical_incorrect.output \
+ incorrect_footprint.output invalid_slotdef1.output \
+ invalid_slotdef2.output invalid_slotdef3.output \
+ invalid_slotdef4.output labelinside.output lots_of_errors.output \
+ many_slotdefs.output missing_device.output \
+ missing_footprint.output missing_numslots.output \
+ missing_pinlabel.output missing_pinnumber.output \
+ missing_pinseq.output missing_slotdef.output \
+ multiple_footprint.output multiple_pinlabel.output \
+ multiple_pinnumber.output multiple_pinseq.output \
+ multiple_pintype.output multiple_refdes.output \
+ nameinside.output nets.output noslots.output oldpins.output \
+ oldslot.output old_symbol.output typeinside.output \
+ urefinside.output zero_pinnumber.output zero_pinseq.output \
+ zero_slotnum.output zero_slots.output
-MOSTLYCLEANFILES = *.log *~
-CLEANFILES = *.log *~
-DISTCLEANFILES = *.log core FILE *~ prototype.bak
+check_SCRIPTS = tests
+
+BUILDDIR=$(top_builddir)/tests
+SRCDIR=$(srcdir)
+
+tests:
+
+# Cleanup
+ rm -f $(BUILDDIR)/new_*
+
+ for file in $(SRCDIR)/*.sym; do \
+ $(SRCDIR)/runtest.sh $$file $(BUILDDIR) $(SRCDIR); \
+ if [ $$? -ne 0 ]; then \
+ echo "$$file FAILED!"; \
+ exit 1; \
+ else \
+ echo "$$file passed."; \
+ fi; \
+ done
+
+# Cleanup
+# rm -f $(BUILDDIR)/new_*
+
+
+
+MOSTLYCLEANFILES = *.log *~ new_*
+CLEANFILES = *.log *~ new_*
+DISTCLEANFILES = *.log core FILE *~ prototype.bak new_*
MAINTAINERCLEANFILES = system-gsymcheckrc *.log *~ Makefile.in configure
diff --git a/gsymcheck/tests/buses.output b/gsymcheck/tests/buses.output
new file mode 100644
index 0000000..50fa1b1
--- /dev/null
+++ b/gsymcheck/tests/buses.output
@@ -0,0 +1,2 @@
+ERROR: Found a bus inside a symbol
+1 ERROR found
diff --git a/gsymcheck/tests/connections1.output b/gsymcheck/tests/connections1.output
new file mode 100644
index 0000000..b16a333
--- /dev/null
+++ b/gsymcheck/tests/connections1.output
@@ -0,0 +1,2 @@
+ERROR: Found a net inside a symbol
+1 ERROR found
diff --git a/gsymcheck/tests/connections2.output b/gsymcheck/tests/connections2.output
new file mode 100644
index 0000000..93ab2e1
--- /dev/null
+++ b/gsymcheck/tests/connections2.output
@@ -0,0 +1,12 @@
+Warning: Missing pinlabel= attribute
+Warning: Missing pintype= attribute
+ERROR: Missing pinseq= attribute
+ERROR: Missing pinnumber= attribute
+ERROR: Not enough pins in slotdef=1:1,2,3
+ERROR: Not enough pins in slotdef=2:4,5,6
+ERROR: Not enough pins in slotdef=3:9,10,8
+ERROR: Not enough pins in slotdef=4:12,13,11
+ERROR: Found a connection inside a symbol
+ERROR: Found a connection inside a symbol
+2 warnings found
+8 ERRORS found
diff --git a/gsymcheck/tests/connections2.sym b/gsymcheck/tests/connections2.sym
index 238e0ae..975a06c 100644
--- a/gsymcheck/tests/connections2.sym
+++ b/gsymcheck/tests/connections2.sym
@@ -1,60 +1,60 @@
-v 20020527
+v 20070708 1
L 300 200 300 800 3 0 0 0 -1 -1
-T 300 0 9 8 1 0 0 0
+T 300 0 9 8 1 0 0 0 1
7400
L 300 800 700 800 3 0 0 0 -1 -1
-T 500 900 5 10 0 0 0 0
+T 500 900 5 10 0 0 0 0 1
device=7400
-T 1200 1100 5 10 0 0 0 0
+T 1200 1100 5 10 0 0 0 0 1
footprint=unspecified
-T 500 1100 5 10 0 0 0 0
+T 500 1100 5 10 0 0 0 0 1
slot=1
-T 500 1300 5 10 0 0 0 0
+T 500 1300 5 10 0 0 0 0 1
numslots=4
-T 500 1500 5 10 0 0 0 0
+T 500 1500 5 10 0 0 0 0 1
slotdef=1:1,2,3
-T 500 1700 5 10 0 0 0 0
+T 500 1700 5 10 0 0 0 0 1
slotdef=2:4,5,6
-T 500 1900 5 10 0 0 0 0
+T 500 1900 5 10 0 0 0 0 1
slotdef=3:9,10,8
-T 500 2100 5 10 0 0 0 0
+T 500 2100 5 10 0 0 0 0 1
slotdef=4:12,13,11
L 300 200 700 200 3 0 0 0 -1 -1
A 700 500 300 270 180 3 0 0 0 -1 -1
V 1050 500 50 6 0 0 0 -1 -1 0 -1 -1 -1 -1 -1
-P 1100 500 1300 500 1
+P 1100 500 1300 500 1 0 1
{
-T 1085 350 5 8 0 0 0 0
+T 1085 350 5 8 0 0 0 0 1
pinseq=3
-T 1085 550 5 8 1 1 0 0
+T 1085 550 5 8 1 1 0 0 1
pinnumber=3
-T 1085 350 5 8 0 0 0 0
+T 1085 350 5 8 0 0 0 0 1
pinlabel=C
-T 1085 350 5 8 0 0 0 0
+T 1085 350 5 8 0 0 0 0 1
pintype=out
}
-P 300 300 0 300 1
+P 300 300 0 300 1 0 1
{
-T 0 150 5 8 0 0 0 0
+T 0 150 5 8 0 0 0 0 1
pinseq=2
-T 100 350 5 8 1 1 0 0
+T 100 350 5 8 1 1 0 0 1
pinnumber=2
-T 0 150 5 8 0 0 0 0
+T 0 150 5 8 0 0 0 0 1
pinlabel=B
-T 0 150 5 8 0 0 0 0
+T 0 150 5 8 0 0 0 0 1
pintype=in
}
-P 300 700 0 700 1
+P 300 700 0 700 1 0 1
{
-T 0 550 5 8 0 0 0 0
+T 0 550 5 8 0 0 0 0 1
pinseq=1
-T 100 750 5 8 1 1 0 0
+T 100 750 5 8 1 1 0 0 1
pinnumber=1
-T 0 550 5 8 0 0 0 0
+T 0 550 5 8 0 0 0 0 1
pinlabel=A
-T 0 550 5 8 0 0 0 0
+T 0 550 5 8 0 0 0 0 1
pintype=in
}
-T 300 900 8 10 1 1 0 0
+T 300 900 8 10 1 1 0 0 1
refdes=U?
-P 1300 500 1300 800 1
+P 1300 800 1300 500 1 0 1
diff --git a/gsymcheck/tests/connections3.output b/gsymcheck/tests/connections3.output
new file mode 100644
index 0000000..50fa1b1
--- /dev/null
+++ b/gsymcheck/tests/connections3.output
@@ -0,0 +1,2 @@
+ERROR: Found a bus inside a symbol
+1 ERROR found
diff --git a/gsymcheck/tests/correct.output b/gsymcheck/tests/correct.output
new file mode 100644
index 0000000..db9cf1c
--- /dev/null
+++ b/gsymcheck/tests/correct.output
@@ -0,0 +1 @@
+No errors found
diff --git a/gsymcheck/tests/duplicate_net.output b/gsymcheck/tests/duplicate_net.output
new file mode 100644
index 0000000..7853e01
--- /dev/null
+++ b/gsymcheck/tests/duplicate_net.output
@@ -0,0 +1,3 @@
+ERROR: Found duplicate pinnumber=1 attribute in the symbol
+ERROR: Found duplicate pinnumber=1 attribute in the symbol
+2 ERRORS found
diff --git a/gsymcheck/tests/duplicate_pinnumber.output b/gsymcheck/tests/duplicate_pinnumber.output
new file mode 100644
index 0000000..50423f0
--- /dev/null
+++ b/gsymcheck/tests/duplicate_pinnumber.output
@@ -0,0 +1,3 @@
+ERROR: Found duplicate pinnumber=2 attribute in the symbol
+ERROR: Found duplicate pinnumber=2 attribute in the symbol
+2 ERRORS found
diff --git a/gsymcheck/tests/duplicate_pinseq.output b/gsymcheck/tests/duplicate_pinseq.output
new file mode 100644
index 0000000..c790b29
--- /dev/null
+++ b/gsymcheck/tests/duplicate_pinseq.output
@@ -0,0 +1,3 @@
+ERROR: Found duplicate pinseq=1 attribute in the symbol
+ERROR: Found duplicate pinseq=1 attribute in the symbol
+2 ERRORS found
diff --git a/gsymcheck/tests/graphical_correct.output b/gsymcheck/tests/graphical_correct.output
new file mode 100644
index 0000000..db9cf1c
--- /dev/null
+++ b/gsymcheck/tests/graphical_correct.output
@@ -0,0 +1 @@
+No errors found
diff --git a/gsymcheck/tests/graphical_incorrect.output b/gsymcheck/tests/graphical_incorrect.output
new file mode 100644
index 0000000..ffd6b0e
--- /dev/null
+++ b/gsymcheck/tests/graphical_incorrect.output
@@ -0,0 +1,3 @@
+Warning: Found graphical symbol, device= should be set to none
+1 warnings found
+No errors found
diff --git a/gsymcheck/tests/incorrect_footprint.output b/gsymcheck/tests/incorrect_footprint.output
new file mode 100644
index 0000000..2f825f5
--- /dev/null
+++ b/gsymcheck/tests/incorrect_footprint.output
@@ -0,0 +1,3 @@
+Warning: Number of pins does not match footprint size.
+1 warnings found
+No errors found
diff --git a/gsymcheck/tests/invalid_slotdef1.output b/gsymcheck/tests/invalid_slotdef1.output
new file mode 100644
index 0000000..5f1ff90
--- /dev/null
+++ b/gsymcheck/tests/invalid_slotdef1.output
@@ -0,0 +1,3 @@
+ERROR: Invalid slotdef=a attributes, not continuing
+ERROR: Malformed slotdef= (the format is #:#,#,#,...)
+2 ERRORS found
diff --git a/gsymcheck/tests/invalid_slotdef2.output b/gsymcheck/tests/invalid_slotdef2.output
new file mode 100644
index 0000000..f596a6a
--- /dev/null
+++ b/gsymcheck/tests/invalid_slotdef2.output
@@ -0,0 +1,3 @@
+ERROR: Invalid slotdef=a: attributes, not continuing
+ERROR: Malformed slotdef= (the format is #:#,#,#,...)
+2 ERRORS found
diff --git a/gsymcheck/tests/invalid_slotdef3.output b/gsymcheck/tests/invalid_slotdef3.output
new file mode 100644
index 0000000..553ed3b
--- /dev/null
+++ b/gsymcheck/tests/invalid_slotdef3.output
@@ -0,0 +1,2 @@
+ERROR: Not enough pins in slotdef=4:12,13
+1 ERROR found
diff --git a/gsymcheck/tests/invalid_slotdef4.output b/gsymcheck/tests/invalid_slotdef4.output
new file mode 100644
index 0000000..cb86106
--- /dev/null
+++ b/gsymcheck/tests/invalid_slotdef4.output
@@ -0,0 +1,2 @@
+ERROR: Too many pins in slotdef=4:12,13,14,15
+1 ERROR found
diff --git a/gsymcheck/tests/labelinside.output b/gsymcheck/tests/labelinside.output
new file mode 100644
index 0000000..4a495b4
--- /dev/null
+++ b/gsymcheck/tests/labelinside.output
@@ -0,0 +1,3 @@
+Warning: Found obsolete label= attribute: label=this obsolete
+1 warnings found
+No errors found
diff --git a/gsymcheck/tests/lots_of_errors.output b/gsymcheck/tests/lots_of_errors.output
new file mode 100644
index 0000000..cc9646b
--- /dev/null
+++ b/gsymcheck/tests/lots_of_errors.output
@@ -0,0 +1,19 @@
+Warning: Missing pinlabel= attribute
+Warning: Missing pintype= attribute
+Warning: Missing pinlabel= attribute
+Warning: Missing pintype= attribute
+Warning: Missing pinlabel= attribute
+Warning: Missing pintype= attribute
+Warning: Missing footprint= attribute
+Warning: Missing refdes= attribute
+Warning: Found obsolete uref= attribute: uref=U?
+ERROR: Missing device= attribute
+ERROR: Missing pinseq= attribute
+ERROR: Missing pinnumber= attribute
+ERROR: Too many pins in slotdef=1:1,2,3,5,6
+ERROR: Not enough pins in slotdef=2:4,5
+ERROR: Slot 8 is larger then the maximum number (5) of slots
+ERROR: Invalid slotdef=a attributes, not continuing
+ERROR: Malformed slotdef= (the format is #:#,#,#,...)
+9 warnings found
+8 ERRORS found
diff --git a/gsymcheck/tests/many_slotdefs.output b/gsymcheck/tests/many_slotdefs.output
new file mode 100644
index 0000000..4d196d1
--- /dev/null
+++ b/gsymcheck/tests/many_slotdefs.output
@@ -0,0 +1,5 @@
+ERROR: Found 5 slotdef= attributes. Expecting 4 slotdef= attributes
+ERROR: Slot 5 is larger then the maximum number (4) of slots
+ERROR: Found 6 slotdef= attributes. Expecting 4 slotdef= attributes
+ERROR: Slot 6 is larger then the maximum number (4) of slots
+4 ERRORS found
diff --git a/gsymcheck/tests/missing_device.output b/gsymcheck/tests/missing_device.output
new file mode 100644
index 0000000..6b75008
--- /dev/null
+++ b/gsymcheck/tests/missing_device.output
@@ -0,0 +1,2 @@
+ERROR: Missing device= attribute
+1 ERROR found
diff --git a/gsymcheck/tests/missing_footprint.output b/gsymcheck/tests/missing_footprint.output
new file mode 100644
index 0000000..e79b8e4
--- /dev/null
+++ b/gsymcheck/tests/missing_footprint.output
@@ -0,0 +1,3 @@
+Warning: Missing footprint= attribute
+1 warnings found
+No errors found
diff --git a/gsymcheck/tests/missing_numslots.output b/gsymcheck/tests/missing_numslots.output
new file mode 100644
index 0000000..bf85810
--- /dev/null
+++ b/gsymcheck/tests/missing_numslots.output
@@ -0,0 +1,3 @@
+Warning: Did not find numslots= attribute, not checking slotting
+1 warnings found
+No errors found
diff --git a/gsymcheck/tests/missing_pinlabel.output b/gsymcheck/tests/missing_pinlabel.output
new file mode 100644
index 0000000..5643a13
--- /dev/null
+++ b/gsymcheck/tests/missing_pinlabel.output
@@ -0,0 +1,3 @@
+Warning: Missing pinlabel= attribute
+1 warnings found
+No errors found
diff --git a/gsymcheck/tests/missing_pinlabel.sym b/gsymcheck/tests/missing_pinlabel.sym
index df57615..90f396d 100644
--- a/gsymcheck/tests/missing_pinlabel.sym
+++ b/gsymcheck/tests/missing_pinlabel.sym
@@ -1,59 +1,57 @@
-v 20020527
+v 20070708 1
L 300 200 300 800 3 0 0 0 -1 -1
-T 300 0 9 8 1 0 0 0
+T 300 0 9 8 1 0 0 0 1
7400
L 300 800 700 800 3 0 0 0 -1 -1
-T 500 900 5 10 0 0 0 0
+T 500 900 5 10 0 0 0 0 1
device=7400
-T 1200 1100 5 10 0 0 0 0
+T 1200 1100 5 10 0 0 0 0 1
footprint=unspecified
-T 500 1100 5 10 0 0 0 0
+T 500 1100 5 10 0 0 0 0 1
slot=1
-T 500 1300 5 10 0 0 0 0
+T 500 1300 5 10 0 0 0 0 1
numslots=4
-T 500 1500 5 10 0 0 0 0
+T 500 1500 5 10 0 0 0 0 1
slotdef=1:1,2,3
-T 500 1700 5 10 0 0 0 0
+T 500 1700 5 10 0 0 0 0 1
slotdef=2:4,5,6
-T 500 1900 5 10 0 0 0 0
+T 500 1900 5 10 0 0 0 0 1
slotdef=3:9,10,8
-T 500 2100 5 10 0 0 0 0
+T 500 2100 5 10 0 0 0 0 1
slotdef=4:12,13,11
L 300 200 700 200 3 0 0 0 -1 -1
A 700 500 300 270 180 3 0 0 0 -1 -1
V 1050 500 50 6 0 0 0 -1 -1 0 -1 -1 -1 -1 -1
-P 1100 500 1300 500 1
+P 1100 500 1300 500 1 0 1
{
-T 1085 350 5 8 0 0 0 0
+T 1085 350 5 8 0 0 0 0 1
pinseq=3
-T 1085 550 5 8 1 1 0 0
+T 1085 550 5 8 1 1 0 0 1
pinnumber=3
-T 1085 350 5 8 0 0 0 0
+T 1085 350 5 8 0 0 0 0 1
pinlabel=C
-T 1085 350 5 8 0 0 0 0
+T 1085 350 5 8 0 0 0 0 1
pintype=out
}
-P 300 300 0 300 1
+P 300 300 0 300 1 0 1
{
-T 0 150 5 8 0 0 0 0
+T 0 150 5 8 0 0 0 0 1
pinseq=2
-T 100 350 5 8 1 1 0 0
+T 100 350 5 8 1 1 0 0 1
pinnumber=2
-T 0 150 5 8 0 0 0 0
+T 0 150 5 8 0 0 0 0 1
pinlabel=B
-T 0 150 5 8 0 0 0 0
+T 0 150 5 8 0 0 0 0 1
pintype=in
}
-P 300 700 0 700 1
+P 300 700 0 700 1 0 1
{
-T 0 550 5 8 0 0 0 0
+T 0 550 5 8 0 0 0 0 1
pinseq=1
-T 100 750 5 8 1 1 0 0
+T 100 750 5 8 1 1 0 0 1
pinnumber=1
-T 0 550 5 8 0 0 0 0
-pinlabel=A
-T 0 550 5 8 0 0 0 0
+T 0 550 5 8 0 0 0 0 1
pintype=in
}
-T 300 900 8 10 1 1 0 0
+T 300 900 8 10 1 1 0 0 1
refdes=U?
diff --git a/gsymcheck/tests/missing_pinnumber.output b/gsymcheck/tests/missing_pinnumber.output
new file mode 100644
index 0000000..5cae601
--- /dev/null
+++ b/gsymcheck/tests/missing_pinnumber.output
@@ -0,0 +1,2 @@
+ERROR: Missing pinnumber= attribute
+1 ERROR found
diff --git a/gsymcheck/tests/missing_pinseq.output b/gsymcheck/tests/missing_pinseq.output
new file mode 100644
index 0000000..f8eb7dc
--- /dev/null
+++ b/gsymcheck/tests/missing_pinseq.output
@@ -0,0 +1,2 @@
+ERROR: Missing pinseq= attribute
+1 ERROR found
diff --git a/gsymcheck/tests/missing_slotdef.output b/gsymcheck/tests/missing_slotdef.output
new file mode 100644
index 0000000..ff372c7
--- /dev/null
+++ b/gsymcheck/tests/missing_slotdef.output
@@ -0,0 +1,2 @@
+ERROR: Missing slotdef= (there should be 4 slotdef= attributes)
+1 ERROR found
diff --git a/gsymcheck/tests/multiple_footprint.output b/gsymcheck/tests/multiple_footprint.output
new file mode 100644
index 0000000..f547897
--- /dev/null
+++ b/gsymcheck/tests/multiple_footprint.output
@@ -0,0 +1,2 @@
+ERROR: Multiple footprint= attributes found
+1 ERROR found
diff --git a/gsymcheck/tests/multiple_pinlabel.output b/gsymcheck/tests/multiple_pinlabel.output
new file mode 100644
index 0000000..ae67aca
--- /dev/null
+++ b/gsymcheck/tests/multiple_pinlabel.output
@@ -0,0 +1,2 @@
+ERROR: Found multiple pinlabel=extra attributes on one pin
+1 ERROR found
diff --git a/gsymcheck/tests/multiple_pinnumber.output b/gsymcheck/tests/multiple_pinnumber.output
new file mode 100644
index 0000000..cc3e28f
--- /dev/null
+++ b/gsymcheck/tests/multiple_pinnumber.output
@@ -0,0 +1,2 @@
+ERROR: Found multiple pinnumber=3 attributes on one pin
+1 ERROR found
diff --git a/gsymcheck/tests/multiple_pinseq.output b/gsymcheck/tests/multiple_pinseq.output
new file mode 100644
index 0000000..33808d3
--- /dev/null
+++ b/gsymcheck/tests/multiple_pinseq.output
@@ -0,0 +1,2 @@
+ERROR: Found multiple pinseq=3 attributes on one pin
+1 ERROR found
diff --git a/gsymcheck/tests/multiple_pintype.output b/gsymcheck/tests/multiple_pintype.output
new file mode 100644
index 0000000..e943692
--- /dev/null
+++ b/gsymcheck/tests/multiple_pintype.output
@@ -0,0 +1,2 @@
+ERROR: Found multiple pintype=out attributes on one pin
+1 ERROR found
diff --git a/gsymcheck/tests/multiple_refdes.output b/gsymcheck/tests/multiple_refdes.output
new file mode 100644
index 0000000..fc5b657
--- /dev/null
+++ b/gsymcheck/tests/multiple_refdes.output
@@ -0,0 +1,2 @@
+ERROR: Multiple refdes= attributes found
+1 ERROR found
diff --git a/gsymcheck/tests/nameinside.output b/gsymcheck/tests/nameinside.output
new file mode 100644
index 0000000..320b2db
--- /dev/null
+++ b/gsymcheck/tests/nameinside.output
@@ -0,0 +1,2 @@
+ERROR: Found forbidden name= attribute: name=this a forbidden attribute
+1 ERROR found
diff --git a/gsymcheck/tests/nets.output b/gsymcheck/tests/nets.output
new file mode 100644
index 0000000..b16a333
--- /dev/null
+++ b/gsymcheck/tests/nets.output
@@ -0,0 +1,2 @@
+ERROR: Found a net inside a symbol
+1 ERROR found
diff --git a/gsymcheck/tests/noslots.output b/gsymcheck/tests/noslots.output
new file mode 100644
index 0000000..bf85810
--- /dev/null
+++ b/gsymcheck/tests/noslots.output
@@ -0,0 +1,3 @@
+Warning: Did not find numslots= attribute, not checking slotting
+1 warnings found
+No errors found
diff --git a/gsymcheck/tests/old_symbol.output b/gsymcheck/tests/old_symbol.output
new file mode 100644
index 0000000..d8a7296
--- /dev/null
+++ b/gsymcheck/tests/old_symbol.output
@@ -0,0 +1,21 @@
+Warning: Missing pintype= attribute
+Warning: Missing pintype= attribute
+Warning: Missing pinlabel= attribute
+Warning: Missing refdes= attribute
+Warning: Found obsolete uref= attribute: uref=U?
+ERROR: Invalid pintype=123just a type attribute
+ERROR: Missing pinseq= attribute
+ERROR: Missing pinseq= attribute
+ERROR: Missing pinseq= attribute
+ERROR: Missing pinnumber= attribute
+ERROR: Missing pinnumber= attribute
+ERROR: Missing pinnumber= attribute
+ERROR: Missing slotdef= (there should be 4 slotdef= attributes)
+ERROR: Found old pin#=# attribute: pin3=3
+ERROR: Found old pin#=# attribute: pin2=2
+ERROR: Found old pin#=# attribute: pin1=1
+ERROR: Found old slot#=# attribute: slot1=1,2,3
+ERROR: Found old slot#=# attribute: slot2=4,5,6
+ERROR: Found old slot#=# attribute: slot4=12,13,11
+5 warnings found
+14 ERRORS found
diff --git a/gsymcheck/tests/oldpins.output b/gsymcheck/tests/oldpins.output
new file mode 100644
index 0000000..fa0982a
--- /dev/null
+++ b/gsymcheck/tests/oldpins.output
@@ -0,0 +1,10 @@
+ERROR: Missing pinseq= attribute
+ERROR: Missing pinseq= attribute
+ERROR: Missing pinseq= attribute
+ERROR: Missing pinnumber= attribute
+ERROR: Missing pinnumber= attribute
+ERROR: Missing pinnumber= attribute
+ERROR: Found old pin#=# attribute: pin3=3
+ERROR: Found old pin#=# attribute: pin2=2
+ERROR: Found old pin#=# attribute: pin1=1
+9 ERRORS found
diff --git a/gsymcheck/tests/oldslot.output b/gsymcheck/tests/oldslot.output
new file mode 100644
index 0000000..4904107
--- /dev/null
+++ b/gsymcheck/tests/oldslot.output
@@ -0,0 +1,5 @@
+ERROR: Missing slotdef= (there should be 4 slotdef= attributes)
+ERROR: Found old slot#=# attribute: slot1=1,2,3
+ERROR: Found old slot#=# attribute: slot2=4,5,6
+ERROR: Found old slot#=# attribute: slot4=12,13,11
+4 ERRORS found
diff --git a/gsymcheck/tests/runtest.sh b/gsymcheck/tests/runtest.sh
new file mode 100755
index 0000000..667b56f
--- /dev/null
+++ b/gsymcheck/tests/runtest.sh
@@ -0,0 +1,45 @@
+#!/bin/sh
+
+INPUT=$1
+BACKEND=$2
+BUILDDIR=$3
+SRCDIR=$4
+EXTRADIFF=$5
+here=`pwd`
+rundir=${here}/run
+
+# create temporary run directory and required subdirs
+if [ ! -d $rundir ]
+then
+ mkdir -p $rundir
+fi
+
+TESTDIR=${BUILDDIR}
+export TESTDIR
+
+symbasename=`basename $INPUT .sym`
+
+tmpfile=$rundir/tmp$$
+../src/gsymcheck -vv $INPUT 1> $tmpfile 2> $rundir/allerrors.output
+
+cat $tmpfile | \
+ grep -v "gEDA/gsymcheck version" | \
+ grep -v "ABSOLUTELY NO WARRANTY" | \
+ grep -v "This is free software" | \
+ grep -v "the COPYING file" | \
+ grep -v "Checking: " | \
+ grep -v '^$' > $rundir/${BUILDDIR}/new_${symbasename}.output
+rm -f $tmpfile
+
+diff $EXTRADIFF ${BUILDDIR}/${symbasename}.output \
+ $rundir/${BUILDDIR}/new_${symbasename}.output
+status=$?
+
+rm -rf $rundir
+
+if [ "$status" != 0 ]
+then
+ exit 2
+fi
+
+exit 0
diff --git a/gsymcheck/tests/typeinside.output b/gsymcheck/tests/typeinside.output
new file mode 100644
index 0000000..b912a76
--- /dev/null
+++ b/gsymcheck/tests/typeinside.output
@@ -0,0 +1,2 @@
+ERROR: Found forbidden type= attribute: type=this a forbidden attribute
+1 ERROR found
diff --git a/gsymcheck/tests/urefinside.output b/gsymcheck/tests/urefinside.output
new file mode 100644
index 0000000..a813dc8
--- /dev/null
+++ b/gsymcheck/tests/urefinside.output
@@ -0,0 +1,4 @@
+Warning: Missing refdes= attribute
+Warning: Found obsolete uref= attribute: uref=U?
+2 warnings found
+No errors found
diff --git a/gsymcheck/tests/zero_pinnumber.output b/gsymcheck/tests/zero_pinnumber.output
new file mode 100644
index 0000000..48c1b0a
--- /dev/null
+++ b/gsymcheck/tests/zero_pinnumber.output
@@ -0,0 +1,2 @@
+ERROR: Found pinnumber=0 attribute
+1 ERROR found
diff --git a/gsymcheck/tests/zero_pinseq.output b/gsymcheck/tests/zero_pinseq.output
new file mode 100644
index 0000000..d660c96
--- /dev/null
+++ b/gsymcheck/tests/zero_pinseq.output
@@ -0,0 +1,2 @@
+ERROR: Found pinseq=0 attribute
+1 ERROR found
diff --git a/gsymcheck/tests/zero_slotnum.output b/gsymcheck/tests/zero_slotnum.output
new file mode 100644
index 0000000..9686c2f
--- /dev/null
+++ b/gsymcheck/tests/zero_slotnum.output
@@ -0,0 +1,3 @@
+ERROR: Found a zero slot in slotdef=0:4,5,6
+ERROR: Malformed slotdef= (the format is #:#,#,#,...)
+2 ERRORS found
diff --git a/gsymcheck/tests/zero_slots.output b/gsymcheck/tests/zero_slots.output
new file mode 100644
index 0000000..6c346a6
--- /dev/null
+++ b/gsymcheck/tests/zero_slots.output
@@ -0,0 +1,3 @@
+ERROR: Found a zero pin in slotdef=1:1,0,3
+ERROR: Found a zero pin in slotdef=4:12,13,0
+2 ERRORS found
commit a35dc18f2f3c159c021a4bcb542780f7bfbe7196
Author: Ales Hvezda <ahvezda@xxxxxxxx>
Date: Sun Jul 8 16:36:52 2007 -0400
Fixed comment warning message and improved newly added comment
diff --git a/gsymcheck/src/s_check.c b/gsymcheck/src/s_check.c
index ac1e404..05f78de 100644
--- a/gsymcheck/src/s_check.c
+++ b/gsymcheck/src/s_check.c
@@ -803,8 +803,9 @@ s_check_slotdef(OBJECT *object_head, SYMCHECK *s_current)
s_current->slotting_errors++;
} else {
- /* Validate that the pins list isn't null. If anybody is null, that
- /* means the slotdef= attribute was malformed */
+ /* Validate that pinslist does not contain a null entry. If any entry */
+ /* is null, that means the slotdef= attribute was malformed to start */
+ /* with. */
for (i = 0; i < s_current->numslots; i++) {
if (pinlist[i] == NULL) {
errors_found++;
commit d7e8f5abc35644e90bfabf84396023cab09f2968
Author: Ales Hvezda <ahvezda@xxxxxxxx>
Date: Sun Jul 8 16:18:57 2007 -0400
Updated configure.ac[.in] and Makefile versions in prep for a release.
The update was done by running ./update-versions.sh 1.1.1 20070708 30:1
at the toplevel. libgeda's shared library version is now 30:1:0
diff --git a/Makefile b/Makefile
index 751d3c7..f0fdc69 100644
--- a/Makefile
+++ b/Makefile
@@ -9,8 +9,8 @@
# can be accomplished by running ./update-versions.sh with the correct
# arguments.
#
-DOTTED_VERSION=1.1.0
-DATE_VERSION=20070705
+DOTTED_VERSION=1.1.1
+DATE_VERSION=20070708
#
# Use this when you are building the repository version
diff --git a/docs/configure.ac b/docs/configure.ac
index 452f50f..67d32e6 100644
--- a/docs/configure.ac
+++ b/docs/configure.ac
@@ -3,8 +3,8 @@ AC_INIT
AC_CONFIG_SRCDIR([wiki/index.html])
AC_PREREQ(2.54)
-DOTTED_VERSION=1.1.0
-DATE_VERSION=20070705
+DOTTED_VERSION=1.1.1
+DATE_VERSION=20070708
PACKAGE=geda-docs
echo Configuring $PACKAGE version $DOTTED_VERSION.$DATE_VERSION
diff --git a/examples/configure.ac b/examples/configure.ac
index 0e5220c..ae25e5e 100644
--- a/examples/configure.ac
+++ b/examples/configure.ac
@@ -4,8 +4,8 @@ AC_CONFIG_SRCDIR([gTAG/gTAG.sch])
AC_PREREQ(2.54)
PACKAGE=geda-examples
-DOTTED_VERSION=1.1.0
-DATE_VERSION=20070705
+DOTTED_VERSION=1.1.1
+DATE_VERSION=20070708
echo Configuring $PACKAGE version $DOTTED_VERSION.$DATE_VERSION
# Initialize automake
diff --git a/gattrib/configure.ac b/gattrib/configure.ac
index 1a4f80b..18637a3 100644
--- a/gattrib/configure.ac
+++ b/gattrib/configure.ac
@@ -4,8 +4,8 @@ AC_CONFIG_SRCDIR([src/gattrib.c])
AC_PREREQ(2.54)
PACKAGE=geda-gattrib
-DOTTED_VERSION=1.1.0
-DATE_VERSION=20070705
+DOTTED_VERSION=1.1.1
+DATE_VERSION=20070708
echo Configuring $PACKAGE version $DOTTED_VERSION.$DATE_VERSION
# Initialize automake
diff --git a/gnetlist/configure.ac b/gnetlist/configure.ac
index 3290bd5..cbacb3c 100644
--- a/gnetlist/configure.ac
+++ b/gnetlist/configure.ac
@@ -4,8 +4,8 @@ AC_CONFIG_SRCDIR([src/gnetlist.c])
AC_PREREQ(2.54)
PACKAGE=geda-gnetlist
-DOTTED_VERSION=1.1.0
-DATE_VERSION=20070705
+DOTTED_VERSION=1.1.1
+DATE_VERSION=20070708
echo Configuring $PACKAGE version $DOTTED_VERSION.$DATE_VERSION
# Initialize automake
diff --git a/gschem/configure.ac.in b/gschem/configure.ac.in
index 12e73f9..4cca3c9 100644
--- a/gschem/configure.ac.in
+++ b/gschem/configure.ac.in
@@ -4,8 +4,8 @@ AC_CONFIG_SRCDIR([src/gschem.c])
AC_PREREQ(2.54)
PACKAGE=geda-gschem
-DOTTED_VERSION=1.1.0
-DATE_VERSION=20070705
+DOTTED_VERSION=1.1.1
+DATE_VERSION=20070708
echo Configuring $PACKAGE version $DOTTED_VERSION.$DATE_VERSION
# Initialize automake
diff --git a/gsymcheck/configure.ac b/gsymcheck/configure.ac
index b32f342..121793b 100644
--- a/gsymcheck/configure.ac
+++ b/gsymcheck/configure.ac
@@ -4,8 +4,8 @@ AC_CONFIG_SRCDIR([src/gsymcheck.c])
AC_PREREQ(2.54)
PACKAGE=geda-gsymcheck
-DOTTED_VERSION=1.1.0
-DATE_VERSION=20070705
+DOTTED_VERSION=1.1.1
+DATE_VERSION=20070708
echo Configuring $PACKAGE version $DOTTED_VERSION.$DATE_VERSION
# Initialize automake
diff --git a/libgeda/configure.ac b/libgeda/configure.ac
index 25e8e50..663d791 100644
--- a/libgeda/configure.ac
+++ b/libgeda/configure.ac
@@ -4,9 +4,9 @@ AC_CONFIG_SRCDIR([include/libgeda.h])
AC_PREREQ(2.54)
PACKAGE=libgeda
-DOTTED_VERSION=1.1.0
-DATE_VERSION=20070705
-SHARED_LIBRARY_VERSION=30:0:0
+DOTTED_VERSION=1.1.1
+DATE_VERSION=20070708
+SHARED_LIBRARY_VERSION=30:1:0
echo Configuring $PACKAGE version $DOTTED_VERSION.$DATE_VERSION
# Init automake
diff --git a/symbols/configure.ac b/symbols/configure.ac
index 486c6c8..e46360d 100644
--- a/symbols/configure.ac
+++ b/symbols/configure.ac
@@ -4,8 +4,8 @@ AC_CONFIG_SRCDIR([74/7400-1.sym])
AC_PREREQ(2.54)
PACKAGE=geda-symbols
-DOTTED_VERSION=1.1.0
-DATE_VERSION=20070705
+DOTTED_VERSION=1.1.1
+DATE_VERSION=20070708
echo Configuring $PACKAGE version $DOTTED_VERSION.$DATE_VERSION
# Initialize automake stuff
diff --git a/utils/configure.ac b/utils/configure.ac
index d0ca0ce..b5403be 100644
--- a/utils/configure.ac
+++ b/utils/configure.ac
@@ -4,8 +4,8 @@ AC_CONFIG_SRCDIR([src/gmk_sym.c])
AC_PREREQ(2.54)
PACKAGE=geda-utils
-DOTTED_VERSION=1.1.0
-DATE_VERSION=20070705
+DOTTED_VERSION=1.1.1
+DATE_VERSION=20070708
echo Configuring $PACKAGE version $DOTTED_VERSION.$DATE_VERSION
# Initialize automake
commit 6fc2856767979c34ed216aebe4f8efb231d5a4b1
Author: Ales Hvezda <ahvezda@xxxxxxxx>
Date: Sun Jul 8 16:14:25 2007 -0400
Fix for [ 1748153 ] gsymcheck crashes on invalid_slotdef1.sym
The fix for this bug was to check the built up pinlist array and make sure
that none of the items were null. Added error message and log entry when
this error condition.
diff --git a/gsymcheck/src/s_check.c b/gsymcheck/src/s_check.c
index e8ec31d..ac1e404 100644
--- a/gsymcheck/src/s_check.c
+++ b/gsymcheck/src/s_check.c
@@ -591,6 +591,7 @@ s_check_slotdef(OBJECT *object_head, SYMCHECK *s_current)
char* cmp;
int match;
gboolean error_parsing = FALSE;
+ int errors_found = 0;
/* look for numslots to see if this symbol has slotting info */
value = o_attrib_search_name(object_head, "numslots", 0);
@@ -801,37 +802,54 @@ s_check_slotdef(OBJECT *object_head, SYMCHECK *s_current)
s_current->error_count++;
s_current->slotting_errors++;
} else {
- /* Now compare each pin with the rest */
- s_current->numslotpins = 0;
- for (i = 0; i < s_current->numslots; i++) {
- for (n = 1; n <= s_current->numpins; n++) {
- /* Get the number of one pin */
- pin = u_basic_breakup_string(pinlist[i], ',', n);
- if (pin && *pin) {
- match = FALSE;
- for (j = i - 1; j >= 0 && !match; j--) {
- for (m = 1; m <= s_current->numpins && !match; m++) {
- /* Get the number of the other pin */
- cmp = u_basic_breakup_string(pinlist[j], ',', m);
- if (cmp && *cmp) {
- match = (0 == strcmp (pin, cmp));
- g_free(cmp);
- }
- }
- }
- if (!match) {
- /* If they don't match, then increase the number of pins */
- s_current->numslotpins++;
- }
- g_free(pin);
- }
+
+ /* Validate that the pins list isn't null. If anybody is null, that
+ /* means the slotdef= attribute was malformed */
+ for (i = 0; i < s_current->numslots; i++) {
+ if (pinlist[i] == NULL) {
+ errors_found++;
}
}
- message = g_strdup_printf ("Found %d distinct pins in slots\n",
- s_current->numslotpins);
- s_current->info_messages = g_list_append(s_current->info_messages,
- message);
-
+
+ if (errors_found) {
+ message = g_strdup_printf(
+ "Malformed slotdef= (the format is #:#,#,#,...)\n");
+ s_current->error_messages = g_list_append(s_current->error_messages,
+ message);
+ s_current->error_count++;
+ s_current->slotting_errors++;
+ } else {
+ /* Now compare each pin with the rest */
+ s_current->numslotpins = 0;
+ for (i = 0; i < s_current->numslots; i++) {
+ for (n = 1; n <= s_current->numpins; n++) {
+ /* Get the number of one pin */
+ pin = u_basic_breakup_string(pinlist[i], ',', n);
+ if (pin && *pin) {
+ match = FALSE;
+ for (j = i - 1; j >= 0 && !match; j--) {
+ for (m = 1; m <= s_current->numpins && !match; m++) {
+ /* Get the number of the other pin */
+ cmp = u_basic_breakup_string(pinlist[j], ',', m);
+ if (cmp && *cmp) {
+ match = (0 == strcmp (pin, cmp));
+ g_free(cmp);
+ }
+ }
+ }
+ if (!match) {
+ /* If they don't match, then increase the number of pins */
+ s_current->numslotpins++;
+ }
+ g_free(pin);
+ }
+ }
+ }
+ message = g_strdup_printf ("Found %d distinct pins in slots\n",
+ s_current->numslotpins);
+ s_current->info_messages = g_list_append(s_current->info_messages,
+ message);
+ }
}
if (slotdef) {
commit fb89def49fc33f71444cb625b3a26c8d754dd761
Author: Ales Hvezda <ahvezda@xxxxxxxx>
Date: Sun Jul 8 14:19:10 2007 -0400
Fixed up comments in the update script to what works and is used when updating
diff --git a/update-changelogs.sh b/update-changelogs.sh
index 80b44ef..1313a6e 100755
--- a/update-changelogs.sh
+++ b/update-changelogs.sh
@@ -3,10 +3,10 @@
# ./update-changelogs.sh <options>
# Updates ChangeLog files.
#
-# e.g. if the main gEDA branch is called origin, then to update all
+# e.g. if the main gEDA branch is called master, then to update all
# ChangeLogs with revisions since the switch to git, do:
#
-# ./update-changelogs.sh 1.0-20070526..origin
+# ./update-changelogs.sh 1.0-20070526..master
#
# This should be only be run while preparing a release, in order to
# ensure that the released tarballs contain change logs which can be
_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs