[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

gEDA-cvs: gaf.git: branch: master updated (1.7.1-20110619-168-g08f64a8)



The branch, master has been updated
       via  08f64a801c3af30ef54861f3549f3de6ea02b1b2 (commit)
       via  a2cdb3d2e2ed36be092f01a2c1c30de0eb095092 (commit)
      from  76bc345ee043764b919980c3de6d27f78546cf73 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


=========
 Summary
=========

 libgeda/include/libgeda_priv.h |    1 +
 libgeda/src/g_rc.c             |    2 ++
 2 files changed, 3 insertions(+), 0 deletions(-)


=================
 Commit Messages
=================

commit 08f64a801c3af30ef54861f3549f3de6ea02b1b2
Author: Karl Hammar <karl@xxxxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>

    libgeda: g_access() needs <glib/gstdio.h>.
    
    Commit 22985618d999e1b54009b7a3e4f07b27b449f91d added g_access calls
    in libgeda/src/f_basic.c, which is implicit unless glib/gstdio.h is
    included.

:100644 100644 ccd1731... d5d5d4d... M	libgeda/include/libgeda_priv.h

commit a2cdb3d2e2ed36be092f01a2c1c30de0eb095092
Author: Karl Hammar <karl@xxxxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>

    libgeda: Call g_dir_close() for pointers created with g_dir_open().
    
    In g_rc.c
    
     g_rc_component_library_search()
     g_rc_source_library_search()
    
    calls g_dir_open(), but they never free the result with g_dir_close(),
    giving us a memory leak. It seems to been this way since the first
    commit.

:100644 100644 65c3778... f3e675d... M	libgeda/src/g_rc.c

=========
 Changes
=========

commit 08f64a801c3af30ef54861f3549f3de6ea02b1b2
Author: Karl Hammar <karl@xxxxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>

    libgeda: g_access() needs <glib/gstdio.h>.
    
    Commit 22985618d999e1b54009b7a3e4f07b27b449f91d added g_access calls
    in libgeda/src/f_basic.c, which is implicit unless glib/gstdio.h is
    included.

diff --git a/libgeda/include/libgeda_priv.h b/libgeda/include/libgeda_priv.h
index ccd1731..d5d5d4d 100644
--- a/libgeda/include/libgeda_priv.h
+++ b/libgeda/include/libgeda_priv.h
@@ -3,6 +3,7 @@
 #include <glib-object.h>
 #include <libguile.h>
 #include <gdk-pixbuf/gdk-pixbuf.h>
+#include <glib/gstdio.h>
 
 /* Public libgeda headers */
 #include "defines.h"

commit a2cdb3d2e2ed36be092f01a2c1c30de0eb095092
Author: Karl Hammar <karl@xxxxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>

    libgeda: Call g_dir_close() for pointers created with g_dir_open().
    
    In g_rc.c
    
     g_rc_component_library_search()
     g_rc_source_library_search()
    
    calls g_dir_open(), but they never free the result with g_dir_close(),
    giving us a memory leak. It seems to been this way since the first
    commit.

diff --git a/libgeda/src/g_rc.c b/libgeda/src/g_rc.c
index 65c3778..f3e675d 100644
--- a/libgeda/src/g_rc.c
+++ b/libgeda/src/g_rc.c
@@ -601,6 +601,7 @@ SCM g_rc_component_library_search(SCM path)
   }
 
   g_free(string);
+  g_dir_close(dir);
 
   return SCM_BOOL_T;
 }
@@ -717,6 +718,7 @@ SCM g_rc_source_library_search(SCM path)
   }
 
   g_free(string);
+  g_dir_close(dir);
 
   return SCM_BOOL_T;
 }




_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs