gEDA-cvs: pcb.git: branch: master updated (bcc3073b4df5452e027f56b820107f99912b1106)

[git@xxxxxxxxxx]

The branch, master has been updated
       via  bcc3073b4df5452e027f56b820107f99912b1106 (commit)
      from  93577465317687486e0ba7b0f08d2277e3548779 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


=========
 Summary
=========

 src/hid/common/actions.c  |    3 ++-
 src/hid/gtk/gtkhid-main.c |    4 ++--
 src/hid/lesstif/main.c    |    4 ++--
 3 files changed, 6 insertions(+), 5 deletions(-)


=================
 Commit Messages
=================

commit bcc3073b4df5452e027f56b820107f99912b1106
Author: Jared A. Casper <jcasper@xxxxxxxxxxxxxxxxxxxx>
Commit: DJ Delorie <dj@xxxxxxxxxxx>

    Fix command line exporting.
    
    Previously, hid_actionv was changed to always call gui->get_coords
    wether or not the action had a need_coord_msg, in an attempt to always
    get the latest coords for things like zoom or pan that didn't have a
    need_coord_msg.  However, this broke command line exporting because it
    was trying to call get_coords on the nogui hid.
    
    Added the check back in to only call gui->get_coords when the action
    has a need_coord_msg and added need_coord_msg's to actions that need
    coords.

:100644 100644 1829af6... 0f2dfb4... M	src/hid/common/actions.c
:100644 100644 bac3e0e... d8f4b91... M	src/hid/gtk/gtkhid-main.c
:100644 100644 d58202e... cc0055f... M	src/hid/lesstif/main.c

=========
 Changes
=========

commit bcc3073b4df5452e027f56b820107f99912b1106
Author: Jared A. Casper <jcasper@xxxxxxxxxxxxxxxxxxxx>
Commit: DJ Delorie <dj@xxxxxxxxxxx>

    Fix command line exporting.
    
    Previously, hid_actionv was changed to always call gui->get_coords
    wether or not the action had a need_coord_msg, in an attempt to always
    get the latest coords for things like zoom or pan that didn't have a
    need_coord_msg.  However, this broke command line exporting because it
    was trying to call get_coords on the nogui hid.
    
    Added the check back in to only call gui->get_coords when the action
    has a need_coord_msg and added need_coord_msg's to actions that need
    coords.

diff --git a/src/hid/common/actions.c b/src/hid/common/actions.c
index 1829af6..0f2dfb4 100644
--- a/src/hid/common/actions.c
+++ b/src/hid/common/actions.c
@@ -302,7 +302,8 @@ hid_actionv (const char *name, int argc, char **argv)
   a = hid_find_action (name, &context);
   if (!a)
     return 1;
-  gui->get_coords (a->need_coord_msg, &x, &y);
+  if (a->need_coord_msg)
+    gui->get_coords (a->need_coord_msg, &x, &y);
 
   /* save old action context and set it to the context associated with the action */
   old_context = hid_action_context;
diff --git a/src/hid/gtk/gtkhid-main.c b/src/hid/gtk/gtkhid-main.c
index bac3e0e..d8f4b91 100644
--- a/src/hid/gtk/gtkhid-main.c
+++ b/src/hid/gtk/gtkhid-main.c
@@ -2662,7 +2662,7 @@ HID_Action ghid_main_action_list[] = {
   {"LayerGroupsChanged", 0, LayerGroupsChanged},
   {"LibraryChanged", 0, LibraryChanged},
   {"Load", 0, Load},
-  {"Pan", 0, PanAction, pan_help, pan_syntax},
+  {"Pan", "Click on a place to pan", PanAction, pan_help, pan_syntax},
   {"PCBChanged", 0, PCBChanged},
   {"PointCursor", 0, PointCursor},
   {"Popup", 0, Popup, popup_help, popup_syntax},
@@ -2672,7 +2672,7 @@ HID_Action ghid_main_action_list[] = {
    printcalibrate_help, printcalibrate_syntax},
   {"RouteStylesChanged", 0, RouteStylesChanged},
   {"Save", 0, Save, save_help, save_syntax},
-  {"Scroll", 0, ScrollAction, scroll_help, scroll_syntax},
+  {"Scroll", "Click on a place to scroll", ScrollAction, scroll_help, scroll_syntax},
   {"SetUnits", 0, SetUnits, setunits_help, setunits_syntax},
   {"SwapSides", 0, SwapSides, swapsides_help, swapsides_syntax},
   {"Zoom", "Click on zoom focus", Zoom, zoom_help, zoom_syntax}
diff --git a/src/hid/lesstif/main.c b/src/hid/lesstif/main.c
index d58202e..cc0055f 100644
--- a/src/hid/lesstif/main.c
+++ b/src/hid/lesstif/main.c
@@ -923,9 +923,9 @@ HID_Action lesstif_main_action_list[] = {
    pcbchanged_help, pcbchanged_syntax},
   {"SetUnits", 0, SetUnits,
    setunits_help, setunits_syntax},
-  {"Zoom", 0, ZoomAction,
+  {"Zoom", "Click on a place to zoom in", ZoomAction,
    zoom_help, zoom_syntax},
-  {"Pan", 0, PanAction,
+  {"Pan", "Click on a place to pan", PanAction,
    zoom_help, zoom_syntax},
   {"SwapSides", 0, SwapSides,
    swapsides_help, swapsides_syntax},




_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs