gEDA-cvs: gaf.git: branch: master updated (1.5.2-20090328-25-g19d6f81)

[git@xxxxxxxxxx]

The branch, master has been updated
       via  19d6f815561d0cf903a648bcc96fac67d76d5f96 (commit)
       via  25b533762889d5eba3302f95c393ba4a91c0d7a4 (commit)
      from  932c71ec1b93d9a7e2b833039c75ab987b4956e5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


=========
 Summary
=========

 libgeda/src/o_attrib.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)


=================
 Commit Messages
=================

commit 19d6f815561d0cf903a648bcc96fac67d76d5f96
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    libgeda: Plug leak in o_attrib_return_attribs() (CODE!!)
    
    We don't need to retrieve the attribute's name whilst validating it,
    nor do we need to leave that name un-freed!

:100644 100644 56e79a1... ff1f411... M	libgeda/src/o_attrib.c

=========
 Changes
=========

commit 19d6f815561d0cf903a648bcc96fac67d76d5f96
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    libgeda: Plug leak in o_attrib_return_attribs() (CODE!!)
    
    We don't need to retrieve the attribute's name whilst validating it,
    nor do we need to leave that name un-freed!

diff --git a/libgeda/src/o_attrib.c b/libgeda/src/o_attrib.c
index 56e79a1..ff1f411 100644
--- a/libgeda/src/o_attrib.c
+++ b/libgeda/src/o_attrib.c
@@ -1448,7 +1448,6 @@ GList * o_attrib_return_attribs (OBJECT *object)
   GList *attribs = NULL;
   OBJECT *a_current;
   GList *a_iter;
-  char *name;
 
   g_return_val_if_fail (object != NULL, NULL);
 
@@ -1461,7 +1460,7 @@ GList * o_attrib_return_attribs (OBJECT *object)
       continue;
 
     /* Don't add invalid attributes to the list */
-    if (!o_attrib_get_name_value (a_current->text->string, &name, NULL))
+    if (!o_attrib_get_name_value (a_current->text->string, NULL, NULL))
       continue;
 
     attribs = g_list_prepend (attribs, a_current);




_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs