gEDA-cvs: pcb.git: branch: master updated (9b760b0d62ec4b62ef3b4d5e4ae35e52af38ed39)

[git@xxxxxxxxxx]

The branch, master has been updated
       via  9b760b0d62ec4b62ef3b4d5e4ae35e52af38ed39 (commit)
       via  8be2d618a3e686925ee15c8183831f2f87b1a8a7 (commit)
      from  9147c5bcd6293739a53c9a76c552cff9482b429f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


=========
 Summary
=========

 src/hid/gtk/gtkhid-gdk.c |   11 +++++++----
 1 files changed, 7 insertions(+), 4 deletions(-)


=================
 Commit Messages
=================

commit 9b760b0d62ec4b62ef3b4d5e4ae35e52af38ed39
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    hid/gtk: Fix conversion from world to screen in ghid_invalidate_lr
    
    I accidentally muddled the Vx and Vy conversions routines for the right
    and top coordinates. In general, this resulted in the incorrect region
    being invalidated - manifesting as artaefacts on the the screen, such as
    when dragging objects around.
    
    Also drop the (double) cast.. having checked, Vx and Vy take integer
    arguments. I'm not sure why the rest of this file casts to double.

:100644 100644 0b0b157... 4534905... M	src/hid/gtk/gtkhid-gdk.c

commit 8be2d618a3e686925ee15c8183831f2f87b1a8a7
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    hid/gtk: Rest clip region for bg_gc, as it is used for expose events.
    
    We set the clip region in the redraw_region() function to clip drawing
    to the area which we intend to repaint, but we did not clear the clip
    again.
    
    This caused expose events to be clipped to the last redraw area rather
    than the required damaged area.

:100644 100644 64a12a8... 0b0b157... M	src/hid/gtk/gtkhid-gdk.c

=========
 Changes
=========

commit 9b760b0d62ec4b62ef3b4d5e4ae35e52af38ed39
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    hid/gtk: Fix conversion from world to screen in ghid_invalidate_lr
    
    I accidentally muddled the Vx and Vy conversions routines for the right
    and top coordinates. In general, this resulted in the incorrect region
    being invalidated - manifesting as artaefacts on the the screen, such as
    when dragging objects around.
    
    Also drop the (double) cast.. having checked, Vx and Vy take integer
    arguments. I'm not sure why the rest of this file casts to double.

diff --git a/src/hid/gtk/gtkhid-gdk.c b/src/hid/gtk/gtkhid-gdk.c
index 0b0b157..4534905 100644
--- a/src/hid/gtk/gtkhid-gdk.c
+++ b/src/hid/gtk/gtkhid-gdk.c
@@ -800,10 +800,10 @@ ghid_invalidate_lr (int left, int right, int top, int bottom)
   int minx, maxx, miny, maxy;
   GdkRectangle rect;
 
-  dleft = Vx ((double) left);
-  dright = Vy ((double) right);
-  dtop = Vx ((double) top);
-  dbottom = Vy ((double) bottom);
+  dleft = Vx (left);
+  dright = Vx (right);
+  dtop = Vy (top);
+  dbottom = Vy (bottom);
 
   minx = MIN (dleft, dright);
   maxx = MAX (dleft, dright);

commit 8be2d618a3e686925ee15c8183831f2f87b1a8a7
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    hid/gtk: Rest clip region for bg_gc, as it is used for expose events.
    
    We set the clip region in the redraw_region() function to clip drawing
    to the area which we intend to repaint, but we did not clear the clip
    again.
    
    This caused expose events to be clipped to the last redraw area rather
    than the required damaged area.

diff --git a/src/hid/gtk/gtkhid-gdk.c b/src/hid/gtk/gtkhid-gdk.c
index 64a12a8..0b0b157 100644
--- a/src/hid/gtk/gtkhid-gdk.c
+++ b/src/hid/gtk/gtkhid-gdk.c
@@ -788,6 +788,9 @@ redraw_region (GdkRectangle *rect)
     DrawMark ();
 
   priv->clip = false;
+
+  /* Rest the clip for bg_gc, as it is used outside this function */
+  gdk_gc_set_clip_mask (priv->bg_gc, NULL);
 }
 
 void




_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs