gEDA-cvs: pcb.git: branch: master updated (515f6d3967aba780f056e79879eac1c1cca4fd1c)

[git@xxxxxxxxxx]

The branch, master has been updated
       via  515f6d3967aba780f056e79879eac1c1cca4fd1c (commit)
       via  93cc00394d1d1b4f106103d98df3e1795c0ea353 (commit)
      from  b3903db46402e65d6f26a18857e818bb7acec428 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


=========
 Summary
=========

 src/hid/common/actions.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)


=================
 Commit Messages
=================

commit 515f6d3967aba780f056e79879eac1c1cca4fd1c
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    hid/common: Fix dereference bug in hid_find_action().
    
    We want to check context for being NULL, not *context.

:100644 100644 4bd886b... 8678ad9... M	src/hid/common/actions.c

commit 93cc00394d1d1b4f106103d98df3e1795c0ea353
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    hid/common: Don't walk off end of string whilst parsing.
    
    Fixed a bug where the action parser would walk off the end of a
    string when given an action without a "(" in it, e.g. "benchmark".

:100644 100644 0256772... 4bd886b... M	src/hid/common/actions.c

=========
 Changes
=========

commit 515f6d3967aba780f056e79879eac1c1cca4fd1c
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    hid/common: Fix dereference bug in hid_find_action().
    
    We want to check context for being NULL, not *context.

diff --git a/src/hid/common/actions.c b/src/hid/common/actions.c
index 4bd886b..8678ad9 100644
--- a/src/hid/common/actions.c
+++ b/src/hid/common/actions.c
@@ -180,7 +180,7 @@ hid_find_action (const char *name, void **context)
 
   for (i = 0; i < n_actions; i++)
     if (strcasecmp (all_actions[i].action.name, name) == 0) {
-      if (*context != NULL)
+      if (context != NULL)
         *context = all_actions[i].context;
       return &(all_actions[i].action);
     }

commit 93cc00394d1d1b4f106103d98df3e1795c0ea353
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    hid/common: Don't walk off end of string whilst parsing.
    
    Fixed a bug where the action parser would walk off the end of a
    string when given an action without a "(" in it, e.g. "benchmark".

diff --git a/src/hid/common/actions.c b/src/hid/common/actions.c
index 0256772..4bd886b 100644
--- a/src/hid/common/actions.c
+++ b/src/hid/common/actions.c
@@ -358,7 +358,8 @@ another:
   while (*sp && *sp != '(')
     *cp++ = *sp++;
   *cp++ = 0;
-  sp++;
+  if (*sp)
+    sp++;
 
   /*
    * we didn't find a leading ( so invoke the action




_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs