gEDA-cvs: pcb.git: branch: master updated (c1df6f7725601489a1562811ffc0c717a56445f5)

[git@xxxxxxxxxx]

The branch, master has been updated
       via  c1df6f7725601489a1562811ffc0c717a56445f5 (commit)
      from  09020e6a57e5e9b901b125ab6c818d626b9f92a5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


=========
 Summary
=========

 src/action.c   |    2 +-
 src/create.c   |    2 ++
 src/strflags.c |    1 +
 3 files changed, 4 insertions(+), 1 deletions(-)


=================
 Commit Messages
=================

commit c1df6f7725601489a1562811ffc0c717a56445f5
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    Fix "newfullpoly" flag test and save its state into the .pcb file.
    
    The flag controlling this behaviour is kept up to date as a PCB flag,
    not something which is updated in Settings.FullPoly. Change the test
    accordingly.
    
    Added a PCB flag "newfullpoly" to save this state in the .pcb file.
    
    NOTE: "full" polygons severly break connectivity checking, as the code
          always treats broken up pieces of the polygon as being connected.
    
          It _might_ have been better to leave this support broken - so
          users don't inadvertently create polygons with the "fullpoly" flag.
    
    TODO: Consider removing, hiding or adding warnings to this feature.

:100644 100644 92fdbae... 6b979d3... M	src/action.c
:100644 100644 fc6b863... 6d34465... M	src/create.c
:100644 100644 c2073a5... ac1fdcc... M	src/strflags.c

=========
 Changes
=========

commit c1df6f7725601489a1562811ffc0c717a56445f5
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    Fix "newfullpoly" flag test and save its state into the .pcb file.
    
    The flag controlling this behaviour is kept up to date as a PCB flag,
    not something which is updated in Settings.FullPoly. Change the test
    accordingly.
    
    Added a PCB flag "newfullpoly" to save this state in the .pcb file.
    
    NOTE: "full" polygons severly break connectivity checking, as the code
          always treats broken up pieces of the polygon as being connected.
    
          It _might_ have been better to leave this support broken - so
          users don't inadvertently create polygons with the "fullpoly" flag.
    
    TODO: Consider removing, hiding or adding warnings to this feature.

diff --git a/src/action.c b/src/action.c
index 92fdbae..6b979d3 100644
--- a/src/action.c
+++ b/src/action.c
@@ -1342,7 +1342,7 @@ NotifyMode (void)
 	  PolygonTypePtr polygon;
 
 	  int flags = CLEARPOLYFLAG;
-	  if (Settings.FullPoly)
+	  if (TEST_FLAG (NEWFULLPOLYFLAG, PCB))
 	    flags |= FULLPOLYFLAG;
 	  if ((polygon = CreateNewPolygonFromRectangle (CURRENT,
 							Crosshair.
diff --git a/src/create.c b/src/create.c
index fc6b863..6d34465 100644
--- a/src/create.c
+++ b/src/create.c
@@ -160,6 +160,8 @@ CreateNewPCB (Boolean SetDefaultNames)
     SET_FLAG (SNAPPINFLAG, ptr);
   if (Settings.ClearLine)
     SET_FLAG (CLEARNEWFLAG, ptr);
+  if (Settings.FullPoly)
+    SET_FLAG (NEWFULLPOLYFLAG, ptr);
   if (Settings.OrthogonalMoves)
     SET_FLAG (ORTHOMOVEFLAG, ptr);
   if (Settings.liveRouting)
diff --git a/src/strflags.c b/src/strflags.c
index c2073a5..ac1fdcc 100644
--- a/src/strflags.c
+++ b/src/strflags.c
@@ -127,6 +127,7 @@ static FlagBitsType pcb_flagbits[] = {
   { SWAPSTARTDIRFLAG, N ("swapstartdir"), 1 },
   { UNIQUENAMEFLAG, N ("uniquename"), 1 },
   { CLEARNEWFLAG, N ("clearnew"), 1 },
+  { NEWFULLPOLYFLAG, N ("newfullpoly"), 1 },
   { SNAPPINFLAG, N ("snappin"), 1 },
   { SHOWMASKFLAG, N ("showmask"), 1 },
   { THINDRAWFLAG, N ("thindraw"), 1 },




_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs