gEDA-cvs: pcb.git: branch: master updated (50191bb771950ba3ab0dd7628b3380208e6db743)

[git@xxxxxxxxxx]

The branch, master has been updated
       via  50191bb771950ba3ab0dd7628b3380208e6db743 (commit)
      from  b8cd62ae33d2473ff73416dd9c387bb542c1c070 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


=========
 Summary
=========

 src/polygon1.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


=================
 Commit Messages
=================

commit 50191bb771950ba3ab0dd7628b3380208e6db743
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    Fix bug with polygon boolean operation PBO_XOR (I think!)
    
    If the contour in A is outside of B, it should be kept. It seems
    this case may have been missed.
    
    PCB does not use the PBO_XOR operation, so it is difficult to test
    whether this is correct or not.

:100644 100644 8170197... d27c255... M	src/polygon1.c

=========
 Changes
=========

commit 50191bb771950ba3ab0dd7628b3380208e6db743
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    Fix bug with polygon boolean operation PBO_XOR (I think!)
    
    If the contour in A is outside of B, it should be kept. It seems
    this case may have been missed.
    
    PCB does not use the PBO_XOR operation, so it is difficult to test
    whether this is correct or not.

diff --git a/src/polygon1.c b/src/polygon1.c
index 8170197..d27c255 100644
--- a/src/polygon1.c
+++ b/src/polygon1.c
@@ -1522,7 +1522,7 @@ cntr_Collect (jmp_buf * e, PLINE ** A, POLYAREA ** contours, PLINE ** holes,
 	      PutContour (e, tmprev, contours, holes, NULL);
 	      return TRUE;
 	    }
-	  break;
+	  /* break; */ /* Fall through (I think this is correct! pcjc2) */
 	case PBO_UNITE:
 	case PBO_SUB:
 	  if ((*A)->Flags.status == OUTSIDE)




_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs