[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
gEDA-cvs: gaf.git: branch: master updated (1.6.1-20100214-143-g019990c)
The branch, master has been updated
via 019990c574e3806c566d18ad1548c76d979eb37f (commit)
via 9410bf545fce0db3bdeb4bee547d855b09c9c671 (commit)
via 7fdc71ea471ab0ff89932d49f92436c62f2a8882 (commit)
via e25d29875ecd1438926d0ec79279c177edcf99f0 (commit)
via af272ebddf16808aa948378d269a1f5c19220754 (commit)
via dd1fe705e38e99075d2d02c53e94fcae6ba02158 (commit)
from 9d129b1ed3f923f6357c4afd410e576782dc00e3 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
=========
Summary
=========
HACKING | 67 +++++++++++++++++++++++++++++
Makefile.am | 2 +-
gnetlist/scheme/gnet-partslist-common.scm | 2 +-
gnetlist/scripts/sch2eaglepos.sh | 8 ++--
gnetlist/src/globals.c | 2 +-
gnetlist/src/gnetlist.c | 6 +--
libgeda/src/g_smob.c | 8 ++--
utils/scripts/garchive.py | 10 ++--
8 files changed, 85 insertions(+), 20 deletions(-)
create mode 100644 HACKING
=================
Commit Messages
=================
commit 019990c574e3806c566d18ad1548c76d979eb37f
Author: Patrick Bernaud <patrickb@xxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>
libgeda: Check attribute string before requesting name/value [3032626]
:100644 100644 fb4e050... ea0980f... M libgeda/src/g_smob.c
commit 9410bf545fce0db3bdeb4bee547d855b09c9c671
Author: Ø£ØÙ?د اÙ?Ù?ØÙ?Ù?دÙ? (Ahmed El-Mahmoudy) <aelmahmoudy@xxxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>
gnetlist: Fix bashism in sch2eaglepos.sh [2999951]
Note that even with #!/bin/bash the original code gave the error that 3 is an
invalid file descriptor.
:100755 100755 df835eb... 5f098a7... M gnetlist/scripts/sch2eaglepos.sh
commit 7fdc71ea471ab0ff89932d49f92436c62f2a8882
Author: Ø£ØÙ?د اÙ?Ù?ØÙ?Ù?دÙ? (Ahmed El-Mahmoudy) <aelmahmoudy@xxxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>
utils: Don't use string exceptions in Python code. [3014181]
utils/scripts/garchive.py uses string exceptions which have been deprecated in
Python 2.5, and has been removed in Python 2.6. The attached patch fixes this
issue.
:100644 100644 15d97e5... 58446a3... M utils/scripts/garchive.py
commit e25d29875ecd1438926d0ec79279c177edcf99f0
Author: Richard Barlow <richardbarlow@xxxxxxxxxxxxxxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>
gnetlist: Handle hierarchy refdes correctly in partslist*. [3044478]
When producing a part list with the partslist[1-3] backend the refdes
values output to the file do not contain the prepended refdeses of the
parent component.
E.g.
Master schematic with symbol 'S1' (representing sub-schematic) and a
resistor 'R1' Sub-schematic containing resistor 'R1'
The geda backend produces a netlist containing two resistors 'R1' and
'S1/R1', they're unique and everything is fine and dandy. The
partslist[1-3] backends contain two components with the refdes 'R1'
which then causes problems when processing this file further.
This is caused by the partslist[1-3] backends adding the value of the
refdes attribute to the file rather than the value returned by the
'packages' function.
The supplied patch alters the backends to use the value from the
packages function directly, rather than looking up the refdes
attribute of the component.
:100644 100644 943b28e... eac539e... M gnetlist/scheme/gnet-partslist-common.scm
commit af272ebddf16808aa948378d269a1f5c19220754
Author: Sebastian Gieltjes <bas@xxxxxxxxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>
gnetlist: Modified commandline string generation [3071449]
Every netlister is able to request the invoked commandline and
now gets a valid string in return. Removed a debug output command.
:100644 100644 99d1b41... 839ab72... M gnetlist/src/globals.c
:100644 100644 9b51b7b... faa63e4... M gnetlist/src/gnetlist.c
commit dd1fe705e38e99075d2d02c53e94fcae6ba02158
Author: Peter TB Brett <peter@xxxxxxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>
Add a HACKING file with info on how to submit patches.
It's been argued that gEDA's patch submission process is poorly
documented. This patch attempts to document it. (At some point the
HACKING file should also contain info on the coding style, etc).
:000000 100644 0000000... ee88407... A HACKING
:100644 100644 cad558a... c83837d... M Makefile.am
=========
Changes
=========
commit 019990c574e3806c566d18ad1548c76d979eb37f
Author: Patrick Bernaud <patrickb@xxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>
libgeda: Check attribute string before requesting name/value [3032626]
diff --git a/libgeda/src/g_smob.c b/libgeda/src/g_smob.c
index fb4e050..ea0980f 100644
--- a/libgeda/src/g_smob.c
+++ b/libgeda/src/g_smob.c
@@ -128,8 +128,8 @@ SCM g_get_attrib_name_value(SCM attrib_smob)
attribute = (struct st_attrib_smob *)SCM_CDR(attrib_smob);
if (attribute != NULL &&
- attribute->attribute != NULL) {
- o_attrib_get_name_value (attribute->attribute, &name, &value );
+ attribute->attribute != NULL &&
+ o_attrib_get_name_value (attribute->attribute, &name, &value)) {
returned = scm_cons (scm_makfrom0str (name),
scm_makfrom0str (value));
g_free(name);
@@ -576,8 +576,8 @@ SCM g_get_attrib_value_by_attrib_name(SCM object_smob, SCM scm_attrib_name)
a_iter = object->object->attribs;
while (a_iter != NULL) {
a_current = a_iter->data;
- if (a_current != NULL) {
- o_attrib_get_name_value (a_current, &name, &value );
+ if (a_current != NULL &&
+ o_attrib_get_name_value (a_current, &name, &value)) {
if (strcmp(name, attrib_name) == 0)
returned = scm_cons (scm_makfrom0str (value), returned);
g_free (name);
commit 9410bf545fce0db3bdeb4bee547d855b09c9c671
Author: Ø£ØÙ?د اÙ?Ù?ØÙ?Ù?دÙ? (Ahmed El-Mahmoudy) <aelmahmoudy@xxxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>
gnetlist: Fix bashism in sch2eaglepos.sh [2999951]
Note that even with #!/bin/bash the original code gave the error that 3 is an
invalid file descriptor.
diff --git a/gnetlist/scripts/sch2eaglepos.sh b/gnetlist/scripts/sch2eaglepos.sh
index df835eb..5f098a7 100755
--- a/gnetlist/scripts/sch2eaglepos.sh
+++ b/gnetlist/scripts/sch2eaglepos.sh
@@ -43,16 +43,16 @@ fi
tmpf=${tmpdir}/tmpf
grep -B1 refdes= "$FNAME" |sed 's/=/ /' | cut -d" " -f2,3 |grep -v '^--' >${tmpf}
-3<$tmpf
-while read -u 3; do
+
+while read; do
# the directory on the client to backup
X=`echo $REPLY | cut -d' ' -f1`
Y=`echo $REPLY | cut -d' ' -f2`
- read -u 3;
+ read;
PART="$REPLY"
X=`echo "scale=5; ($X - $XOFFSET) / $XSCALE" |bc`
Y=`echo "scale=5; ($Y - $YOFFSET) / $YSCALE" |bc`
echo "MOVE '$PART' ($X $Y);"
-done
+done < $tmpf
rm -fr "${tmpdir}"
commit 7fdc71ea471ab0ff89932d49f92436c62f2a8882
Author: Ø£ØÙ?د اÙ?Ù?ØÙ?Ù?دÙ? (Ahmed El-Mahmoudy) <aelmahmoudy@xxxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>
utils: Don't use string exceptions in Python code. [3014181]
utils/scripts/garchive.py uses string exceptions which have been deprecated in
Python 2.5, and has been removed in Python 2.6. The attached patch fixes this
issue.
diff --git a/utils/scripts/garchive.py b/utils/scripts/garchive.py
index 15d97e5..58446a3 100644
--- a/utils/scripts/garchive.py
+++ b/utils/scripts/garchive.py
@@ -275,15 +275,15 @@ class CmdLineArgs:
if Option == '-a':
if self.ProgramMode == "extract": # sanity check
- raise "Incompatible command line args"
+ raise SyntaxError("Incompatible command line args")
if Option == '-e':
if self.ProgramMode == "archive": # sanity check
- raise "Incompatible command line args"
+ raise SyntaxError("Incompatible command line args")
if Option == '-f':
if self.ProgramMode == "extract": # sanity check
- raise "Incompatible command line args"
+ raise SyntaxError("Incompatible command line args")
try:
os.stat(Value)
except OSError:
@@ -294,7 +294,7 @@ class CmdLineArgs:
if Option == '-o':
if self.ProgramMode == "extract": # sanity check
- raise "incompatible command line args"
+ raise SyntaxError("Incompatible command line args")
if CheckFilename(Value):
self.OutputFileName = Value #strcopy?
else:
@@ -904,7 +904,7 @@ elif Args.ProgramMode == "extract":
Extract(Args)
sys.exit(0)
else:
- raise "Unknown program mode found."
+ raise RuntimeError("Unknown program mode found.")
# That's it -- very simple!!
commit e25d29875ecd1438926d0ec79279c177edcf99f0
Author: Richard Barlow <richardbarlow@xxxxxxxxxxxxxxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>
gnetlist: Handle hierarchy refdes correctly in partslist*. [3044478]
When producing a part list with the partslist[1-3] backend the refdes
values output to the file do not contain the prepended refdeses of the
parent component.
E.g.
Master schematic with symbol 'S1' (representing sub-schematic) and a
resistor 'R1' Sub-schematic containing resistor 'R1'
The geda backend produces a netlist containing two resistors 'R1' and
'S1/R1', they're unique and everything is fine and dandy. The
partslist[1-3] backends contain two components with the refdes 'R1'
which then causes problems when processing this file further.
This is caused by the partslist[1-3] backends adding the value of the
refdes attribute to the file rather than the value returned by the
'packages' function.
The supplied patch alters the backends to use the value from the
packages function directly, rather than looking up the refdes
attribute of the component.
diff --git a/gnetlist/scheme/gnet-partslist-common.scm b/gnetlist/scheme/gnet-partslist-common.scm
index 943b28e..eac539e 100644
--- a/gnetlist/scheme/gnet-partslist-common.scm
+++ b/gnetlist/scheme/gnet-partslist-common.scm
@@ -21,7 +21,7 @@
(let ((package (car packages)))
(if (string=? (get-device package) "include")
(get-parts-table (cdr packages))
- (cons (list (gnetlist:get-package-attribute package "refdes")
+ (cons (list package
(get-device package)
(get-value package)
(gnetlist:get-package-attribute package "footprint")) ;; sdb change
commit af272ebddf16808aa948378d269a1f5c19220754
Author: Sebastian Gieltjes <bas@xxxxxxxxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>
gnetlist: Modified commandline string generation [3071449]
Every netlister is able to request the invoked commandline and
now gets a valid string in return. Removed a debug output command.
diff --git a/gnetlist/src/globals.c b/gnetlist/src/globals.c
index 99d1b41..839ab72 100644
--- a/gnetlist/src/globals.c
+++ b/gnetlist/src/globals.c
@@ -64,7 +64,7 @@ GSList *pre_backend_list=NULL;
GSList *post_backend_list=NULL;
/* String holding command line */
-char *command_line;
+char *command_line = NULL;
/* Parameters passed to the backend from the command line */
GSList *backend_params = NULL;
diff --git a/gnetlist/src/gnetlist.c b/gnetlist/src/gnetlist.c
index 9b51b7b..faa63e4 100644
--- a/gnetlist/src/gnetlist.c
+++ b/gnetlist/src/gnetlist.c
@@ -122,6 +122,8 @@ void main_prog(void *closure, int argc, char *argv[])
argv_index = parse_commandline(argc, argv);
cwd = g_get_current_dir();
+ command_line = create_command_line(argc, argv);
+
/* this is a kludge to make sure that spice mode gets set */
/* Hacked by SDB to allow spice netlisters of arbitrary name
* as long as they begin with "spice". For example, this spice
@@ -130,10 +132,6 @@ void main_prog(void *closure, int argc, char *argv[])
if (guile_proc) {
if (strncmp(guile_proc, "spice", 5) == 0) {
netlist_mode = SPICE;
- command_line = create_command_line(argc, argv);
-
- printf("Command line passed = %s \n", command_line);
-
}
}
commit dd1fe705e38e99075d2d02c53e94fcae6ba02158
Author: Peter TB Brett <peter@xxxxxxxxxxxxx>
Commit: Peter TB Brett <peter@xxxxxxxxxxxxx>
Add a HACKING file with info on how to submit patches.
It's been argued that gEDA's patch submission process is poorly
documented. This patch attempts to document it. (At some point the
HACKING file should also contain info on the coding style, etc).
diff --git a/HACKING b/HACKING
new file mode 100644
index 0000000..ee88407
--- /dev/null
+++ b/HACKING
@@ -0,0 +1,67 @@
+==============================================
+ 'gschem and Friends' Electronic Design Suite
+==============================================
+
+Copyright (C) 1998-2010 gEDA Developers
+
+This file contains information which you may find useful if you wish
+to contribute to gEDA.
+
+How to submit patches
+=====================
+
+Please submit patches to the patch tracker on SourceForge.net:
+
+ <https://sourceforge.net/tracker/?group_id=161080&atid=818428>
+
+Once you've submitted your patches, you may wish to also e-mail the
+`gEDA-user' mailing list to announce that you've done so and to ask
+for feedback.
+
+To make it easier for developers to promptly verify your patches and
+integrate them, please try to follow the following guidelines:
+
+ - If your patch is big, try to split it up into a series of small,
+ logical steps, and use a separate patch for each.
+
+ - Avoid unnecessary whitespace changes. Please do not add trailing
+ whitespace.
+
+ - Ensure that each of your patches applies cleanly against the
+ `master' branch of the gaf main git repository.
+
+ - Please format your patches with `git format-patch', and ensure
+ that they contain good commit messages. The commit messages
+ should include:
+
+ * A one-line summary of what the patch changes.
+
+ * A detailed explanation of what the patch changes, the problem
+ it solves, and why you chose that approach to solving the
+ problem. Sometimes, the change will be very self-explanatory.
+ Sometimes, the commit message will be considerably longer than
+ the patch itself.
+
+ * If the patch is related to another ticket in the
+ SourceForge.net tracker (i.e. a bug or feature request),
+ include its tracker item number.
+
+ * If your patch fixes a regression, and you know which commit
+ introduced the regression, include the broken commit's ID.
+
+ - Make sure it's clear whether, and in what ways, you've tested your
+ patch.
+
+ - If you add functions, or change function definitions, make sure
+ that the doxygen comments are up-to-date.
+
+Sometimes, you may submit a patch and not hear anything back for a
+while. This can be for a number of reasons, and it's only very rarely
+that there's a great conspiracy of gEDA developers to obstruct your
+changes from getting included. It might even be that your patch has
+been committed, but the developer who did so forgot to let you know!
+If it's been more than a couple of weeks since you submitted a patch,
+you should e-mail the `gEDA-user' mailing list with a reminder.
+
+A final thought: to get your patches included, make it easy to accept
+them!
diff --git a/Makefile.am b/Makefile.am
index cad558a..c83837d 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -18,7 +18,7 @@ DISTCHECK_CONFIGURE_FLAGS = \
--disable-update-xdg-database
BUILT_SOURCES = version.h
-EXTRA_DIST = autogen.sh version.h version.h.in README.Cygwin
+EXTRA_DIST = autogen.sh version.h version.h.in README.Cygwin HACKING
# Generate version.h. This works by looking at any git repository that
# is present in the source directory (detected at configure time). If
_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs