gEDA-cvs: pcb.git: branch: master updated (76dbbd1b14b75f455ccd80166c9e3f3830ec609a)

[git@xxxxxxxxxx]

The branch, master has been updated
       via  76dbbd1b14b75f455ccd80166c9e3f3830ec609a (commit)
       via  4fa4c4be2ced2a5742f49373f6914a33bd2f845d (commit)
      from  e9f45c42af6fa5770186f44fb6be8a60f061dc93 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


=========
 Summary
=========

 src/find.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)


=================
 Commit Messages
=================

commit 76dbbd1b14b75f455ccd80166c9e3f3830ec609a
Author: Ineiev <ineiev@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    find.c: Add RATLINE_TYPE to switch statement in BuildObjectList
    
    Part of Ineiev's patch from:
    http://archives.seul.org/geda/user/Nov-2009/msg00456.html
    
    Modified-by: Peter Clifton <pcjc2@xxxxxxxxx>

:100644 100644 f682fd8... e00e2ad... M	src/find.c

commit 4fa4c4be2ced2a5742f49373f6914a33bd2f845d
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    Fix crash due to uninitalised variable in DRC check Bug #3033772
    
    Andrew Armenia  noted that the second pointer returned from
    BuildObjectList(), "object_type_list" would be left uninitialised
    if the object type was not encountered. A subsequent call to
    free() in DRCFind() would then cause memory corruption.
    
    The issue was originally reported by Ineiev:
    http://archives.seul.org/geda/user/Nov-2009/msg00456.html
    
    That patch addresses the lack of a RATLINE_TYPE in the BuildObjectType
    function, but does not prevent a segfault for other unknown types.

:100644 100644 593be70... f682fd8... M	src/find.c

=========
 Changes
=========

commit 76dbbd1b14b75f455ccd80166c9e3f3830ec609a
Author: Ineiev <ineiev@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    find.c: Add RATLINE_TYPE to switch statement in BuildObjectList
    
    Part of Ineiev's patch from:
    http://archives.seul.org/geda/user/Nov-2009/msg00456.html
    
    Modified-by: Peter Clifton <pcjc2@xxxxxxxxx>

diff --git a/src/find.c b/src/find.c
index f682fd8..e00e2ad 100644
--- a/src/find.c
+++ b/src/find.c
@@ -4493,6 +4493,7 @@ BuildObjectList (int *object_count, long int **object_id_list, int **object_type
     case VIA_TYPE:
     case PAD_TYPE:
     case ELEMENT_TYPE:
+    case RATLINE_TYPE:
       *object_count = 1;
       *object_id_list = malloc (sizeof (long int));
       *object_type_list = malloc (sizeof (int));
@@ -4501,7 +4502,9 @@ BuildObjectList (int *object_count, long int **object_id_list, int **object_type
       return;
 
     default:
-      return;
+      fprintf (stderr,
+	       _("Internal error in BuildObjectList: unknown object type %i\n"),
+	       thing_type);
     }
 }
 

commit 4fa4c4be2ced2a5742f49373f6914a33bd2f845d
Author: Peter Clifton <pcjc2@xxxxxxxxx>
Commit: Peter Clifton <pcjc2@xxxxxxxxx>

    Fix crash due to uninitalised variable in DRC check Bug #3033772
    
    Andrew Armenia  noted that the second pointer returned from
    BuildObjectList(), "object_type_list" would be left uninitialised
    if the object type was not encountered. A subsequent call to
    free() in DRCFind() would then cause memory corruption.
    
    The issue was originally reported by Ineiev:
    http://archives.seul.org/geda/user/Nov-2009/msg00456.html
    
    That patch addresses the lack of a RATLINE_TYPE in the BuildObjectType
    function, but does not prevent a segfault for other unknown types.

diff --git a/src/find.c b/src/find.c
index 593be70..f682fd8 100644
--- a/src/find.c
+++ b/src/find.c
@@ -4482,6 +4482,7 @@ BuildObjectList (int *object_count, long int **object_id_list, int **object_type
 {
   *object_count = 0;
   *object_id_list = NULL;
+  *object_type_list = NULL;
 
   switch (thing_type)
     {




_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs