gEDA-cvs: pcb.git: branch: master updated (6762885654463db6b39e6a6dfbc1911d196146fc)

[git@xxxxxxxxxx]

The branch, master has been updated
       via  6762885654463db6b39e6a6dfbc1911d196146fc (commit)
      from  d46ff633fa3f700c3314a4043dc60fa40b4d827f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.


=========
 Summary
=========

 src/action.c |   17 +++++++++++++++--
 1 files changed, 15 insertions(+), 2 deletions(-)


=================
 Commit Messages
=================

commit 6762885654463db6b39e6a6dfbc1911d196146fc
Author: DJ Delorie <dj@xxxxxxxxxxx>
Commit: DJ Delorie <dj@xxxxxxxxxxx>

    Warn user if footprints can't be found on import
    
    Since the message log doesn't make it obvious, add a pop-up dialog
    whenever there are missing footprints during an import.
    
    Affects-bug: lp-828388

:100644 100644 4d545fe... 1923cf9... M	src/action.c

=========
 Changes
=========

commit 6762885654463db6b39e6a6dfbc1911d196146fc
Author: DJ Delorie <dj@xxxxxxxxxxx>
Commit: DJ Delorie <dj@xxxxxxxxxxx>

    Warn user if footprints can't be found on import
    
    Since the message log doesn't make it obvious, add a pop-up dialog
    whenever there are missing footprints during an import.
    
    Affects-bug: lp-828388

diff --git a/src/action.c b/src/action.c
index 4d545fe..1923cf9 100644
--- a/src/action.c
+++ b/src/action.c
@@ -6958,6 +6958,8 @@ them.
 
 %end-doc */
 
+static int number_of_footprints_not_found;
+
 static int
 parse_layout_attribute_units (char *name, int def)
 {
@@ -6987,6 +6989,7 @@ ActionElementList (int argc, char **argv, Coord x, Coord y)
       }
       END_LOOP;
       element_cache = NULL;
+      number_of_footprints_not_found = 0;
       return 0;
     }
 
@@ -7005,6 +7008,10 @@ ActionElementList (int argc, char **argv, Coord x, Coord y)
 	  }
       }
       END_LOOP;
+      if (number_of_footprints_not_found > 0)
+	gui->confirm_dialog ("Not all requested footprints were found.\n"
+			     "See the message log for details",
+			     "Ok", NULL);
       return 0;
     }
 
@@ -7042,7 +7049,10 @@ ActionElementList (int argc, char **argv, Coord x, Coord y)
 #endif
       /* Not on board, need to add it. */
       if (LoadFootprint(argc, args, x, y))
-	return 1;
+	{
+	  number_of_footprints_not_found ++;
+	  return 1;
+	}
 
       nx = PCB->MaxWidth / 2;
       ny = PCB->MaxHeight / 2;
@@ -7083,7 +7093,10 @@ ActionElementList (int argc, char **argv, Coord x, Coord y)
 
       /* Different footprint, we need to swap them out.  */
       if (LoadFootprint(argc, args, x, y))
-	return 1;
+	{
+	  number_of_footprints_not_found ++;
+	  return 1;
+	}
 
       er = ElementOrientation (e);
       pe = PASTEBUFFER->Data->Element->data;




_______________________________________________
geda-cvs mailing list
geda-cvs@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-cvs