Re: gEDA-user: alarm clock boards are in!

[Peter Clifton <pcjc2@xxxxxxxxx>]

On Fri, 2007-08-31 at 14:35 -0400, DJ Delorie wrote:
> The first two chunks have to do with when pins are drawn; we don't
> want them on outline layers for example.

I've had to hack around this one before... good to see a proper patch -
and sorry I didn't produce one myself!

>   The last chunk is the one
> that adds the outline to the mask.  I'm not sure what to do with it,
> as I don't think it should be the default.

Probably not.

I may be being dumb - why is there a:

if (!gui->gui)

test around that code? Is that so it only appears in the output? (Do you
have to run PCB in batch mode for that test to work, or do the exporters
all get called with gui->gui = 0 ?

Regards,

Peter C.

> Index: draw.c
> ===================================================================
> RCS file: /cvsroot/pcb/pcb/src/draw.c,v
> retrieving revision 1.79
> diff -p -U3 -b -w -r1.79 draw.c
> --- draw.c	6 Aug 2007 02:18:30 -0000	1.79
> +++ draw.c	31 Aug 2007 18:34:07 -0000
> @@ -458,7 +458,6 @@ DrawEverything (BoxTypePtr drawn_area)
>  			    pad_callback, NULL);
>  		}
>  	      SWAP_IDENT = save_swap;
> -	    }
>  
>  	  if (!gui->gui)
>  	    {
> @@ -471,6 +470,7 @@ DrawEverything (BoxTypePtr drawn_area)
>  	    }
>  	}
>      }
> +    }
>    if (TEST_FLAG (CHECKPLANESFLAG, PCB) && gui->gui)
>      return;
>  
> @@ -749,6 +749,7 @@ DrawMask (BoxType * screen)
>  {
>    struct pin_info info;
>    int thin = TEST_FLAG(THINDRAWFLAG, PCB) || TEST_FLAG(THINDRAWPOLYFLAG, PCB);
> +  int i;
>  
>    OutputType *out = &Output;
>  
> @@ -783,6 +784,16 @@ DrawMask (BoxType * screen)
>  	}
>        gui->use_mask (HID_MASK_OFF);
>      }
> +
> +  if (!gui->gui)
> +    {
> +      for (i=PCB->Data->LayerN; i>=0; i--)
> +	{
> +	  LayerTypePtr Layer = PCB->Data->Layer + i;
> +	  if (strcmp (Layer->Name, "outline") ==0)
> +	    DrawLayer (Layer, screen);
> +	}
> +    }
>  }
>  
>  static int
> 
> 
> _______________________________________________
> geda-user mailing list
> geda-user@xxxxxxxxxxxxxx
> http://www.seul.org/cgi-bin/mailman/listinfo/geda-user




_______________________________________________
geda-user mailing list
geda-user@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user