gEDA-user: [PATCH] More accurate description of Select() and Unselect() action

[Kai-Martin Knaak <knaak@xxxxxxxxxxxxxxxxxxx>]

Hi.

Currently, the menu suggests, there is an action "Select all connected items".
However, the action called by this menu button is restricted to objects on 
visible layers. It does not check connectivity but acts on all objects with
the found flag set. This is not necessarily the same. Two unconnected patches
of copper can both be marked as found with [ctrl-f].
I was almost commited to complain about the select(connection) not working,
when I realized, that it exclusively acts on found objects. The attached patch 
changes the default GTK-menu and the texi documentation to better reflect this.

---<)kaimartin(>---
-- 
Kai-Martin Knaak                                  tel: +49-511-762-2895
UniversitÃt Hannover, Inst. fÃr Quantenoptik      fax: +49-511-762-2211	
Welfengarten 1, 30167 Hannover           http://www.iqo.uni-hannover.de
-----> not happy with moderation of geda-user mailinglist

From bd2dc635ec2a93647bf0918d6dd38c2390183998 Mon Sep 17 00:00:00 2001
From: Kai-Martin Knaak <knaak@xxxxxxxxxxxxxxxxxxx>
Date: Mon, 1 Aug 2011 21:19:01 +0200
Subject: [PATCH] More accurate description of Select() and Unselect() action

Unlike the menu and the texi manual suggest, Select(Connection) does not check 
for connectivity. Instead, it acts on visible objects with the found flag set.
In addition, the select() and unselect() actions act only on objects in visible
layers. This patch changes the menu and the texi documentation accordingly.
---
 doc/pcb.texi      |    8 ++++----
 src/action.c      |    6 +++---
 src/gpcb-menu.res |    4 ++--
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/doc/pcb.texi b/doc/pcb.texi
index cb09c00..f4ac81b 100644
--- a/doc/pcb.texi
+++ b/doc/pcb.texi
@@ -4265,9 +4265,9 @@ There are no defaults.
 @itemx Select(ElementByName|ObjectByName|PadByName|PinByName)
 @itemx Select(TextByName|ViaByName)
 Toggles either the selection flag of the object at the cross hair position
-(@emph{ToggleObject}) or selects all visible objects, all inside a
-rectangle or all objects which have been found during the last connection
-scan. The @emph{ByName} functions use a @ref{Regular Expressions} search,
+(@emph{ToggleObject}) or selects all visible objects, all visible objects inside
+a rectangle or all objects which are visible and have the ``found'' flag set.
+The @emph{ByName} functions use a @ref{Regular Expressions} search,
 always case insensitive, to select the objects.
 Default:
 @example
@@ -4407,7 +4407,7 @@ UnloadVendor()
 @cindex unselect objects
 @item Unselect(All|Block|Connection)
 Unselects all visible objects, all inside a rectangle or all objects which
-have been found during the last connection scan.
+are visible and the ``found'' flag set.
 Default:
 @example
 !Shift <Btn3Down>: Mode(Save) Mode(None) Unselect(Block)
diff --git a/src/action.c b/src/action.c
index 9b67924..59f487b 100644
--- a/src/action.c
+++ b/src/action.c
@@ -5358,13 +5358,13 @@ type specified are selected.
 Selects the object under the cursor.
 
 @item Block
-Selects all objects in a rectangle indicated by the cursor.
+Selects all visible objects in a rectangle indicated by the cursor.
 
 @item All
-Selects all objects on the board.
+Selects all objects on visible layers.
 
 @item Connection
-Selects all connections with the ``found'' flag set.
+Selects all visible objects with the ``found'' flag set.
 
 @item Convert
 Converts the selected objects to an element.  This uses the highest
diff --git a/src/gpcb-menu.res b/src/gpcb-menu.res
index e9469e9..371fb5f 100644
--- a/src/gpcb-menu.res
+++ b/src/gpcb-menu.res
@@ -229,10 +229,10 @@ MainMenu =
 #
   {"Select"
    {"Select all visible objects" Select(All)}
-   {"Select all connected objects" Select(Connection)}
+   {"Select visible found objects" Select(Connection)}
    -
    {"Unselect all objects" Unselect(All)}
-   {"unselect all connected objects" Unselect(Connection)}
+   {"Unselect visible found objects" Unselect(Connection)}
    -
    {"Select by name"
     {"All objects" Select(ObjectByName) active=have_regex}
-- 
1.7.5.4



_______________________________________________
geda-user mailing list
geda-user@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user