[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: gEDA-user: gEDA/gaf 20050313 source tarballs released



This seems to be a typo in line 518 of gnet-spice-sdb.scm (patch appended).
"VSense" is used three times and "VSsense" is placed only once in cccs
Another source (ccvs) is OK, and all sources in gnet-spice.scm too

Wojciech Kazubski

> David --
>
> Could you please do me two favors:
>
> 1.  Could you check to see if the other controlled sources give the same
> bug?
>
> 2.  Also, did you have this problem with older versions of gEDA?  I
> haven't touched spice-sdb for a few months, so this bug is probably
> older than the latest release.
>
> Stuart
>
> > Ooops!   That's my bug -- I'll fix it & stick the bugfix in CVS.
> >
> > Thanks for finding it!
> >
> > Stuart
> >
> > > Here is a bug. When gnetlist reads a .sch, and finds a cccs, it creates
> > > the following:
> > >
> > > * begin cccs expansion, f<name>
> > > F1 2 1 VSsense_F1 3
> > > VSense_F1 4 0 dc 0
> > > * end cccs expansion
> > >
> > > As you can see, this is misspelled, causing an error in ngspice. It
> > > should read:
> > >
> > > * begin cccs expansion, f<name>
> > > F1 2 1 VSsense_F1 3
> > > VSsense_F1 4 0 dc 0
> > > * end cccs expansion
> > >
> > > and when I edit this manually, ngspice runs correctly.
> > >
> > > David Logan
> > >
> > > Ales Hvezda wrote:
> > > >Hi folks,
> > > >
> > > >I am pleased to announce the release of gEDA/gaf 20050313.  It's a
> > > > little later than expected, but I won't release with a known critical
> > > > bug. Though this does not mean there are no other critical bugs;
> > > > those are just unknown at this point in time. :-|
> > > >
> > > >Please find the source tarballs along with the toplevel Makefile at:
> > > >
> > > >http://geda.seul.org/devel/20050313/
> > > >or
> > > >ftp://ftp.geda.seul.org/pub/geda/devel/20050313
> > > >
> > > >and at the mirror (ftp.sunet.se) in a day or so.
> > > >
> > > >md5sums:
> > > >
> > > >11254491704f66bd62d92c964f1854f6 *Makefile
> > > >94568cd32cc6adb4699a62710bccd15d *README
> > > >be8848ae8573edb761dcfe929981e899 *geda-20050313.tar.gz
> > > >cba253c1602648a5ade83ce4b24693d4 *geda-docs-20050313.tar.gz
> > > >fe82a604ad4d4f281797fd457eaae358 *geda-examples-20050313.tar.gz
> > > >db62db5b77df408dd180b6f6cc65864e *geda-gattrib-20050313.tar.gz
> > > >b5e247ab0de86b12b4eff280956d307c *geda-gnetlist-20050313.tar.gz
> > > >3c7caa75677dfdb03c7428076f1d1226 *geda-gschem-20050313.tar.gz
> > > >12d94d1a75867fbde883027099e1d6a2 *geda-gsymcheck-20050313.tar.gz
> > > >a08895cb4a70c07b11b816b0843d3a0b *geda-symbols-20050313.tar.gz
> > > >fbdc7676027a6547f54308b88851395d *geda-utils-20050313.tar.gz
> > > >aff7e68dd56f10624ed3891a4d83dbfe *libgeda-20050313.tar.gz
> > > >
> > > >	Lots and lots of changes, so please test.  I will write up formal
> > > >release notes in a day or so.  Many thanks to all the developers,
> > > >testers, and users who contributed to this release.
> > > >
> > > >								-Ales
> > > >
> > > >PS. CVS developers: Please do not check in anything for at least a day
> > > >or so, just long enough for me to put down the release tag.  Thank
> > > > you. After this release settles down a little, then we can rewrite
> > > > the whole thing. :-)
--- geda-gnetlist-20050313/scheme/gnet-spice-sdb.scm.cccs	2005-02-02 11:37:28.000000000 +0100
+++ geda-gnetlist-20050313/scheme/gnet-spice-sdb.scm	2005-03-15 23:00:11.785950800 +0100
@@ -516,7 +516,7 @@
           ;; the user should create the refdes label begining with a f
       (display (string-append package " ") port)
       (spice-sdb:write-two-pin-names package "1" "2" port)
-      (display (string-append "VSsense_" package " " (gnetlist:get-package-attribute package "value") "\n" ) port)
+      (display (string-append "VSense_" package " " (gnetlist:get-package-attribute package "value") "\n" ) port)
           ;; implement the current measuring voltage source
       (display (string-append "VSense_" package " ") port)
       (spice-sdb:write-two-pin-names package "3" "4" port)