[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: gEDA-user: PCB: Repaired header footprints in pcblib-newlib/geda



Marshall Jose wrote:
> I found a small mistake in the PCB pcblib-newlib/geda footprints which 
> can be seen here:
> 
> http://www.gedasymbols.org/footprints/m4lib/DIN41651_20.fp and
> http://www.gedasymbols.org/footprints/m4lib/DIN41651_20S.fp
> 
> These are parts which should have 20 pins, but they somehow got 
> overwritten or confused with their 10-pin counterparts. I changed the 
> 26-pin version to create my own, correct footprints. If someone would 
> like to push them into the repo, I've appended them here:

Fixed.  Just as a note, anything in pcblib-newlib is generated so 
patches need to touch the sources not the output.  In this case, the 
patch was:

Index: geda.inc
===================================================================
RCS file: /cvsroot/pcb/pcb/lib/geda.inc,v
retrieving revision 1.29
diff -u -2 -r1.29 geda.inc
--- geda.inc    17 Dec 2006 03:59:17 -0000      1.29
+++ geda.inc    5 Nov 2007 22:25:45 -0000
@@ -730,5 +730,5 @@
  define(`PKG_DIN41651_14',  `PKG_DIN41_651LAY(  `$1', `$2', `$3', 14)');
  define(`PKG_DIN41651_16',  `PKG_DIN41_651LAY(  `$1', `$2', `$3', 16)');
-define(`PKG_DIN41651_20',  `PKG_DIN41_651LAY(  `$1', `$2', `$3', 10)');
+define(`PKG_DIN41651_20',  `PKG_DIN41_651LAY(  `$1', `$2', `$3', 20)');
  define(`PKG_DIN41651_26',  `PKG_DIN41_651LAY(  `$1', `$2', `$3', 26)');
  define(`PKG_DIN41651_34',  `PKG_DIN41_651LAY(  `$1', `$2', `$3', 34)');
@@ -741,5 +741,5 @@
  define(`PKG_DIN41651_14S', `PKG_DIN41_651STAND(`$1', `$2', `$3', 14)');
  define(`PKG_DIN41651_16S', `PKG_DIN41_651STAND(`$1', `$2', `$3', 16)');
-define(`PKG_DIN41651_20S', `PKG_DIN41_651STAND(`$1', `$2', `$3', 10)');
+define(`PKG_DIN41651_20S', `PKG_DIN41_651STAND(`$1', `$2', `$3', 20)');
  define(`PKG_DIN41651_26S', `PKG_DIN41_651STAND(`$1', `$2', `$3', 26)');
  define(`PKG_DIN41651_34S', `PKG_DIN41_651STAND(`$1', `$2', `$3', 34)');


-Dan


_______________________________________________
geda-user mailing list
geda-user@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-user