[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: GraphThing 1.3.2 released

David Symonds <dsymonds@xxxxxxxxx> (22/12/2006):
> GraphThing 1.3.2 is now released, and ready for packagers to start
> making packages!


I'd like to propose another patch so as to make the stripping when
installing conditional. The motivation is that (in debian) one should be
able to build a package with debugging symbols by setting the variable
“DEB_BUILD_OPTIONS” to “nostrip”. The helpers handle that nicely and do
the right thing (they strip the binaries when needed), but graphthing's
Makefiles do an unconditional stripping.

Please find attached a patch to make it conditional (defaulting to
stripping), by supporting a “STRIP” variable, which aims at containing
the optional “-s” argument for the “INSTALL” calls.

You can find the debian patches at any time by visiting the following
URL[1], which contains my packaging directory, and then clicking on
“tree” on the right, then “debian” and then “patches”. (“master” is the
equivalent of the “trunk”, the yellow tags match the uploads to debian.)

 1. http://git.debian.org/?p=collab-maint/graphthing.git


Cyril Brulebois
--- graphthing-1.3.2/src/GNUmakefile.in~	2007-08-28 11:47:52.000000000 +0200
+++ graphthing-1.3.2/src/GNUmakefile.in	2007-08-28 11:48:08.000000000 +0200
@@ -12,6 +12,7 @@
+STRIP ?= -s
 #LIBS = @LIBS@ @WX_LIBS@ -lefence
@@ -38,7 +39,7 @@
 	@INSTALL@ -d @prefix@/bin/
-	@INSTALL@ -s -m 755 $(PROGNAME) @prefix@/bin/
+	@INSTALL@ $(STRIP) -m 755 $(PROGNAME) @prefix@/bin/
 	rm -f $(ALL_OBJS) unit_test.o chrom.o

Attachment: pgpz8i4EefW3b.pgp
Description: PGP signature