Re: [Libevent-users] A patch for evrpc, allowing extra argument of request_new and reply_new

[Dan Kegel <dank@xxxxxxxxx>]

Can you add a build step that verifies the abi has not changed?

On Apr 14, 2010 11:30 AM, "Nick Mathewson" <nickm@xxxxxxxxxxxxx> wrote:

On Mon, Mar 29, 2010 at 11:42 AM, Shuo Chen <giantchen@xxxxxxxxx> wrote:
> Another patch to make lib...

Hi!  I've chatted with Niels, and checked in your patches.

I'm not as familiar with the rpc code as Niels is, but it looks like
this one changes the arguments of evrpc_register_generic().  We've
asked people not to use evrpc_register_generic in their code, of
course, so it shouldn't break source compatibility, but it _will_
break binary compatibility.  Not a big deal; we're already breaking
some binary compatibility between 1.4 and 2.0 for other stuff.  Once
2.0 is stable, though, we're going to try to keep the ABI as stable as
we can.

--
Nick

***********************************************************************
To unsubscribe, send an e-ma...