Re: [Libevent-users] Re: [PATCH] http: on connection reset, detach the closed fd from the bufferevent

[Catalin Patulea <catalinp@xxxxxxxxxx>]

On Tue, Feb 19, 2013 at 4:17 PM, Nick Mathewson <nickm@xxxxxxxxxxxxx> wrote:
> But the patch isn't quite optimal for that -- we should do the
> bufferevent_setfd() before we close the socket, not after.  That way
> there's never a non-deleted event that refers to the fd.
The idea with doing the setfd there was in the case where evcon->fd ==
-1 but the bufferevent has an fd.

Why is there a copy of the fd in evcon? Why not use
bufferevent_getfd(evcon->bufev)?

> How does the attached patch look to you? Does it work as well/any better?
I'll see about canarying it and will reply once it's been running for a while.
***********************************************************************
To unsubscribe, send an e-mail to majordomo@xxxxxxxxxxxxx with
unsubscribe libevent-users    in the body.