Re: [Libevent-users] [PATCH] Force strict validation of HTTP version in response

[Nick Mathewson <nickm@xxxxxxxxxxxxx>]

On Mon, Jan 16, 2012 at 5:51 PM, Catalin Patulea <catalinp@xxxxxxxxxx> wrote:
> Hi,
>
> I ran into this while evhttp was trying to fetch Shoutcast streams.
> The server responds with 'ICY 200 OK', which libevent intends to
> reject. But the sscanf return value isn't checked properly and the
> behaviour is undefined (in practice, sometimes accepts the response,
> sometimes rejects it).

Looks good to me; merging it.  I also looked over the other uses of
sscanf to make sure none of them had the same issue.

> For small patches like this, should I just paste the patch in the
> message body? It would make it easier to glance at the patch, though
> there's a possibility Gmail might mangle the text.

I find attachments fine to deal with, but I have given up on trying to
insist on a one true way to submit patches.

-- 
Nick
***********************************************************************
To unsubscribe, send an e-mail to majordomo@xxxxxxxxxxxxx with
unsubscribe libevent-users    in the body.