[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [Libevent-users] Re: RPC: patch for evrpc_free() and evrpc_unregister_rpc()
- To: libevent-users@xxxxxxxxxxxxx
- Subject: Re: [Libevent-users] Re: RPC: patch for evrpc_free() and evrpc_unregister_rpc()
- From: Nick Mathewson <nickm@xxxxxxxxxxxxx>
- Date: Sat, 12 Mar 2011 12:11:58 -0500
- Delivered-to: archiver@xxxxxxxx
- Delivered-to: libevent-users-outgoing@xxxxxxxx
- Delivered-to: libevent-users@xxxxxxxx
- Delivery-date: Sat, 12 Mar 2011 12:12:06 -0500
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; bh=/b9n83PGT9TgtTjrP9kJmh0qXPyKlktWOBxrZerc+98=; b=ivMgwwm8P5UFtQh4Pg7186MRb/LTuOehAq01czTiXO8gcHA6I7o7pawRlqpUxAL/kb w+uPfEc1gINjoSgtVvUSGLNq+bxLpBovujSsk6eDg/vbh/vehg+M2B4+7Rd936YM8DSm L+QcNnRTapdZLubf2jDkXrcar+GTQjh4bsHeQ=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; b=RhfhyrGK/VWPHvMCT+GLT1Ov4abSdqY6ILCsvY8FnxOVV+LO/gyxgNEseL4a4Jb9Tu fu0ntDsQYa5U+iAryt6qRgdadTlHoUb/MqJgC8x8rDsvjtTe7R4zS0Hv7mjXW7EFnesk dpDB9Kjr9BgTM+uZqMHvprz3CnXXM8jrIzj5k=
- In-reply-to: <4D75EB33.8090700@xxxxxx>
- References: <4D75EB33.8090700@xxxxxx>
- Reply-to: libevent-users@xxxxxxxxxxxxx
- Sender: owner-libevent-users@xxxxxxxxxxxxx
On Tue, Mar 8, 2011 at 3:39 AM, Christophe Fillot <cf@xxxxxx> wrote:
>
> Nick Mathewson wrote:
>
> Hi Nick,
>>
>> When I apply this patch, the unit tests don't pass any more. I get:
>>
>> rpc/basic_test: [forking] OK
>> rpc/basic_message: [forking] OK
>> rpc/basic_client: [forking] [err] evrpc.c:109: Assertion r == 0 failed
>> in evrpc_free
>> [Lost connection!]
>> [basic_client FAILED]
>> rpc/basic_queued_client: [forking] OK
>> rpc/basic_client_with_pause: [forking] [err] evrpc.c:109: Assertion r
>> == 0 failed in evrpc_free
>> [Lost connection!]
>> [basic_client_with_pause FAILED]
>>
>> Did the tests pass for you?
>>
> Hmmm ok I'm stupid, evrpc_unregister_rpc() returns 0 for success
> and -1 for error, whereas evrpc_remove_hook() returns 1 for success
> and 0 for error. So I incorrectly modified the asserts for the hooks.
>
> The attached patch should be ok :)
Indeed, this one looks better. Merging it. Thanks!
--
Nick
***********************************************************************
To unsubscribe, send an e-mail to majordomo@xxxxxxxxxxxxx with
unsubscribe libevent-users in the body.