[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
[Libevent-users] missing EINTR handling?
- To: libevent-users@xxxxxxxx
- Subject: [Libevent-users] missing EINTR handling?
- From: Pierre Phaneuf <pphaneuf@xxxxxxxxxx>
- Date: Tue, 27 Oct 2009 09:53:56 -0400
- Delivered-to: archiver@xxxxxxxx
- Delivered-to: libevent-users-outgoing@xxxxxxxx
- Delivered-to: libevent-users@xxxxxxxx
- Delivery-date: Tue, 27 Oct 2009 09:54:23 -0400
- Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=google.com; s=beta; t=1256651660; bh=qhAIVrweJwzUEaPxM1uNHbiREhk=; h=MIME-Version:From:Date:Message-ID:Subject:To:Content-Type; b=CEN9nW6DneI7ihGq0DnZ5UTpaCkC7OFZiQckyProA49ZcZ22y+dT0J1L/EyGQvzsx TdFsI3IFgZsOwKheRg7Zw==
- Domainkey-signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=mime-version:from:date:message-id:subject:to:content-type:x-system-of-record; b=PQU3gykrgNjnJMo3yesvPeFwfdtC/D8UbRzooLhWJOit0YKq9RcclDBkkZR0nUkjB ABWc6VzUbwoFzjgErrZHg==
- Reply-to: libevent-users@xxxxxxxxxxxxx
- Sender: owner-libevent-users@xxxxxxxxxxxxx
Looking at the evhttp_write() callback handler (in http.c), I see a
call to evbuffer_write() at line 685, which in turns calls write() (at
line 413 of buffer.c), and neither seems to handle EINTR. I see EINTR
handling in evhttp_read(), though. Simple omission?
I also wonder why EINTR isn't handled at the evbuffer level, say,
since there is pretty much nothing else to do than retry it
immediately, isn't it? As opposed to EAGAIN, say, which requires
retrying it at a later time, when another event comes in...
Thanks!
***********************************************************************
To unsubscribe, send an e-mail to majordomo@xxxxxxxxxxxxx with
unsubscribe libevent-users in the body.