Re: [Libevent-users] Cygwin patch

[Ralph Castain <rhc@xxxxxxxxxxxx>]

On Oct 7, 2013, at 7:30 AM, Nick Mathewson <nickm@xxxxxxxxxxxxx> wrote:

> On Sun, Oct 6, 2013 at 8:00 PM, Ralph Castain <rhc@xxxxxxxxxxxx> wrote:
>> Hi folks
>> 
>> We have a patch that was required on libevent 2.0.21 for cygwin:
> 
> Hi, Ralph!   I have a question here.  This looks fine as far as it
> goes, but there are more instances of "#include <winsock2.h>" than
> just the one you disabled in event2/util.h , and more instances of
> "#define WIN32_LEAN_AND_MEAN" than the one you disabled in event.h.
> 
> What is it about those two in particular that breaks Libevent
> compilation under cygwin while the others are okay?

The patch probably does need to be broader, Nick. We don't build all of libevent, and so there are probably places where the same issue occurs but our contributor didn't see it.

Sorry it isn't more complete - I just passed along what we were given, which shows the problem but may not be complete (as you indicated).


> 
> yrs,
> -- 
> Nick
> ***********************************************************************
> To unsubscribe, send an e-mail to majordomo@xxxxxxxxxxxxx with
> unsubscribe libevent-users    in the body.

***********************************************************************
To unsubscribe, send an e-mail to majordomo@xxxxxxxxxxxxx with
unsubscribe libevent-users    in the body.