Re: Try it out...

[Micah Yoder <LYoder@cyberis.net>]

"Aaron D. Turner" wrote:

> Just tried it.  To be honest, I don't care much for the format of the
> page.  The colors are IMHO ugly, and the fields should line up better.
> Personally I prefer something like:

Well, as I said before, once we decide on a style for the site I can
change this script to reflect it.  I sort of like the blue tints myself,
but it's no big deal.  I started this script by copying from my other
project, which uses those colors.

> Description of field:
>   [Field .....................]
> 
> It's a taste thing, and few people say I have great taste, so take it with
> a grain of salt.  Of course, right now, having it work is the most
> important thing.

I'll wait for other comments before doing anything about this.  I'm not
great at taste items either, but I don't think it's *that* bad...

TOP priority is making things work.  I suggest we do a little more of
that and then making the style of the site look consistent.

> This is header info from the email it sent me:
> 
> Date: 24 Feb 1999 01:01:30 -0000
> From: root@linuxkb.org
> To: aturner@linuxkb.org
> Subject: Linux Knowledge Base password
> 
> Simple questions:
> 
> 1)  Why is the time zone 8 hours off?

Hmm.  That's GMT.  I would suspect that's a Qmail thing.

> 2)  Why is this script being run as root -or- why are you forging the
> From: field to be root?  This script should not, need not, execute as
> root.  And we don't want root forged, since stupid people hit reply.
> webmaster@linuxkb.org is probably a good choice.

Probably also a Qmail thing.  It's being run as the Apache user, which I
think is nobody.  I'm not forging any headers.

> Also, if an error is generated, an email should not be sent.  IFF (if and
> only if) all the fields check out OK, should an email be sent and the DB
> updated.

That's currently what happens, with a couple exceptions that I still
need to fix.  Also, it sends the E-mail before doing the DB update which
DEFINITELY needs to be changed.  If the DB update isn't successful, the
mail shouldn't be sent.

> I assume that there's a nice "Thank you, now go check your email for your
> password" page after a successful submisssion.

Yeah, but this is something I need to work on.  Basically, it displays
the same form again with all the fields filled in, and below that it
prints the message after doing the DB update.

It currently checks the fields as it's printing them.  Guess I better
put in a check at the top of the script so you don't have to see
everything again if there are no problems.

I'll try to get some of these issues worked out today and/or tomorrow,
as well as write a log in script.