[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #2711 [Tor Bridge]: status/clients-seen should answer even when uptime < 24 hours

#2711: status/clients-seen should answer even when uptime < 24 hours
------------------------+---------------------------------------------------
 Reporter:  arma        |          Owner:                     
     Type:  defect      |         Status:  needs_review       
 Priority:  normal      |      Milestone:  Deliverable-Mar2011
Component:  Tor Bridge  |        Version:                     
 Keywords:              |         Parent:                     
   Points:              |   Actualpoints:                     
------------------------+---------------------------------------------------

Comment(by karsten):

 Replying to [comment:3 nickm]:
 > See branch "feature2711" in my public repository.

 The idea to implement option A seems reasonable.  I found (and fixed?) two
 issues with your patch though:

  - In geoip_bridge_stats_write(), we always need to return
 `start_of_bridge_stats_interval + WRITE_STATS_INTERVAL` and not `now +
 WRITE_STATS_INTERVAL`.  If we don't, we break the logic when to call this
 function the next time.  I changed the return after formatting the bridge
 stats string into a goto.

  - In load_bridge_stats(), we need to parse the loaded bridge stats string
 to find out if it is well-formatted and still recent enough.  This was
 done as part of parse_bridge_stats_controller() which is now gone.  I put
 the relevant parts back as validate_bridge_stats() and changed
 load_bridge_stats() to call that function.

 Please see branch feature2711 in my public repository.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2711#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs