[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #2819 [Torbutton]: Fix JS Hooks in FF4 using new JS 1.8.5 features
#2819: Fix JS Hooks in FF4 using new JS 1.8.5 features
----------------------------------------+-----------------------------------
Reporter: gk | Owner: mikeperry
Type: defect | Status: new
Priority: critical | Milestone:
Component: Torbutton | Version:
Keywords: MikePerryIteration20110417 | Parent:
Points: 4 | Actualpoints:
----------------------------------------+-----------------------------------
Comment(by mikeperry):
Replying to [comment:9 gk]:
> Replying to [comment:8 mikeperry]:
> > I suppose we can just make Components.lookupMethod configurable in our
fork of Firefox, and then use this to remove it. We also want to remove
Components.interfaces, because all that does is let you fingerprint which
Firefox version you have. But guess what: Components.interfaces is also
not configurable..
> That sounds interesting do you need a hand here? We certainly have
interest in this kind of project as well but not the means to do it alone.
What project are you working on? Forgive me for not recognizing your
handle. I created ticket #2873 for our efforts toward a patch.
> There is another issue I have found. It seems possible under certain
circumstances to unhook things if one produces errors during sandbox
evaluation. For instance, yesterday I got a lot of errors like "Torbutton
Exception in sandbox evaluation. Date hooks not applied: syntax error"
while trying to break the hooks somehow. And indeed, at least the
innderWidth and innerHeight have been unhooked just because of that
(unfortunately I did not test all the other hooked properties and
objects). BUT, I have not had luck to produce that behavior again, let
alone reliably. Are these errors and its danger a known issue? It seems
there is some kind of race condition involved, dunno. Guess I have to dig
deeper into the hooking code...
Back in the Firefox 2/3 days, I went through great effort to try to ensure
that the JS hooks applied before anything on the page was able to run. But
things may have changed in FF4...
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2819#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs