[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #1090 [Tor Client]: Warning about using an excluded node for exit
#1090: Warning about using an excluded node for exit
---------------------------+------------------------------------------------
Reporter: Sebastian | Owner: nickm
Type: defect | Status: needs_review
Priority: major | Milestone: Tor: 0.2.2.x-final
Component: Tor Client | Version: 0.2.1.19
Resolution: None | Keywords:
Parent: | Points:
Actualpoints: |
---------------------------+------------------------------------------------
Comment(by arma):
To clarify, I believe I added d0943987 when we had a test network all
running on the same /16, and it couldn't handle my bridge. Since then, we
changed routerlist_add_family() to not add any network-nearby family
members if EnforceDistinctSubnets is 0, and it is 0 if you set
TestingTorNetwork. So it would not be the end of the world to #ifdef out
of the "try again ignoring families" logic, but I think if we #ifdef it
out we will run across weird edge cases that only happen to bridge users,
and I worry that 0.2.2 won't see enough testing for those cases.
As an alternate fix, how about we change
{{{
if (!r && entry_list_is_constrained(options) && consider_exit_family)
{
}}}
to
{{{
if (!r && options->UseBridges && consider_exit_family) {
}}}
?
That way we would skip the behavior when you set EntryNodes (good), but do
the behavior if you set UseBridges (also good). After all, people aren't
going to successfully be putting both their exit relay and their bridge in
the same family (which might be a separate bug we should ponder).
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1090#comment:58>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs