[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #1090 [Tor Client]: Warning about using an excluded node for exit

#1090: Warning about using an excluded node for exit
---------------------------+------------------------------------------------
    Reporter:  Sebastian   |       Owner:  nickm             
        Type:  defect      |      Status:  needs_review      
    Priority:  major       |   Milestone:  Tor: 0.2.2.x-final
   Component:  Tor Client  |     Version:  0.2.1.19          
  Resolution:  None        |    Keywords:                    
      Parent:              |      Points:                    
Actualpoints:              |  
---------------------------+------------------------------------------------

Comment(by arma):

 {{{
     /* XXXX022 HEY!  Shouldn't this look at ent->new_address? */
 }}}

 Yes, I agree. See #437 for the original issue. See git commit 5c03f82a650e
 where we did the wrong thing:
 {{{
      if (conn->chosen_exit_retries) {
        if (--conn->chosen_exit_retries == 0) { /* give up! */
 -        /* XXX020rc unregister maps from foo to
 -         * foo.chosen_exit_name.exit \forall foo. -RD */
 +        clear_trackexithost_mappings(edge_conn->chosen_exit_name);
          tor_free(edge_conn->chosen_exit_name); /* clears it */
          /* if this port is dangerous, warn or reject it now that we don't
           * think it'll be using an enclave. */
 }}}

 I wonder if this wants its own bug number. It will want its own changes
 file in any case.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1090#comment:63>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs