[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #3000 [Tor Client]: Clients do not clear HS descriptor cache on SIGNAL NEWNYM



#3000: Clients do not clear HS descriptor cache on SIGNAL NEWNYM
------------------------+---------------------------------------------------
 Reporter:  rransom     |          Owner:  rransom           
     Type:  defect      |         Status:  needs_review      
 Priority:  major       |      Milestone:  Tor: 0.2.1.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by rransom):

 Replying to [comment:2 rransom]:

 > The merges were non-trivial, and need to be reviewed carefully.

 Note to self: Do not '''ever''' write ânon-trivial hand mergeâ in a Git
 merge commit message.  The ''only'' sane way to do a non-trivial merge is
 to cherry-pick the changes over so that people can review them properly
 (rather than letting `git diff --cc` hide the newly introduced
 `rend_client_fetch_renddescs` function so I don't notice that it needs to
 be updated for 0.2.2), then do a keep-ours merge.

 > I also put a fix for #1930 (also known as #1024) on this branch, mainly
 because I didn't figure out that nuking the HS descriptor cache more often
 wouldn't cause #1930 to occur more often until after I had written that
 fix.

 I am no longer convinced that clearing the HS descriptor cache on NEWNYM
 will not make #1930 occur more often.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3000#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs