[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #5637 [Metrics Utilities]: Ignore carriage returns when parsing descriptors

#5637: Ignore carriage returns when parsing descriptors
-------------------------------+--------------------------------------------
 Reporter:  karsten            |          Owner:  karsten
     Type:  defect             |         Status:  new    
 Priority:  minor              |      Milestone:         
Component:  Metrics Utilities  |        Version:         
 Keywords:                     |         Parent:         
   Points:                     |   Actualpoints:         
-------------------------------+--------------------------------------------

Comment(by atagar):

 Test added...
 https://gitweb.torproject.org/stem.git/commitdiff/725beac5437d85e8da5baa8a6fce90ce76fa9f9f

 Btw, you left a comment a while back suggesting a factory descriptor
 constructor for testing like metrics-lib. Stem actually does that too...
 https://gitweb.torproject.org/stem.git/blob/HEAD:/test/unit/descriptor/server_descriptor.py#l35

 In general I favor running against an actual descriptor when we've seen
 one in the wild, and using the factory when we haven't.

 Cheers! -Damian

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5637#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs