Re: [tor-bugs] #2454 [Tor]: We should check our IP immediately when cbt notes the network is live again

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#2454: We should check our IP immediately when cbt notes the network is live again
-----------------------------+-----------------------------------
     Reporter:  Sebastian    |      Owner:
         Type:  enhancement  |     Status:  needs_revision
     Priority:  normal       |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  tor-relay 025-triaged
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-----------------------------------

Comment (by nickm):

 The patch didn't apply to master, but it was pretty small, so I recreated
 the changes by hand in branch "bug2454_025" in my public repository.  Note
 that master no longer has time_to_check_ipaddress.

 Changes/checks I'd suggest:

 1) No global variables.

 2) In fact, we don't need a new variable at all; as the code stands now,
 we just need a function that resets time_to_check_descriptor() in main.c.
 (But see 5 below.)

 3) I'd like to grep though all the calls to
 circuit_build_times_network_is_live to make sure this really -should-
 work.

 4) Can this fire more than once every 3 minutes?

 5) Is there anything in that big block in main.c that we *don't* want to
 do in this case?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2454#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs