[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9268 [TorBrowserButton]: Resizing the browser window does not take size of taskbars and DPI into account

#9268: Resizing the browser window does not take size of taskbars and DPI into
account
-------------------------+-------------------------------------------------
     Reporter:  gk       |      Owner:  mikeperry
         Type:  defect   |     Status:  needs_revision
     Priority:  major    |  Milestone:
    Component:           |    Version:
  TorBrowserButton       |   Keywords:  tbb-fingerprinting,
   Resolution:           |  GeorgKoppen201403R, MikePerry201403R
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by cypherpunks):

 Replying to [comment:40 gk]:
 > Without any toolbar I get 6. If I add the menubar I get 38 if I add to
 that the location bar I get 38 and if I additionally add the bookmark bar
 I get 38 as well. This is on Win 7 with TBB 3.5.3. So far, so good. BUT:
 For the issue at hand it is not important what the values/differences in
 the browser console are compared to those we have when checking for
 outerHeight == innerHeight, right? So let's see how the values behave when
 we look at the log in torbutton_resize_window() which is the place where
 the comparison matters. On the same machine, the first time that function
 is called I get without any toolbar 56; with the addition of the location
 bar I get 91; if I add to that the menubar I get 119 and if I add to that
 the bookmark bar I get 143. Thus, the toolbars matter here! (and you can
 observe similar results in later calls to this function). And, as we
 always ship the browser with the location bar enabled I cannot see how
 outerHeight can be equal to innerHeight (even if the titlebar were not
 visible) and why we therefore need the kludge.

 Are you sure do you counts window.innerHeight, and not win.innerHeight?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9268#comment:41>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs