Re: [tor-bugs] #10769 [Tor Weather]: write weathers emails to a file

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#10769: write weathers emails to a file
-----------------------------+-----------------------------
     Reporter:  feverDream   |      Owner:  feverDream
         Type:  enhancement  |     Status:  assigned
     Priority:  normal       |  Milestone:
    Component:  Tor Weather  |    Version:
   Resolution:               |   Keywords:  weather-rewrite
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+-----------------------------

Comment (by feverDream):

 Replying to [comment:9 karsten]:
 > There are a few issues with that commit:
 >  - We cannot comment out settings in `weather/config/config.py` until we
 actually moved to Onionoo.  What if somebody takes this branch and tries
 to deploy Weather?  It won't work at all.
 >  - Rather than commenting out code or settings, we should simply remove
 them.  That's for the future, though, when we can actually get rid of
 them.

 Makes sense, but Django expects these files to be a there. I can either go
 with a dummy authenticator file or a "except: pass" loop around it. I am
 in favor of the latter.

 >  - I'm unclear why you changed the path to the database.  That's going
 to break the existing deployment whenever somebody does `git pull`.  We
 shouldn't do that.  We should rather stick to the existing directory
 layout with `/../var/` even though it's not pretty.

 I remember changing it as the path was incorrect. To make it work I made
 these changes;changed the path to PROJECT_PATH:/../../var/WeatherDB and
 change the permissions of the db-file. For development purposes, I figured
 the db-file in '/.' was simple.

 To keep things intact, making these changes local makes sense to me. What
 do you think? I can add a few steps in the README  describing the settings
 that need to be changed to run weather locally.


 >  - Maybe we should also write emails somewhere to `/../var/`?  It seems
 that Weather currently doesn't write anything to the cloned directory
 root, but only to `/../var/`.  If that is the case, let's not clutter up
 `/.`.
  Sure thing, I will look into it.
 >
 > So, I guess a commit that only adds the `EMAIL_BACKEND` and
 `EMAIL_FILE_PATH` lines to `settings.py` but with the right directory to
 write emails to would be fine to merge.

 Fine, I will trim the commit and move the "settings" stuff to their own
 ticket( should keeps things separate :))

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10769#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs