[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #11183 [meek]: Make an HTTP requestor Firefox extension for meek-client

#11183: Make an HTTP requestor Firefox extension for meek-client
-------------------------+--------------------
     Reporter:  dcf      |      Owner:  dcf
         Type:  project  |     Status:  closed
     Priority:  normal   |  Milestone:
    Component:  meek     |    Version:
   Resolution:  fixed    |   Keywords:  meek
Actual Points:           |  Parent ID:  #10935
       Points:           |
-------------------------+--------------------
Changes (by dcf):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:16 dcf]:
 > Now we need to find out how to run the second browser instance without a
 dialog.

 [https://gitweb.torproject.org/pluggable-
 transports/meek.git/commitdiff/2f753a57ea2fb8db0a1a0cc7d401a4db59f4ab98
 This idea] of pumping the event loop seems to work.

 The MDN page says:
    Warning: Spinning the event loop breaks run to completion semantics of
 JavaScript (it creates a nested event loop).  This can cause code to
 reenter itself, which can result in broken functionality.  This approach
 should be avoided whenever possible.
 I don't think it applies to us. We're already breaking
 [https://developer.mozilla.org/en-US/Add-
 ons/Performance_best_practices_in_extensions#Use_asynchronous_I.2FO
 extension best practices] by hijacking control and never returning,
 because that's the point.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11183#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs