[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #11514 [BridgeDB]: Captcha not working
#11514: Captcha not working
--------------------------+--------------------------------
Reporter: Dedalo | Owner: isis
Type: defect | Status: needs_review
Priority: normal | Milestone:
Component: BridgeDB | Version:
Resolution: | Keywords: bridgedb-reportbug
Actual Points: | Parent ID:
Points: |
--------------------------+--------------------------------
Comment (by isis):
Replying to [comment:1 cypherpunks]:
Thanks for the patch! A couple comments:
1) `Unhandled Exception`s in the production server are piped to a file.
Currently, that file is 25MB, and there are no `Unhandled Exception`s in
it. Plus, exceptions generated in the `render_*` methods of Twisted HTTP
servers generally also send tracebacks to the client (although I've
recently tried to prevent that from happening). I don't believe this is
due to an `Unhandled Exception`.
2) Unless the decryption method produces an exception, it returns a
string. `str.lower()` is a Python builtin, as well as `str.__eq__()`, and
if either were raising exceptions, then Python developers all over the
planet would probably be screaming at Guido. :)
3) The code you patched is the current `develop` branch. While that is
generally exactly the correct thing to do when working on BridgeDB, the
current deployed version is ''always'' the last tagged release. Those
calls to `lower()` were introduced in
`dd9e75ba234d2d4aad90aedb0bf163d8bb13811b`, and don't even exist yet in
the version running on https://bridges.torproject.org.
Though I could be entirely wrong. If you can write me a unittest which is
able to raise any Exception in the `if solution.lower() ==
decrypted.lower():` line of `GimpCaptcha`, I will totally believe you that
this line causes bugs.
------
Unrelated to code review, the first portion of this ticket is a duplicate
of #11467.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11514#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs