[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #11513 [Tor]: Make UNRESTRICTED_SERVER_CIPHER_LIST non-stupid

#11513: Make UNRESTRICTED_SERVER_CIPHER_LIST non-stupid
------------------------+-----------------------------------------
     Reporter:  nickm   |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  normal  |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-client 024-backport tls
Actual Points:          |  Parent ID:
       Points:          |
------------------------+-----------------------------------------

Comment (by isis):

 I reviewed nickm's `src/common/gen_server_ciphers.py` script in commit
 `bd3db82906a2efcd678b5f4b61fef26c93828777`.

 Looks good to me. I had a couple slight "wait-what-are-you-doing-with-
 that-list-indexing-and-those-dictionary-lookups-in-that-generator"
 doubletakes, but overall the code is easy to read and neatly organised. I
 tested and it and seems to sort correctly on my 1.0.2-stable and 1.0.1g
 OpenSSLs, according to the above parameters. (Also, I agree with the
 sorting rationale.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11513#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs