[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #11519 [Tor]: uninitialized timeval causing valgrind errors

#11519: uninitialized timeval causing valgrind errors
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:
  robgjansen             |     Status:  needs_review
         Type:  defect   |  Milestone:  Tor: 0.2.5.x-final
     Priority:  major    |    Version:  Tor: 0.2.5.3-alpha
    Component:  Tor      |   Keywords:  tor-client 024-backport
   Resolution:           |  023-backport
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by robgjansen):

 Replying to [comment:2 nickm]:
 > Any idea why we haven't seen this before?  To me it looks like it was
 introduced by 88e0026d, which merged in 0.2.3.11-alpha.
 >

 I have been noticing random failures in both 0.2.3.25 and 0.2.5.2-alpha,
 and more often in some of my larger scale Tor simulations (where small
 issues tend to be exacerbated because the thousands of instances of Tor
 increase code/state coverage). I ran valgrind in an attempt to locate the
 problem, and found this bug. My problems have appeared as random memory
 errors, and so I'm not sure if this bug is the answer I was looking for.
 More testing is needed to make that determination.

 > Anyways, I have a fix against 0.2.3 in branch "bug11519_023"

 I tested precisely that fix and valgrind no longer reports the errors.
 Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11519#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs