[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9957 [Tor]: Tor should consider stderr output of transport proxies

#9957: Tor should consider stderr output of transport proxies
------------------------+--------------------------------
     Reporter:  wfn     |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  minor   |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-pt
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------

Comment (by asn):

 Patch looks plausible.

 Three comments:
 a) `configure_proxy()` is getting pretty big. Maybe move stderr reading to
 a function, and call it from `configure_proxy()`?

 b) With regards to the `log_notice()` message, maybe we should call it
 `standard error stream` or just `stderr`? I'm not sure if it's a pipe.
 Maybe we should just suggest people to look into INFO-level logs, since
 obfsproxy doesn't log to a file by default, and some times it doesn't have
 time to write a logfile when this error appears (in ImportErrors, etc.).

 c) I wonder what PTs currently output to stderr. Maybe if we are serious
 about this, we should add another convention to `pt-spec.txt` asking PTs
 to not print stuff in stderr except if they have error messages that the
 user should see.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9957#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs